From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7536CA0ED1 for ; Mon, 18 Aug 2025 22:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U4fNNHMo/TYLpcfiNJTGbwkS++e5E0/coVwTtQoHJp0=; b=i6B3Lvj1jGJxu9 ARdPqzSvK/TMB6SfXnZCVO208BxHaFPDtyxOAyRXX/5z8Mt6DKzHbJ/tSEMH4TqCROHZydyYjPvx5 fyqZXeiYzoAxY1ntxzfc3NsgV1OOPBP67B6TJBtNYoyVQjhfiNOpwsziNxsKe+m0G4APwkQ94kJHJ ehs5dkBZ7Yz/qkJqdXxGKC81uo4GEb7iHzjE8OQNXf2hk/Jvsdmszife8Yr78kay42j0ZTmoDPcxX lx5ys9Nm/9ppLA5/+enekw0bZMwoW2nXroPdJjsa2jQah6k19bg4t12HmDacXGCzTobM9MFin77YT Vm2o4ZTj6gUi+hPKlwoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uo8hq-00000008rbF-0uSt; Mon, 18 Aug 2025 22:51:58 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uo83L-00000008oF0-37FA for linux-riscv@lists.infradead.org; Mon, 18 Aug 2025 22:10:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 98C9745777; Mon, 18 Aug 2025 22:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5069AC4CEEB; Mon, 18 Aug 2025 22:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755555006; bh=xj3JxOXQyWu37kJaLPQqWy86cPH8xawvdDtVq3Ay34o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dohpnvq9ouhIqIN48XC6yPAtnj1Jhn5Bwfz5MrFpEaMb9xpOTAaZ4O4aR4Asqokfb xDjl+y9nGnQanpAMsYRmhcUtJzA1qXd8dZsG/RaoTo6or/Z/6bl+3Tv3rqcADUqZto +783ODkgwviLXxoskf9ZYVIi4moAI/mQskz2IULpdyhd/uQ10y7owTHNbVXAgArmWQ wIK0dPuMXd0ru5tdl691HFVFygW0cQ0E9AHd6M6fYoyYrHzfmd/DyWpOXyPgkxqW+w 7/zDXhfnewFwJSrSa25aLYp7/+EpNjxYxBs3eUac+O36cXyPNGNiBzqp+WKe9HRvMQ zY4DsLBvpaXbQ== Date: Mon, 18 Aug 2025 15:10:04 -0700 From: Drew Fustini To: Icenowy Zheng Cc: Guo Ren , Fu Wei , Michael Turquette , Stephen Boyd , Michal Wilczynski , Han Gao , Yao Zi , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] clk: thead: th1520-ap: allow gate cascade and fix padctrl0 Message-ID: References: <20250816084445.2582692-1-uwu@icenowy.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250816084445.2582692-1-uwu@icenowy.me> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250818_151007_814745_EC1C71D3 X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, Aug 16, 2025 at 04:44:43PM +0800, Icenowy Zheng wrote: > Current ccu_gate implementation does not easily allow gates to be clock > parents because of the waste of struct clk_hw in struct ccu_gate; > however it's found that the padctrl0 apb clock gate seems to be > downstream of perisys-apb4-hclk, gating the latter w/o gating the former > makes the padctrl0 registers inaccessible too. > > Fix this by refactor ccu_gate code, mimicing what Yao Zi did on > ccu_mux; and then assign perisys-apb4-hclk as parent of padctrl0 bus > gate. > > Icenowy Zheng (2): > clk: thead: th1520-ap: describe gate clocks with clk_gate > clk: thead: th1520-ap: fix parent of padctrl0 clock > > drivers/clk/thead/clk-th1520-ap.c | 386 +++++++++++++++--------------- > 1 file changed, 189 insertions(+), 197 deletions(-) > > -- > 2.50.1 Thank you, I've applied this to thead-clk-for-next [1]: 9e99b992c887 clk: thead: th1520-ap: fix parent of padctrl0 clock aaa75cbd5d4f clk: thead: th1520-ap: describe gate clocks with clk_gate -Drew [1] https://git.kernel.org/pub/scm/linux/kernel/git/fustini/linux.git/log/?h=thead-clk-for-next _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv