Re: [PATCH v1 15/20] iommu/fsl_pamu_domain: Implement fsl_pamu_domain_test_device

Nicolin Chen
2025-10-15T22:03:24Z

On Sun, Oct 12, 2025 at 05:05:12PM -0700, Nicolin Chen wrote:
> +static int fsl_pamu_domain_test_device(struct iommu_domain *domain,
> + struct device *dev, ioasid_t pasid,
> + struct iommu_domain *old)
> +{
...
> + liodn = of_get_property(dev->of_node, "fsl,liodn", &len);
> + if (!liodn) {
> + pr_debug("missing fsl,liodn property at %pOF\n", dev->of_node);
> + return -ENODEV;
> + }
> +
> + guard(spin_lock_irqsave)(&dma_domain->domain_lock);

Sorry. This should be:
guard(spinlock_irqsave)(&dma_domain->domain_lock);

I have fixed this locally, and did the full build tests on all
impacted arches.

I will send a v2 next week while collecting review comments here.

Thanks
Nicolin