From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E812D1118D for ; Thu, 27 Nov 2025 01:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bQq5WDDcrv2doq9Jk/jXSs5pvvMk/u7+9FSc4xHrB2M=; b=azrDrwVIjomVqA avHF6p5UFx5FLlbb1sLTGmdY8HsQZVjKwfhXwnDMkpXXoyGLBlEAvov3nW9BdwcdgB0HULnM/9zoA rkzWpKOokT1STyFbQ1BDmMnmqnO97X7T8Pqs8H4Lc17YAjGItyTxYP49PTruiTUgi0qeJ2Xz1uYS8 /iqDDj7wO9KJ6MHKbP5mfXcnKbNCFb+nGaKrRbYV3cL9kFotCiQmwHhWgn93zMY5W4FcxhW2T/ad7 K5n0SXqnodJI3/s8aUqzbCG6c7nc1aZnBnXLURMsYzgES41uEfILCisw5fN+XCSHCf+fbr/JAZnKf UIjLbOkmD8RRu2NkqLeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOQjO-0000000Fql1-268N; Thu, 27 Nov 2025 01:23:34 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOQjK-0000000Fqjr-2l3O for linux-riscv@lists.infradead.org; Thu, 27 Nov 2025 01:23:32 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-477b198f4bcso1539745e9.3 for ; Wed, 26 Nov 2025 17:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1764206609; x=1764811409; darn=lists.infradead.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:from:to:cc:subject:date :message-id:reply-to; bh=tNuNk1yaizw865Qq2SQ1TPwZonHkT+uQRcwOIFsLCps=; b=CgRciPv7GMQvcCUrxKZnEFY1aP6xtFubok/uWgmcenrLV4Pyqou/WOlhCJyNE6fwGn Rw/frKUjg/P22nu9Iv7w33FsPuX0tB89huHw/lk7MOCXw/MBNuVDBED+sCSsOF311IXs aQAxJmeJmkBVupswsEMJX+HckaGeNF+BJL/szemlLSqU/COkThMv4N/x8Bj3OteqJs5s CugRgwnejTWUeN+2D536a5ulKv/XdBLVm59U1xIIrbddISHzjhRXWU7s3c79qoWNpxty A9Sk12CkKQRo/nT+CLaMrSY1FCdMQrhhhzhvDq8AQa3ZLhIlD2Y88CoOsjK2ZFEPIvjY PhBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764206609; x=1764811409; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tNuNk1yaizw865Qq2SQ1TPwZonHkT+uQRcwOIFsLCps=; b=P79aEyLwA9j86fJjrqmJI131xwJO9FsqVfwt5wmy3TydbCTaS3lUduWK++0xvPvsB9 PXWBBY2m/HZgGzs086cSYdM5MdAxa2rDWmAcnQ7lqEg5tGx+wUAY1QBoDQNdHoAQwwk5 re8GZb+ztsCmE5Q70ewjAf2OEgtuVAG+m9bWtP/CYOyJR9fl5fPC7UkUdIfG4HrDV0GO zy+8zd7WYHR/MjxMDL1hG3BKSMBM5GWSg15OZjQkT17ZKDC0BlMDRn8WnjkQryhIrIOf e8rifk/ERkebrG7NjSvaChJLbULzBRP04kk9yr4nnJVIrdFdi5pYReRES46diRMnO6Tm daVA== X-Forwarded-Encrypted: i=1; AJvYcCUm5sgpteylO+cOChpD2dALtnTbrolo4zhhiaNGOBg1C55D6t3VHxT85UKVyXjdU87GRRBms22NHNx4MA==@lists.infradead.org X-Gm-Message-State: AOJu0Yzu5+TgKWvbNNcnYC7UL6OzXC903SYyzxKeIMVrEGNmI4+N2+Rw IKT/Hxs3i42VR4ctE7Lfqy2vg1f9kVr6Bu8cfqaMn9Hfo/VxDPSKpl9kvwqAesqV9ys= X-Gm-Gg: ASbGnctYX8+McK4bgXcAG/dqNN6o5mnRecTUj8K9zUBz4YTVPF3zxLWaSoG162BeDNA luoBL2XL41TtgoIsVW2ieuhUOrZm/iA3+VVNASTRLuY+APZk7xtP1x3Q2gGr15AID07djQ7BCbr SccEJ3nSfkfU5RZWPupP7c+oMSpL3yoWoHKJ8pmZtYDg2D1x7FLjgnRqsvNPm8154r6yuLV/vMD axGlKHHTvHaO9L8YL3TJafWe+V5GA2a9dxHmggJIHGEVR+ausvyg8rcwFNsuF+9hHqzRRGgnszj hsfKP2a37evJXn1/wT6mm9yBwF5MT7V4c1bRntWC87I0UdPGFgFLbAjfpta2jz2sFSvMv4OYSz+ sLEaI4DGtB2vQ7cRZqzUqDduphtajHnzZoWDxoNBazWAEWVPcdtni7p08GYTdUE6tLc20ASZxT7 oWpShVGu7a1x9ffUJgiOL2rImCLHBfjj2C X-Google-Smtp-Source: AGHT+IFAI6GQD9lcY1JxdhkE8Lv0II4oKq4ojcJkBaGXT4DCZOTPlduoBmiQE99ST1DmviiNV2jnsw== X-Received: by 2002:a05:600c:450f:b0:46d:ba6d:65bb with SMTP id 5b1f17b1804b1-477c01eb9bdmr241739295e9.31.1764206608732; Wed, 26 Nov 2025 17:23:28 -0800 (PST) Received: from r1chard (1-169-246-18.dynamic-ip.hinet.net. [1.169.246.18]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f0243b19sm22661544b3a.37.2025.11.26.17.23.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 17:23:27 -0800 (PST) From: Richard Lyu X-Google-Original-From: Richard Lyu Date: Thu, 27 Nov 2025 09:23:19 +0800 To: Thomas Zimmermann , ardb@kernel.org, javierm@redhat.com, arnd@arndb.de, helgaas@kernel.org Cc: x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 5/9] sysfb: Pass sysfb_primary_display to devices Message-ID: References: <20251126160854.553077-1-tzimmermann@suse.de> <20251126160854.553077-6-tzimmermann@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251126160854.553077-6-tzimmermann@suse.de> User-Agent: Mutt/2.2.13 (2024-03-09) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251126_172330_737790_729A470A X-CRM114-Status: GOOD ( 20.80 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Reviewed-by: Richard Lyu On 2025/11/26 17:03, Thomas Zimmermann wrote: > Instead of screen_info, store a copy of sysfb_primary_display as > device data. Pick it up in drivers. Later changes will add additional > data to the display info, such as EDID information. > > Signed-off-by: Thomas Zimmermann > Acked-by: Arnd Bergmann > Acked-by: Ard Biesheuvel > --- > drivers/firmware/sysfb.c | 5 +++-- > drivers/gpu/drm/sysfb/efidrm.c | 9 ++++++--- > drivers/gpu/drm/sysfb/vesadrm.c | 9 ++++++--- > drivers/video/fbdev/efifb.c | 10 ++++++---- > drivers/video/fbdev/vesafb.c | 10 ++++++---- > drivers/video/fbdev/vga16fb.c | 8 +++++--- > 6 files changed, 32 insertions(+), 19 deletions(-) > > diff --git a/drivers/firmware/sysfb.c b/drivers/firmware/sysfb.c > index 1f671f9219b0..8833582c1883 100644 > --- a/drivers/firmware/sysfb.c > +++ b/drivers/firmware/sysfb.c > @@ -141,7 +141,8 @@ static struct device *sysfb_parent_dev(const struct screen_info *si) > > static __init int sysfb_init(void) > { > - struct screen_info *si = &sysfb_primary_display.screen; > + struct sysfb_display_info *dpy = &sysfb_primary_display; > + struct screen_info *si = &dpy->screen; > struct device *parent; > unsigned int type; > struct simplefb_platform_data mode; > @@ -202,7 +203,7 @@ static __init int sysfb_init(void) > > sysfb_set_efifb_fwnode(si, pd); > > - ret = platform_device_add_data(pd, si, sizeof(*si)); > + ret = platform_device_add_data(pd, dpy, sizeof(*dpy)); > if (ret) > goto err; > > diff --git a/drivers/gpu/drm/sysfb/efidrm.c b/drivers/gpu/drm/sysfb/efidrm.c > index 1b683d55d6ea..29533ae8fbbf 100644 > --- a/drivers/gpu/drm/sysfb/efidrm.c > +++ b/drivers/gpu/drm/sysfb/efidrm.c > @@ -4,7 +4,7 @@ > #include > #include > #include > -#include > +#include > > #include > #include > @@ -141,6 +141,7 @@ static const struct drm_mode_config_funcs efidrm_mode_config_funcs = { > static struct efidrm_device *efidrm_device_create(struct drm_driver *drv, > struct platform_device *pdev) > { > + const struct sysfb_display_info *dpy; > const struct screen_info *si; > const struct drm_format_info *format; > int width, height, stride; > @@ -160,9 +161,11 @@ static struct efidrm_device *efidrm_device_create(struct drm_driver *drv, > size_t nformats; > int ret; > > - si = dev_get_platdata(&pdev->dev); > - if (!si) > + dpy = dev_get_platdata(&pdev->dev); > + if (!dpy) > return ERR_PTR(-ENODEV); > + si = &dpy->screen; > + > if (screen_info_video_type(si) != VIDEO_TYPE_EFI) > return ERR_PTR(-ENODEV); > > diff --git a/drivers/gpu/drm/sysfb/vesadrm.c b/drivers/gpu/drm/sysfb/vesadrm.c > index 7b7b5ba26317..16fc223f8c5b 100644 > --- a/drivers/gpu/drm/sysfb/vesadrm.c > +++ b/drivers/gpu/drm/sysfb/vesadrm.c > @@ -4,7 +4,7 @@ > #include > #include > #include > -#include > +#include > > #include > #include > @@ -391,6 +391,7 @@ static const struct drm_mode_config_funcs vesadrm_mode_config_funcs = { > static struct vesadrm_device *vesadrm_device_create(struct drm_driver *drv, > struct platform_device *pdev) > { > + const struct sysfb_display_info *dpy; > const struct screen_info *si; > const struct drm_format_info *format; > int width, height, stride; > @@ -410,9 +411,11 @@ static struct vesadrm_device *vesadrm_device_create(struct drm_driver *drv, > size_t nformats; > int ret; > > - si = dev_get_platdata(&pdev->dev); > - if (!si) > + dpy = dev_get_platdata(&pdev->dev); > + if (!dpy) > return ERR_PTR(-ENODEV); > + si = &dpy->screen; > + > if (screen_info_video_type(si) != VIDEO_TYPE_VLFB) > return ERR_PTR(-ENODEV); > > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > index 0e1bd3dba255..47ebc0107209 100644 > --- a/drivers/video/fbdev/efifb.c > +++ b/drivers/video/fbdev/efifb.c > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include > #include