From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55B8FD2ECF9 for ; Tue, 20 Jan 2026 05:06:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uuy0v/ZzHrr0QzHLwBJv9uWeGSk5xt0pGDI1w3ibjUY=; b=ImHNd0T5AasHUr zhIPFTZOUoT2pPzTQDo5OI1krAyaJE5ecgV0XskQZPKxUBxy2bqVip6DOFSVakf9zXXIKQHZFJwWI rPDLZxWm5+emNYQGJL6QuXBGFtsUot3VBinewDRURAJtGjH8QSapXjoMLrmWAaobYpAcjEXOxcval Fgodz88kY7HHrLGdY9vUkh2bM0c3Fkgn/YByuXM13MnjRErpR/AnPOHOtzBZBJItR2YTS9ld8h6UK 93pwEb85deFOm4MEAJ1UzUD/8ubqMvTgbJPmP2IGhGRhvW+uB2ZQPGbEhom9NAnuLwD7EaIsNThrp fhtP1/ssf7r1YnqPYrMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vi3wD-00000003DTy-3QfP; Tue, 20 Jan 2026 05:05:57 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vi3wC-00000003DTK-0x6N for linux-riscv@bombadil.infradead.org; Tue, 20 Jan 2026 05:05:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gFedj4f11o/3T9vWUp8OttHw6rjgwlEi4dqKoM80zmU=; b=a49Eb0mo4bY2C1uobD0xOMn2CI IijlNZvmBVzRCQkWuH1DJIyKol/sFlbccjl35JBRCA1nWIMWleh51RyPFidOxru60UN4Ye7g6A3vP SzrejqE8qHNieKdzLD7DIJXMw9xvXkaJMT317r7Mi3f1Xx547Z8YWz4HxcgcgobOVES/EKitQaRZO 6yCXCC3nBUqyHl3gKn4tyjHqULSWft25wI67ICZf6qHK3ZhjK2/8rC7ikRc1XmEBvwHNkyUzLa7Jy gO6NBZ8/maVKQyGh3YlFtQ+DH9yiHOg1nWAELH+8+EjyBiBbI42/Calltg0c/Lzz8u5UZPPm2Z3hs ErEcJ4pg==; Received: from mail-dl1-x1229.google.com ([2607:f8b0:4864:20::1229]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vi3w7-0000000DLkZ-3OAR for linux-riscv@lists.infradead.org; Tue, 20 Jan 2026 05:05:54 +0000 Received: by mail-dl1-x1229.google.com with SMTP id a92af1059eb24-1233b172f02so6115004c88.0 for ; Mon, 19 Jan 2026 21:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768885549; x=1769490349; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gFedj4f11o/3T9vWUp8OttHw6rjgwlEi4dqKoM80zmU=; b=by4lFM8WQlXKapclGOIaJcnfqoPRVWg2+WsNMYjkI4rL8M487U0IEXkbXN5xPMlzm4 wGmMZt6kpZWwBx0XZHbfVdvBiE90bXBE3tZvSyRcRdNCBaXzxyHBsb4I1cSbCcjPUvYe JYAyBrzXZ9j17wbHltu7VXu2JVlsdQsomBjiJmh/gSndSfh6wZqZlrmtnI+gRI3JIv0N OeD/2DjntLEVkGy/lhKvo64tDxOcaGN03tgwdKsJ6Y2cgJ5GUqSyZTaDb+gXJWt5JmAm DO3WGP916SuuoynjwBRiWkmjXrB+RT2BQR1A+6xO7h+heef0+usFkJOxIkqIUGihxjvU 7m8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768885549; x=1769490349; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gFedj4f11o/3T9vWUp8OttHw6rjgwlEi4dqKoM80zmU=; b=Oms70U0Suaf5+t1tx/0I0ZlGMa54PxGC/4rgxkgVUKyav5f7DfsnmiKZbm23j9SIRb anhayUFjQIY0D8kLaGq9pckC8Sx1TNqrdIuSdcHwKDoFkZPWUojNfUgHnEqsk9R6IB/v HFa60LNs9qbpCkjTxOFYmu5xzwl6McOZtgqb2GXwFR6Lydev/x1E9VDMARFPmjFy2InA oKn8sq2OnlsCuQGc6OlviUk/I4tlRWr7Pkq8GM6BCP0rrCIYxFAZDZM0W09i0nuAb5Q7 mseeKIj67Q6qcIgEajqeBdMFiv+ixlAgmQ6PFuHKeZwjQJ+w4chmTsPZZHcGw3m2OyOz CZnA== X-Forwarded-Encrypted: i=1; AJvYcCU9ssBweQIGfHCRn+5PACvEbNkeIx835H0aYLAYg6v6TLtQ8RV2WCtP+hVPIkcfnWL7tAMU8iUlYsjupw==@lists.infradead.org X-Gm-Message-State: AOJu0Yy20NnYVMfPI5MauMsfhRc1qTG+R59g1Z/17n9gwd0ayDYp1hqS Ji44QIZCm4zVzFlRYIbgiP0EHLtVuPoznBMmqAu4DYp05uNS459exhM6 X-Gm-Gg: AY/fxX7/jUmmha9vDmNvDgB3PpG14G6AxlQP00XiDJWlwwhW8UsgkZgV2Cz/JFY2fK1 eQQbAQ6wVGoxb2g9MRhBeXyTUdKZQSI+CayRi98YGllRc3mr8pNjXFD5q5hdgO/aGqqMqRCa3tA HuxPCMclIAvv0cvUV8PbymM8VsUORsWHKctwxS0OoNmWaJIFQhXvznpNSWN+wY5evW7h8j+DEi+ nL7judfgtHCZY0qy+6bLQfjKYyZLC0ybEVQ1rFD/632kxtQOXjAXMcU/ECOUaSWcswBKS87+TyV 5Q9HA74uepTaiQPo9YRZDUCIz0MOAa/tRfk92i5I4Q71Z6SBUASmvTOfnmA/Hpik/Gsfdy5rsNu btWnbTCWk4n18u8ex8oqJCcXS4q9q4zvmAcWo2d1K8H91m/z0AyfEPIoQubbaeoISNo95zo0VRh Yo9kk5ug72KhQlJZBCmB8o X-Received: by 2002:a05:7022:672a:b0:119:e56b:98bf with SMTP id a92af1059eb24-1246aac3151mr600082c88.38.1768885549389; Mon, 19 Jan 2026 21:05:49 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1244af10736sm19178432c88.14.2026.01.19.21.05.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 21:05:48 -0800 (PST) Date: Tue, 20 Jan 2026 13:05:39 +0800 From: Inochi Amaoto To: "Russell King (Oracle)" , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yanteng Si , Yao Zi , Vladimir Oltean , Lad Prabhakar , Choong Yong Liang , Maxime Chevallier , Chen-Yu Tsai , Shangjuan Wei , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260120043609.910302-1-inochiama@gmail.com> <20260120043609.910302-4-inochiama@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260120_050553_149998_ACA54104 X-CRM114-Status: GOOD ( 24.55 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Jan 20, 2026 at 04:56:32AM +0000, Russell King (Oracle) wrote: > On Tue, Jan 20, 2026 at 12:36:08PM +0800, Inochi Amaoto wrote: > > Adds Spacemit dwmac driver support on the Spacemit K3 SoC. > > Some more information would be useful. E.g. describing why you need to > fix the RGMII mode. > OK. I will add this. > > +/* ctrl register bits */ > > +#define PHY_INTF_RGMII BIT(3) > > +#define PHY_INTF_MII BIT(4) > > + > > +#define WAKE_IRQ_EN BIT(9) > > +#define PHY_IRQ_EN BIT(12) > > + > > +/* dline register bits */ > > +#define RGMII_RX_DLINE_EN BIT(0) > > +#define RGMII_RX_DLINE_STEP GENMASK(5, 4) > > +#define RGMII_RX_DLINE_CODE GENMASK(15, 8) > > +#define RGMII_TX_DLINE_EN BIT(16) > > +#define RGMII_TX_DLINE_STEP GENMASK(21, 20) > > +#define RGMII_TX_DLINE_CODE GENMASK(31, 24) > > + > > +#define MAX_DLINE_DELAY_CODE 0xff > > + > > +struct spacemit_dwmac { > > + struct device *dev; > > + struct clk *tx; > > +}; > > This structure seems unused. > Yeah, I forgot this, will remove in the next version. > > + > > +/* Note: the delay step value is at 0.1ps */ > > +static const unsigned int k3_delay_step_10x[4] = { > > + 367, 493, 559, 685 > > +}; > > + > > +static int spacemit_dwmac_set_delay(struct regmap *apmu, > > + unsigned int dline_offset, > > + unsigned int tx_code, unsigned int tx_config, > > + unsigned int rx_code, unsigned int rx_config) > > +{ > > + unsigned int mask, val; > > + > > + mask = RGMII_RX_DLINE_STEP | RGMII_TX_DLINE_CODE | RGMII_TX_DLINE_EN | > > + RGMII_TX_DLINE_STEP | RGMII_RX_DLINE_CODE | RGMII_RX_DLINE_EN; > > + val = FIELD_PREP(RGMII_TX_DLINE_CODE, tx_config) | > > + FIELD_PREP(RGMII_TX_DLINE_CODE, tx_code) | RGMII_TX_DLINE_EN | > > + FIELD_PREP(RGMII_TX_DLINE_CODE, rx_config) | > > + FIELD_PREP(RGMII_RX_DLINE_CODE, rx_code) | RGMII_RX_DLINE_EN; > > These FIELD_PREP() fields look wrong. Did you mean to use DLINE_CODE > both tx_config and tx_code, and did you mean to use TX_DLINE_CODE for > rx_config ? > This should be RGMII_TX_DLINE_CODE. This is a copy paste error, I will fix it. > > + plat_dat->clk_tx_i = devm_clk_get_enabled(&pdev->dev, "tx"); > > + if (IS_ERR(plat_dat->clk_tx_i)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(plat_dat->clk_tx_i), > > + "failed to get tx clock\n"); > > You set plat_dat->clk_tx_i, but you don't point > plat_dat->set_clk_tx_rate at anything, which means the stmmac core > does nothing with this. > Yes, the vendor told me that the internal tx clock rate will be auto changed when the speed rate is changed. So no software interaction is needed. > Given the last two points, has RGMII mode been tested on this > hardware? > In fact I only tested the rgmii-id, which does not change the internal id. I will try the rgmii mode. Regards, Inochi _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv