From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8495AD277DB for ; Sat, 10 Jan 2026 12:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0XHWMg+5ea0o9YSo0VMepIEziKUb57Ldc6rDfBobmV4=; b=IWmhPpu3iByBrQ 5XDuNrbX3DB4gn+XQAO25i7D13JzkGznNgAW2tqJn/O3MpdNviU7imoxieGrnReqwwZc+E4yGfrzP 3nTBsmCzEocmxYeV0NzqFC1hYAEtmAcZY3mcHeGtlDB2nmoww4Hv5KqBKsUy95V739cW0yLQhODP/ S9r79W0ZFF2ozitiHuFb9v210INuyKAvaoZ9tSfns2RB1JfqWli6WTh71ii4LvHMIiuixuxviO351 WMiGd4Wv6GCMMz48/AT8/GGZxasbomd4V4oR4D1v9Qv/f5zEvjkHLmtuHCJSIepifXiFLlk617KJ5 4Amh7TuTp4V2mEVqoxzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1veXi4-00000003RM1-0w9L; Sat, 10 Jan 2026 12:04:48 +0000 Received: from out-173.mta0.migadu.com ([2001:41d0:1004:224b::ad]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1veXi0-00000003RLG-3lku for linux-riscv@lists.infradead.org; Sat, 10 Jan 2026 12:04:47 +0000 Date: Sat, 10 Jan 2026 20:04:31 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1768046679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ob4NmTVz/1WLvwmyOvYr9VoBvTZSG5fIAm7U5cOr0u8=; b=YOMmENC6kQPOjPo8kGD1DeN4WB2LPlUH+7j00+ftKCustTWY0ULPMjNP6E2g1k0WGJptTW fwupuSh2kcdsWwv/rQf+qmnn6Rd1WSjZq021eioZdwT2Xa2SUjjO4gPrCpSLKK2gri7+RS DzyZFrj3CY+MIaxTj0IOBQWLOZ8ke7M= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ze Huang To: Samuel Holland , Ze Huang , Yixun Lan Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Aurelien Jarno Subject: Re: [PATCH v2 3/3] riscv: dts: spacemit: Enable USB3.0 on BananaPi-F3 Message-ID: References: <20260107-k1-usb3dts-v2-v2-0-e659b0f8fe1a@linux.dev> <20260107-k1-usb3dts-v2-v2-3-e659b0f8fe1a@linux.dev> <20260108012157-GYA2355@gentoo.org> <20260108113605-GYA4052@gentoo.org> <5c54077c-f9fd-40c9-84eb-54139db8aaa6@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5c54077c-f9fd-40c9-84eb-54139db8aaa6@sifive.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260110_040445_678697_19828A3C X-CRM114-Status: GOOD ( 39.68 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jan 08, 2026 at 11:21:48PM -0600, Samuel Holland wrote: > Hi Ze, > > On 2026-01-08 10:07 PM, Ze Huang wrote: > > On Thu, Jan 08, 2026 at 07:36:05PM +0800, Yixun Lan wrote: > >> Hi Ze, > >> > >> I've done a quick check of the "regulator-always-on" issue, > >> it's ok to drop the one from hub, but not the vbus one.. > >> > > > > Thanks for your double check > > > >> On 09:21 Thu 08 Jan , Yixun Lan wrote: > >>> Hi Ze, > >>> > >>> thanks for your patch, I have few comments, see below.. > >>> > >>> On 20:05 Wed 07 Jan , Ze Huang wrote: > >>>> Enable the DWC3 USB 3.0 controller and its associated usbphy2 on the > >>>> Banana Pi F3 board. > >>>> > >>>> The board utilizes a VLI VL817 hub, which requires two separate power > >>>> supplies: one VBUS and one for hub itself. Add two GPIO-controlled > >>>> fixed-regulators to manage this. > >>>> > >>>> Tested-by: Aurelien Jarno > >>>> Signed-off-by: Ze Huang > >>>> --- > >>>> arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 48 +++++++++++++++++++++++++ > >>>> 1 file changed, 48 insertions(+) > >>>> > >>>> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > >>>> index 3f10efd925dc..013df91c6a4c 100644 > >>>> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > >>>> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts > >>>> @@ -59,6 +59,26 @@ reg_vcc_4v: vcc-4v { > >>>> regulator-always-on; > >>>> vin-supply = <®_dc_in>; > >>>> }; > >>>> + > >>>> + usb3_vbus: regulator-vbus-5v { > >>> I've checked the schematics, the name is 5V_VBUS there, so for the consistency > >>> with previous naming convention, let's change to: > >>> usb3_vbus_5v: usb3-vbus-5v > >>> > >>>> + compatible = "regulator-fixed"; > >>>> + regulator-name = "USB30_VBUS"; > >>>> + regulator-min-microvolt = <5000000>; > >>>> + regulator-max-microvolt = <5000000>; > >>> .. > >>>> + regulator-always-on; > >>> do you think the "always-on" property really necessary? it indicate the > >>> power regulator is critical, and should never been disabled even during > >>> suspend/resume state, for the case of USB, I think it should be totally > >>> fine to poweroff once the device is not used(suspended) or even disabled > >>> > >>> besides, the regulator is designed with a gpio enabling/disabling control > >>> which means it can be powered to on/off state? > >>> > > > > > >> not ok to drop, see comment below at &usb_dwc3 > > > >> > >>>> + gpio = <&gpio K1_GPIO(97) GPIO_ACTIVE_HIGH>; > >>>> + enable-active-high; > >>>> + }; > >>>> + > >>>> + usb3_vhub: regulator-vhub-5v { > >>> why use vhub, but not hub? where does this name come from? > >>> > >>> and for same reason, the name in schematics is VCC5V0_HUB, so how about > >>> change it to: > >>> usb3_hub_5v: usb3-hub-5v > >>> > >>>> + compatible = "regulator-fixed"; > >>>> + regulator-name = "USB30_VHUB"; > >>> ~~~need to fix too, if above is valid > >>>> + regulator-min-microvolt = <5000000>; > >>>> + regulator-max-microvolt = <5000000>; > >>> .. > >>>> + regulator-always-on; > >>> ditto > > > >> ok to drop, as it's already handled at drivers/usb/misc/onboard_usb_dev.c > >> which will explicitly request the regulator and enable it > > > >> > >>>> + gpio = <&gpio K1_GPIO(123) GPIO_ACTIVE_HIGH>; > >>>> + enable-active-high; > >>>> + }; > >>>> }; > >>>> > >>>> &combo_phy { > >>>> @@ -67,6 +87,34 @@ &combo_phy { > >>>> status = "okay"; > >>>> }; > >>>> > >>> .. > >>>> +&usbphy2 { > >>>> + status = "okay"; > >>>> +}; > >>>> + > >>>> +&usb_dwc3 { > >>>> + dr_mode = "host"; > >>>> + vbus-supply = <&usb3_vbus>; > >> due to drivers/usb/dwc3/dwc3-generic-plat.c has no handler to request regulator > >> there will be problem if "regulator-always-on" property is removed.. > > > > On the BananaPi-F3 and to Jupiter, the VL817 hub setup uses two distinct controls: > > > > GPIO97 controls the physical VBUS supply. > > GPIO123 controls the VCC5V0_HUB supply for the hub logic. > > > > (Note: This differs from the Orange Pi RV2, where only GPIO123 is used to > > control the VBUS supply). > > > > dwc3-generic-plat can not currently handle the regulator request explicitly, > > keeping "regulator-always-on" forces the VBUS to remain active even when > > suspended, which consumes unnecessary power. > > > > I prefer to drop regulator-always-on in the DTS to accurately describe the > > hardware capability, and let the driver manage the VBUS state. This ensures > > better power management. > > > > If anyone have other ideas, please let me know. > > If a USB device requires board-level resources to function, then the USB device > itself (not the controller) needs a DT node that references these resources. > This is the purpose of the usb-device.yaml binding. For the VL817 hub, there is > a specific binding that links the highspeed and superspeed hubs together. See > Documentation/devicetree/bindings/usb/vialab,vl817.yaml. These nodes are matched > with the Linux usb-onboard-hub driver. > Hi Samuel, Thank you for the guidance. I agree that VBUS control is a board-level resource and handling it at host controller level is not appropriate. I noticed Marco Felsch's patch series "[PATCH v4 0/5] Add onboard-dev USB hub host managed vbus handling support", which adds support for optional vbus-supply at the USB port level. This matches our hardware situation perfectly. To avoid dependencies on unmerged code, I plan to stick with the "regulator-always-on" approach in the next version (v3). Once Marco's series is merged into the kernel, I will follow up with a patch to switch to the port-based VBUS supply method. Link: https://lore.kernel.org/all/20250911-v6-16-topic-usb-onboard-dev-v4-0-1af288125d74@pengutronix.de/ Best regards, Ze > Regards, > Samuel > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv