Re: [PATCH 3/8] clk: tenstorrent: Add Atlantis clock controller driver

Krzysztof Kozlowski
2026-01-16T09:00:45Z

On Thu, Jan 15, 2026 at 09:05:35PM -0500, Brian Masney wrote:
>
> > +static void atlantis_ccu_lock(void *_lock)
> > +{
> > + spinlock_t *lock = _lock;
> > +
> > + spin_lock(lock);
> > +}
> > +
> > +static void atlantis_ccu_unlock(void *_lock)
> > +{
> > + spinlock_t *lock = _lock;
> > +
> > + spin_unlock(lock);
> > +}
>
> Are these abstractions really needed? Why not just call spin_lock/unlock
> directly?

They are actually harmful - make code less readable and introduce very
poor (lose) API accepting whatever pointer... This is exactly code which
should notbe here.

Best regards,
Krzysztof