Re: [PATCH 6/8] soc: tenstorrent: Add auxiliary device definitions for Atlantis

Krzysztof Kozlowski
2026-01-16T09:07:49Z

On Thu, Jan 15, 2026 at 05:42:05PM -0600, Anirudh Srinivasan wrote:
> Reset shares the same registers as the Clock Controller, so it is
> implemented as an auxiliary device of the Clock Controller.
>
> This commit adds the auxiliary device definitions needed for this.
>
> Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
> ---
> include/soc/tenstorrent/atlantis-syscon.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/soc/tenstorrent/atlantis-syscon.h b/include/soc/tenstorrent/atlantis-syscon.h
> index f1dc6ad33c6d..972a9b7da596 100644
> --- a/include/soc/tenstorrent/atlantis-syscon.h
> +++ b/include/soc/tenstorrent/atlantis-syscon.h
> @@ -8,6 +8,14 @@
> #include <linux/bits.h>
> #include <linux/types.h>
>
> +struct atlantis_ccu_adev {
> + struct auxiliary_device adev;
> + struct regmap *regmap;
> +};

Completely pointless. You do not have any user of this.

Adding a few unused lines is not a logical change to the kernel. Why not
adding it member by member like one patch for empty struct, then second
patch for struct with adev, then third patch adding regmap?

Best regards,
Krzysztof