Linux-RISC-V Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Inochi Amaoto <inochiama@gmail.com>
To: Chen Wang <unicorn_wang@outlook.com>,
	 Inochi Amaoto <inochiama@gmail.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	 Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>, Han Gao <rabenda.cn@gmail.com>,
	 Nutty Liu <liujingqi@lanxincomputing.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	 Zixian Zeng <sycamoremoon376@gmail.com>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	 sophgo@lists.linux.dev, linux-kernel@vger.kernel.org,
	Yixun Lan <dlan@gentoo.org>,  Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH 1/2] riscv: dts: sophgo: Move PLIC and CLINT node into CPU dtsi
Date: Sat, 17 Jan 2026 08:37:45 +0800	[thread overview]
Message-ID: <aWrZpoMOwTnFqlGN@inochi.infowork> (raw)
In-Reply-To: <MA5PR01MB1250082D757C8DEFE005EE71AFE8CA@MA5PR01MB12500.INDPRD01.PROD.OUTLOOK.COM>

On Thu, Jan 15, 2026 at 08:49:54AM +0800, Chen Wang wrote:
> 
> On 1/13/2026 10:38 AM, Inochi Amaoto wrote:
> > As we have a separate CPU dtsi file, move the PLIC and CLINT
> > node to the CPU dtsi file. This will make the sg2042.dtsi force
> > peripheral devices, and make the CPU dtsi force CPU related
> > devices.
> LGTM, except for the word "force" in the commit message; it seems a bit odd.
> Perhaps it would be better to write: "This will make all peripheral devices
> are defined in the sg2042.dtsi
> 
> and all CPU-related are defined in the CPU dtsi."
> 
> Reviewed-by: Chen Wang <unicorn_wang@outlook.com>
> 

Thanks, it should be "focus on", I wrote a wrong word, If it is
OK, I will fix this mistake when merging.

Regards,
Inochi

> > 
> > Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> > ---
> >   arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi | 305 ++++++++++++++++++++
> >   arch/riscv/boot/dts/sophgo/sg2042.dtsi      | 303 -------------------
> >   2 files changed, 305 insertions(+), 303 deletions(-)
> > 
> > diff --git a/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi b/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi
> > index 94a4b71acad3..509488eee432 100644
> > --- a/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi
> > +++ b/arch/riscv/boot/dts/sophgo/sg2042-cpus.dtsi
> 
> [......]
> 
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-01-17  0:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13  2:38 [PATCH 1/2] riscv: dts: sophgo: Move PLIC and CLINT node into CPU dtsi Inochi Amaoto
2026-01-13  2:38 ` [PATCH 2/2] riscv: dts: sophgo: fix the node order of SG2042 peripheral Inochi Amaoto
2026-01-15  0:51   ` Chen Wang
2026-01-15  0:49 ` [PATCH 1/2] riscv: dts: sophgo: Move PLIC and CLINT node into CPU dtsi Chen Wang
2026-01-17  0:37   ` Inochi Amaoto [this message]
2026-01-17  0:55     ` Chen Wang
2026-01-20  1:16 ` Inochi Amaoto
2026-01-20  2:48   ` Inochi Amaoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWrZpoMOwTnFqlGN@inochi.infowork \
    --to=inochiama@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=liujingqi@lanxincomputing.com \
    --cc=looong.bin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=rabenda.cn@gmail.com \
    --cc=robh@kernel.org \
    --cc=sophgo@lists.linux.dev \
    --cc=sycamoremoon376@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox