From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E830DD25B44 for ; Wed, 28 Jan 2026 11:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/cD4KMYtF68+YwgwzQSpPBe7NamKtJEF1v0BP4J1rl8=; b=mrEZQ50JOgXsv1 mlKQNgwFKku7pvG+up9OkCTivbEUXa/o7yldL3ixUJy3SKoqz6pK9QmZNpwrLy6/hxrGlqXxNau86 ZMaEzn2YGV3gEdT5tm5F+bPdr8fUpFufZEFMD2hhV9soLtF2NhATKN8Os/ATb6h5F+0w/Loi9RBEz dHUvTEzDd3MQeIVaXsxSLl/3E5HxRpwEmJTNj+FQPqvsWoUNJemmAidS4voICVRf/vhkApfxfrirI nMiDH/mWrDJK2FiHN/sCtIsSby1B9lPIkDdYlnSX0rud1umEVwCO+BWxU38jTlblTTFA9beR8MJSU S7COhfYIgW2HqqcARWaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vl3ar-0000000FuQz-1vcv; Wed, 28 Jan 2026 11:20:17 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vl3aq-0000000FuQV-0Kg7 for linux-riscv@bombadil.infradead.org; Wed, 28 Jan 2026 11:20:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2qYF+OMHzpUpn67zzVLUIwDwbqG7uxpk42nhaKidxBE=; b=FI+P1nLyIhT1sv9CAWpQ3Px+C5 ji9vbtAE4Gd5ukGyo03TzmeVJ0o711VeY5wp4v2Ur1EGdgmeY79oZETYm9ftEZVtK2g4WoG+WRl/i 4kVJUT2BqGd1tgYrSRazTk9Wqk7JEQEyjWCKyy4DksksYtqu8NISPxfig8u4i8U7UnjkvFE3X1kmV m8TCB4HP0dXBWlpGJ8G/K5WdW4FPu6DJIi9bGP0lGGIThJp5xjObPG7SqGV56nkQd3mkVwx/YSels NkER9DovMOtBuwVwo2i2CfNwpuAu50KDJfy4ZN3QSTwiVl8Lh+mT7eMOhCzUvTU/vULjRPSWLIeUb 3kh6mXAg==; Received: from mail-dl1-x122b.google.com ([2607:f8b0:4864:20::122b]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vl3am-00000008OUd-1cQi for linux-riscv@lists.infradead.org; Wed, 28 Jan 2026 11:20:14 +0000 Received: by mail-dl1-x122b.google.com with SMTP id a92af1059eb24-124877d78a6so4476843c88.1 for ; Wed, 28 Jan 2026 03:20:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769599210; x=1770204010; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2qYF+OMHzpUpn67zzVLUIwDwbqG7uxpk42nhaKidxBE=; b=SlNbvV9wk41Ur9z7jhFYtnaEiCjziARAE2WmBSwys+wLpTjBtPlZFNND89hLdFqdlF 7RbD1lmjf1LFPmAuGWbi/7Gs/NH3qkZ4Z828wGuDfZDtdXIRe576oPCaWHeNGEuFt+xL /c35fFk4uENYDjW8w+1aSettgO7zIl9HCLAz2Wq1HLHAajE0TcsEyU/hH3u+ZfOCfnth B+bjIzYrqRtZqeakdBI44ta3o7ss8sDrywMi6bBHThs34B6OJz0Od7AzgM5reWYVBz1o jBSrR0KYPOIc9PN62ivnxKAdUQVM5OGySxALB9CkcsGpl57ilJw2sHZv77rq14FS6ggj 7IPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769599210; x=1770204010; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2qYF+OMHzpUpn67zzVLUIwDwbqG7uxpk42nhaKidxBE=; b=nTaoRldNVtt4v/2UPOvavur61cHaqaKYUgllsEatS1dsz0RHY9FzLsP+2b6S2wplHP 8QMsqGEmFx68SKm8SzkRbuQmtTnQ95fc07eKdf5ImJ5ykGuaKUJXItkF2GckY+d0IPWV t9po9q7bB2dcmmU3UTHjFIuS3ytSkbQDvbWo6HZMIXATUDmtjW5eeXeTMpqFktwtKijY vRQeNgGoFyg+tF88TEO/2JA0FbGsARR8OOxwRw5bfAPk9VT9LxFpZIR1pMKr15Mjxcj4 9fydSeY37aMrKJ0otNJCq+/Iz1oCIIbJRIAYuTQQYpy22TQ/IORW1dB3K15sXyuwrrXQ O50A== X-Forwarded-Encrypted: i=1; AJvYcCVPbmNRaDvp7mDzLUB7kE3jmb/Me9reeNpdmYTqpds2u6h/UsEm9dVwat/gldvgcMQY/kLvME5GASWGuw==@lists.infradead.org X-Gm-Message-State: AOJu0YzlVYzmCAsdOC19Hh/IR5hn4UCavMlHmDVi83kwKeC0WUnTT1Wm ppkzXJ+1yi6ODUjLk2BK2HdZUNmbtT6fyNu13Vk9FfOblSP0n7YxzamI X-Gm-Gg: AZuq6aK78mbKRdiI1rCMAHCL/GcvCEiuvgIckI1800gpnCEK6nNsS1UrWwBUCQYcACg Ns0OO3RgwwNG3N0PwEjqnYeX/d3T7lhkVGik/xT4akkNBKrpnx1t8ECyW63AGwSsNZaixUJufib WXrGiQxyw44Ph6/o7xIPF+hnl+68eA0CVRsg7Qt0m1N238JZnduA2jH21IDm7C8tRqt8rOczUNv kdu32PY24Fmh9kNViDxi/+6XN/JWUF6xBF0h7bb3Ck90WyIKvTDXKrMJSaDhd8W51tjNntTrYU2 f0rM1xwg8+2qEr4G2KPv0cgDY17gHN9S6mjoPdhKPAAzW/JiU8veLykqz0RODsXU4stH0z5ec3n kufePY2xBeFc4bMh6mltUW2jB2x736JuwrcuOWD/XHKjbogxcr+hZBKn7ReJHRe2sLSMzUo4D9J fFyVrGPW+0FQ== X-Received: by 2002:a05:7022:926:b0:119:e56c:18a8 with SMTP id a92af1059eb24-124a00745c6mr2790960c88.16.1769599209402; Wed, 28 Jan 2026 03:20:09 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9d7f597sm1867369c88.5.2026.01.28.03.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 03:20:09 -0800 (PST) Date: Wed, 28 Jan 2026 19:19:50 +0800 From: Inochi Amaoto To: "Russell King (Oracle)" , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yao Zi , Yanteng Si , Lad Prabhakar , Maxime Chevallier , Choong Yong Liang , Chen-Yu Tsai , Shangjuan Wei , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next v3 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260128072931.875041-1-inochiama@gmail.com> <20260128072931.875041-4-inochiama@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260128_112012_992142_053AAB7F X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Jan 28, 2026 at 10:43:35AM +0000, Russell King (Oracle) wrote: > On Wed, Jan 28, 2026 at 03:29:29PM +0800, Inochi Amaoto wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "stmmac_platform.h" > > + > > +/* ctrl register bits */ > > +#define PHY_INTF_RGMII BIT(3) > > +#define PHY_INTF_MII BIT(4) > > Please add a suitable prefix for these. > > > + > > +#define WAKE_IRQ_EN BIT(9) > > +#define PHY_IRQ_EN BIT(12) > > While you're renaming the PHY_INTF_*, you might wish to also add the > same prefix here to identify that they're all part of the same register. > I think this is good for me. I will add the "CTRL" prefix to identify these are all from ctrl register. Regards, Inochi _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv