From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EBF1FD0078 for ; Sun, 1 Mar 2026 22:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8KXmdTc8qKzl5tJf+42D/3iZfbTT/b0vzbcVQywzMoc=; b=r7W7dlyb4T5vqK omWXjhjy0yHSwrWnkP07IRZz7ZkTWAzGgPLZopc9YkwOSma0YUf2Xo19BM0ADdTqRiXANPdQ8dNTE QUnzNF1rfdAIlIUuL71v2OOWegn9QgQp1tqd2QbZDcthw7fW1GqdT2Rz99o8jzuI7flcBk+/lnmud 3lv3y5kIpWXp4kWC8WEkLM9PDfMPdztFqCOdUYeamMCUEKeqeglVeqIOivPuWmqNE+m7OMt3Ed9sC p1UoXyJoYkFx5Ed5q7ZtQEYO6I1hVyP7yqwVtelk2IcQ2Xh1oz/FYKN/Hf/A7JxMEMBCMSNGYnUtp sNhyQSx01dyKxShpBN3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwp5r-0000000BwUv-1x7Z; Sun, 01 Mar 2026 22:16:55 +0000 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwp5p-0000000BwTK-1kkD for linux-riscv@lists.infradead.org; Sun, 01 Mar 2026 22:16:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=KjrmgbqDuQUoTE7tizH06MNcvn3FP+YVHKxG9kOs+BY=; b=KRMqaNT66WGHYIyuD4Y4Vbgexu jAStbPDQ2v9KhUbU5It83p1lT9e3nB/vQUzRXTX3O8aXvNGmivzBB5/IrFR/G+9bFZQMSEBjeiLQ2 +C+bwt54sqmeOvKaP/cGhmLJBBZw3qrb+sBeRqH0oUDjewPoYQJJO/yXyxUJQ9LH/KwCEV8gBw38l PXT/mkAIEP61vvUdgABIm1b2S9CTMoKlVcHbeO+6ytjZcZRC0W48iNNuYB6ct0pFqftHpJKz76VGA a/hFlahbk55aE20SSLwTqK226Wrag13mOEiFvosWFNvzvNIRjVGKglbSDtLUzfVaziNUft7AtanxT 4BaR/NIw==; Received: from authenticated user by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vwp5a-0000000C8Gc-1plv; Sun, 01 Mar 2026 23:16:38 +0100 Date: Sun, 1 Mar 2026 23:16:37 +0100 From: Aurelien Jarno To: Yanko Kaneti Cc: linux-kernel@vger.kernel.org, Lee Jones , Sebastian Reichel , Troy Mitchell , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:RISC-V ARCHITECTURE:Keyword:riscv" , "open list:RISC-V SPACEMIT SoC Support:Keyword:spacemit" , "open list:SYSTEM RESET/SHUTDOWN DRIVERS" Subject: Re: [PATCH v5 2/2] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip Message-ID: Mail-Followup-To: Yanko Kaneti , linux-kernel@vger.kernel.org, Lee Jones , Sebastian Reichel , Troy Mitchell , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "open list:RISC-V ARCHITECTURE:Keyword:riscv" , "open list:RISC-V SPACEMIT SoC Support:Keyword:spacemit" , "open list:SYSTEM RESET/SHUTDOWN DRIVERS" References: <20251102230352.914421-1-aurelien@aurel32.net> <20251102230352.914421-3-aurelien@aurel32.net> <990bc03ed2baa05e619f0aa9cc6a23acadd66ea6.camel@declera.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <990bc03ed2baa05e619f0aa9cc6a23acadd66ea6.camel@declera.com> User-Agent: Mutt/2.2.13 (2024-03-09) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260301_141653_463951_6C573467 X-CRM114-Status: GOOD ( 28.12 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2026-02-27 13:29, Yanko Kaneti wrote: > On Thu, 2026-02-26 at 22:32 +0100, Aurelien Jarno wrote: > > Hi, > > > > On 2026-02-26 16:32, Yanko Kaneti wrote: > > > Hello, > > > > > > On Mon, 2025-11-03 at 00:02 +0100, Aurelien Jarno wrote: > > > > Add a "spacemit-p1-reboot" cell for the SpacemiT P1 chip. > > > > > > > > Signed-off-by: Aurelien Jarno > > > > --- > > > > v5: no changes > > > > > > > > drivers/mfd/simple-mfd-i2c.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c > > > > index 0a607a1e3ca1d..542d378cdcd1f 100644 > > > > --- a/drivers/mfd/simple-mfd-i2c.c > > > > +++ b/drivers/mfd/simple-mfd-i2c.c > > > > @@ -99,6 +99,7 @@ static const struct regmap_config spacemit_p1_regmap_config = { > > > > }; > > > > > > > > static const struct mfd_cell spacemit_p1_cells[] = { > > > > + { .name = "spacemit-p1-reboot", }, > > > > { .name = "spacemit-p1-regulator", }, > > > > { .name = "spacemit-p1-rtc", }, > > > > }; > > > > > > Perhaps its safe to merge this one now that everything P1 and I2C is > > > already in linus tip ? > > > > Unfortunately, this patchset is still missing: > > https://lore.kernel.org/all/20260207-b4-k3-i2c-pio-v7-0-626942d94d91@linux.spacemit.com/ > > > > This means the reboots work most of the time, but are not 100% reliable, > > and that's the reason why this patch got blocked from merging. > > I see. Thanks. Sounds to me like sometimes working compared to never > working is better , but anyway.. I agree with that, but the decision was to hold on this patch until the I2C PIO part got merged. > FWIW with this patch and the pio patcheset I get this rcu splat on > reboot (which is still working). Similar splat is there without the pio > patcheset. I haven't been able to reproduce the issue here after 10+ reboots on a BPI-F3 board, but I tried the patch on top of 6.19. I'll try to build a 7.0.0-rc2 kernel and report back. At a first glance the problem seems to happen in the I2C PIO code. On which hardware is that happening? Regards Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://aurel32.net _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv