From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C411F3D33C for ; Thu, 5 Mar 2026 17:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=o/aDAIBKHT3opxlye+C1zM1xxPiGQ2uLFGQzXwKIRnU=; b=DHCc20FZ0G40PkDD1JyWJFD73a 5eKgXfHAckQZwxA1dpuVcaW2Z8wi8j4cuUzhoYSs4hReR7fq1leqn6ZDl/PCDiWG+xGpZnfd7pBy/ XCQ7/anFAlb928RL63/XyRz+eiT5FEF9HXPnVLRWKwi9MEw4FTvOFt/9cQNz7H5R7WHI0KZFf4WPO +bdnjS9JT9r+N5gsddDXfcxx4BODl+9K+MsU1sRiODi9i63AazGamjt2HaUkxT1kBYF9ZlVrdVkwV WodF05t9aTNP17xyrmtB+LC/a1GASMnfjeKxXXacqNPoND8+1CCA8cMvmwZrkpWGTa7zIAVxtWD+Z lCgKtT7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyCMO-00000002HHM-2Xf2; Thu, 05 Mar 2026 17:19:40 +0000 Received: from mail-pf1-x44a.google.com ([2607:f8b0:4864:20::44a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyCMM-00000002HFC-0GS8 for linux-riscv@lists.infradead.org; Thu, 05 Mar 2026 17:19:39 +0000 Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-8299499d587so144573b3a.0 for ; Thu, 05 Mar 2026 09:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772731176; x=1773335976; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=jvL7QI7vtAV/elV7wuwJjb0ouQ5MS/0W571Ri2ejdh8=; b=U+/NFEkOWE9jZ0bM1oY079L2ahCo07sLfRKa8o+CYugD3fwHz4jLi3hosu/GwioO3z Cu0Rf+oZdtDq0iaagNRnQCNw6ayYeSXbIG02mosII2OUI3lMgZkf18a/smDNNbiD1uxn Zhr0v5UOjMRzgo/Fn7yuHbdP0+hREaXskn5oFdc7an2+gW633W5jba3qXPuKW0YEUfWb ZEu+r3KDnjJOC44Aq9op2OvP5ADMCWhmfjcXdz2/JBIVvA6MSuHF5MCUnxAnVVpM4JAg b0KM5NgRBO690pF6g/E6LH7gczk4VcwiSRnDVnwTcRuBK0DM9M6OtU7oH80nzutnjeZ1 H7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772731176; x=1773335976; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jvL7QI7vtAV/elV7wuwJjb0ouQ5MS/0W571Ri2ejdh8=; b=AIbxbsZj5IycsYmB/yRb6l1dy9AGXX1Rfd4zBTLfcuixTkhPF/2ihbBXJBBRywrD4e 2Qk+xd+RPvVFUG1zQgR7hUGtPYddOSzKPWGskwvHyQ7B7eQrx9n8cOxK8gbGKKKvy8t2 8OE+JTNAhysXZI7rMUyMyXeHdXn+XutzGlCc6M+yJY1n82wLvVrSj9lD/+9LKt9z3824 trWJb63Ict985NeUbSuKgfguVG80sNTSbC04m3d1sJDzN0mpLPQfb6jMdk6OG+Yi4TAf TrNwSuynayQUoBrKVFBAJvapwFLEmGZ8fFzXcPFa6ipMsuWKc1Jg0WsgHeR7nem3XXpR lWNw== X-Forwarded-Encrypted: i=1; AJvYcCU1EDADQF2HiWlPg8MO5adwJ3BGyGb0n6TKe3ENmbsDyPSwVStvqHfxh31qi9QKIQbd1Gw2D/pbffaVlA==@lists.infradead.org X-Gm-Message-State: AOJu0Yy1nLlIliMF5YvH6RX/1k9V0qaly6ve0ax8OZEacxHybLqoNS99 Gf/5alyREB4GFIdncMuA7b4Rzgkjr+Zn3dKIm+aAT3AxEpgF16Bjcf2fyHwsxiIFI44M0z7SFDS cNctbgQ== X-Received: from pfcp25.prod.google.com ([2002:a05:6a00:a259:b0:829:808f:cb8d]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4295:b0:81b:d5d9:a83a with SMTP id d2e1a72fcca58-8299ae60809mr419972b3a.61.1772731175885; Thu, 05 Mar 2026 09:19:35 -0800 (PST) Date: Thu, 5 Mar 2026 09:19:34 -0800 In-Reply-To: <20260220004223.4168331-5-dmatlack@google.com> Mime-Version: 1.0 References: <20260220004223.4168331-1-dmatlack@google.com> <20260220004223.4168331-5-dmatlack@google.com> Message-ID: Subject: Re: [PATCH v2 04/10] KVM: selftests: Use u64 instead of uint64_t From: Sean Christopherson To: David Matlack Cc: Paolo Bonzini , Ackerley Tng , Albert Ou , Alexandre Ghiti , Andrew Jones , Anup Patel , Atish Patra , Bibo Mao , Christian Borntraeger , Claudio Imbrenda , Colin Ian King , David Hildenbrand , Fuad Tabba , Huacai Chen , James Houghton , Janosch Frank , Joey Gouly , kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, Lisa Wang , loongarch@lists.linux.dev, Marc Zyngier , Maxim Levitsky , Nutty Liu , Oliver Upton , Palmer Dabbelt , Paul Walmsley , "Pratik R. Sampat" , Rahul Kumar , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Wu Fei , Yosry Ahmed , Zenghui Yu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260305_091938_095161_8F34C9A2 X-CRM114-Status: UNSURE ( 7.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Feb 20, 2026, David Matlack wrote: > -static uint64_t pread_uint64(int fd, const char *filename, uint64_t index) > +static u64 pread_uint64(int fd, const char *filename, u64 index) I think it's also worth converting the function to pread_u64(). > { > - uint64_t value; > + u64 value; > off_t offset = index * sizeof(value); > > TEST_ASSERT(pread(fd, &value, sizeof(value), offset) == sizeof(value), _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv