Re: [PATCH] riscv: Move user-visible sbi ext ids to uapi

["BillXiang" <xiangwencheng@lanxincomputing.com>]

On 10/9/2025 4:37 AM, Paul Walmsley wrote:
> Hi Drew,
> 
> On Wed, 8 Oct 2025, Andrew Jones wrote:
> 
>> On Wed, Oct 08, 2025 at 12:17:01PM -0600, Paul Walmsley wrote:
>> ...
>>> I do have some broader questions: is this patch really needed?  Is it
>>> fixing anything that's broken?  These SBI constants aren't defined by the
>>> kernel; they come from RISC-V standards.

Hi All,

Thanks for the review, and sorry for the noise my earlier mistake caused.
Just to clarify the intent of this patch: these SBI constants are
defined by the RISC-V spec, but they are implemented by kernel.
IMO, for a userspace developer working on linux it's better to include
this constants from kernel instead of define them again.
If you don't like the patch, feel free to ignore it, nothing breaks
either way.
Additionally, the goodness of UAPI was described in[1].

[1] https://lwn.net/Articles/507794/

>>
>> Hi Paul,
>>
>> You're right that we don't want this patch. I hadn't noticed that the same
>> patch was posted more than once or I would have nacked it here too. I
>> replied to the other posting[1] a couple weeks ago.
>>
>> [1] https://lore.kernel.org/all/20250924-7e9764acec6722b5ef29ce7d@orel/
> 
> Thanks for the heads up and for the early review.  Patchwork didn't pick
> up the thread for whatever reason beyond the initial patch, and I didn't
> bother to check the mail archive...
> 
> 
> - Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv