From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 523EEFB5EA4 for ; Tue, 17 Mar 2026 02:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/c3gRIQcOmRAQN2QW/O24BqsE4LB/oZobz9dYiDz300=; b=fGUlK8pPKClbSE vtUYuGUQEtyP7QJ9IA8VcsBuphZhAMk/mUnMv70xc0rkg88mvrmwz2cqzTpMCw1kcHcsK0qOICgrv N7+zCVEFkXD9NPkjU4IEZLs/+lLQD3n5H4gowsjLoiOvKZMPUNZQkFACyW/jPzYiY1i0uYoC9Al44 lU7Ii7k5/5XI7b06JfgVd8mORC8mbOoI0cmIpEGzcAKaqVepUyJPbPuL6vf07/tVbIWeakfRvsdnc tRGPVAZ1wp99388IDxYbOODKfC684/ax+FJEFp5aNiU6albcLDwN/bM4uHz1/BmSNSXmVeBjb72TP wHqeY8RT/L6nQRAoPsCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2JtX-00000005ELH-1ecb; Tue, 17 Mar 2026 02:10:55 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2JtU-00000005EJx-3mx0 for linux-riscv@lists.infradead.org; Tue, 17 Mar 2026 02:10:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773713452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j4sbtWDw4DJ2JBJ+y1C7vQWjeEXxcelaEAyT7ptHthE=; b=Hb45CB/SL0/jtMS4USakBq7yu1nC/OAv1NP3OdSgP/1Lh6+YaVT/+8+9NCkbCmiIxtrZ3f /DzfQviYc7Zv2lDbKT9gPAZ3sSC/NdurDwON/JHCy1bEFrrEGUuADyadMn+Y8TgWcT3K6o X2XVb0rLkFSb1UpIVTnQMQUCneS8p8g= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-338-3Bd5hukVNg6_8EEIPcheoQ-1; Mon, 16 Mar 2026 22:10:46 -0400 X-MC-Unique: 3Bd5hukVNg6_8EEIPcheoQ-1 X-Mimecast-MFC-AGG-ID: 3Bd5hukVNg6_8EEIPcheoQ_1773713443 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AF4D218005B6; Tue, 17 Mar 2026 02:10:41 +0000 (UTC) Received: from localhost (unknown [10.72.112.155]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B823C1955F19; Tue, 17 Mar 2026 02:10:38 +0000 (UTC) Date: Tue, 17 Mar 2026 10:10:34 +0800 From: Baoquan He To: Sourabh Jain , "Christophe Leroy (CS GROUP)" Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org, andreyknvl@gmail.com, ryabinin.a.a@gmail.com, glider@google.com, dvyukov@google.com, linux-kernel@vger.kernel.org, linux-um@lists.infradead.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, x86@kernel.org, chris@zankel.net, jcmvbkbc@gmail.com, linux-s390@vger.kernel.org, hca@linux.ibm.com Subject: Re: [PATCH v5 09/15] arch/powerpc: don't initialize kasan if it's disabled Message-ID: References: <20260225081412.76502-1-bhe@redhat.com> <20260225081412.76502-10-bhe@redhat.com> <71921cca-b890-41c4-93e9-957d3f647ffa@linux.ibm.com> <0bc30137-3f1d-4a4a-8573-8f26866fcc26@kernel.org> MIME-Version: 1.0 In-Reply-To: <0bc30137-3f1d-4a4a-8573-8f26866fcc26@kernel.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-MFC-PROC-ID: 2dsbmYGvrNEazXGsVa265gj1tEpH4jb9DgVCzLFZywE_1773713443 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260316_191053_007131_F189741F X-CRM114-Status: GOOD ( 23.91 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 03/12/26 at 12:23pm, Christophe Leroy (CS GROUP) wrote: > = > = > Le 12/03/2026 =E0 12:12, Sourabh Jain a =E9crit=A0: > > = > > = > > On 25/02/26 13:44, Baoquan He wrote: > > > Here, kasan is disabled if specified 'kasan=3Doff' in kernel cmdline. > > > = > > > This includes 32bit, book3s/64 and book3e/64. > > > = > > > Signed-off-by: Baoquan He > > > Cc: linuxppc-dev@lists.ozlabs.org > > > --- > > > =A0 arch/powerpc/mm/kasan/init_32.c=A0=A0=A0=A0=A0=A0=A0 | 6 +++++- > > > =A0 arch/powerpc/mm/kasan/init_book3e_64.c | 4 ++++ > > > =A0 arch/powerpc/mm/kasan/init_book3s_64.c | 4 ++++ > > > =A0 3 files changed, 13 insertions(+), 1 deletion(-) > > > = > > > diff --git a/arch/powerpc/mm/kasan/init_32.c > > > b/arch/powerpc/mm/kasan/ init_32.c > > > index 1d083597464f..0ea2a636c992 100644 > > > --- a/arch/powerpc/mm/kasan/init_32.c > > > +++ b/arch/powerpc/mm/kasan/init_32.c > > > @@ -141,6 +141,10 @@ void __init kasan_init(void) > > > =A0=A0=A0=A0=A0 u64 i; > > > =A0=A0=A0=A0=A0 int ret; > > > +=A0=A0=A0 /* If KASAN is disabled via command line, don't initialize= it. */ > > > +=A0=A0=A0 if (kasan_arg_disabled) > > > +=A0=A0=A0=A0=A0=A0=A0 return; > > > + > > > =A0=A0=A0=A0=A0 for_each_mem_range(i, &base, &end) { > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 phys_addr_t top =3D min(end, total_lowmem= ); > > > @@ -170,7 +174,7 @@ void __init kasan_init(void) > > > =A0 void __init kasan_late_init(void) > > > =A0 { > > > -=A0=A0=A0 if (IS_ENABLED(CONFIG_KASAN_VMALLOC)) > > > +=A0=A0=A0 if (IS_ENABLED(CONFIG_KASAN_VMALLOC) && kasan_enabled()) > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 kasan_unmap_early_shadow_vmalloc(); > > > =A0 } > > > diff --git a/arch/powerpc/mm/kasan/init_book3e_64.c > > > b/arch/powerpc/mm/ kasan/init_book3e_64.c > > > index 0d3a73d6d4b0..fbe4c9a7e460 100644 > > > --- a/arch/powerpc/mm/kasan/init_book3e_64.c > > > +++ b/arch/powerpc/mm/kasan/init_book3e_64.c > > > @@ -111,6 +111,10 @@ void __init kasan_init(void) > > > =A0=A0=A0=A0=A0 u64 i; > > > =A0=A0=A0=A0=A0 pte_t zero_pte =3D pfn_pte(virt_to_pfn(kasan_early_sh= adow_page), > > > PAGE_KERNEL_RO); > > > +=A0=A0=A0 /* If KASAN is disabled via command line, don't initialize= it. */ > > > +=A0=A0=A0 if (kasan_arg_disabled) > > > +=A0=A0=A0=A0=A0=A0=A0 return; > > > + > > > =A0=A0=A0=A0=A0 for_each_mem_range(i, &start, &end) > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 kasan_init_phys_region(phys_to_virt(start= ), phys_to_virt(end)); > > > diff --git a/arch/powerpc/mm/kasan/init_book3s_64.c > > > b/arch/powerpc/mm/ kasan/init_book3s_64.c > > > index dcafa641804c..f7906f9ef9be 100644 > > > --- a/arch/powerpc/mm/kasan/init_book3s_64.c > > > +++ b/arch/powerpc/mm/kasan/init_book3s_64.c > > > @@ -54,6 +54,10 @@ void __init kasan_init(void) > > > =A0=A0=A0=A0=A0 u64 i; > > > =A0=A0=A0=A0=A0 pte_t zero_pte =3D pfn_pte(virt_to_pfn(kasan_early_sh= adow_page), > > > PAGE_KERNEL); > > > +=A0=A0=A0 /* If KASAN is disabled via command line, don't initialize= it. */ > > > +=A0=A0=A0 if (kasan_arg_disabled) > > > +=A0=A0=A0=A0=A0=A0=A0 return; > > > + > > > =A0=A0=A0=A0=A0 if (!early_radix_enabled()) { > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 pr_warn("KASAN not enabled as it requires= radix!"); > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0 return; > > = > > Should we log in the kernel log buffer that KASAN is disabled? > > = > > Right now, I don't see the kernel advertising the same. > = > When KASAN is enabled it is advertised with: > = > pr_info("KernelAddressSanitizer initialized (generic)\n"); > = > Isn't the absence of that message enough to understand KASAN is not there= ? Right, that's the way I took when I tested it. > = > > = > > $ dmesg | grep -i kasan > > [=A0 =A0 0.000000] Kernel command line: BOOT_IMAGE=3D(ieee1275//vdevice= /v- > > scsi@30000070/disk@8100000000000000,msdos2)/vmlinuz-7.0.0-rc3+ > > crashkernel=3D2G kasan=3Doff > > = > > Tested this series on powerpc Pseries platform. > > So feel free to add: > > Tested-by: Sourabh Jain Thanks for testing. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv