Re: [GIT PULL 2/5] dt-bindings: power: Add power-domain header for JH7110

Changhuang Liang
2023-09-27T01:31:48Z

>>> #ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__
>>> @@ -14,4 +14,7 @@
>>> #define JH7110_PD_ISP 5
>>> #define JH7110_PD_VENC 6
>>>
>>> +#define JH7110_PD_DPHY_TX 0
>>> +#define JH7110_PD_DPHY_RX 1
>>
>> These values are conflicting with similarly-named values above:
>>
>> #define JH7110_PD_SYSTOP 0
>> #define JH7110_PD_CPU 1
>>
>> Upon closer look, and diving into the driver, this header file contains
>> definitions for two separate number spaces: the first set is meant
>> to be used in PM Domain specifiers referring to a node compatible
>> with "starfive,jh7110-pmu", while the second set is meant to be
>> used in PM Domain specifiers referring to a node compatible with
>> "starfive,jh7110-aon-syscon".
>
> Yeah, apologies for the confusion there. I maybe should have
> requested an additional file, since the relevant compatibles
> are different.
>
>> I think it would be nice to have this reflected in the names of
>> the defines (e.g. JH7110_PD_AON_DPHY_TX), and/or to add comments
>> clearly delimiting the two separate number spaces, and explaining
>> where they apply to.
>
> Since this is 6.7 material, there's still plenty of time remaining to
> make either of these changes. Changhuang Liang, do you think you would
> be able to send a patch implementing either of the suggestions made by
> Geert?
>

Hi Conor,

I will send a patch to fix this confusion.

Thanks,
Changhuang