public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org
Subject: [bug report] drm/bridge: add a driver for T-Head TH1520 HDMI controller
Date: Fri, 10 Apr 2026 13:11:59 +0300	[thread overview]
Message-ID: <adjM7-DcN_6KvbE7@stanley.mountain> (raw)

Hello Icenowy Zheng,

Commit 96f30ee0fb9d ("drm/bridge: add a driver for T-Head TH1520 HDMI
controller") from Jan 29, 2026 (linux-next), leads to the following
Smatch static checker warning:

	drivers/gpu/drm/bridge/th1520-dw-hdmi.c:139 th1520_dw_hdmi_probe()
	warn: 'hdmi' isn't an ERR_PTR

drivers/gpu/drm/bridge/th1520-dw-hdmi.c
    133         plat_data->output_port = 1;
    134         plat_data->mode_valid = th1520_hdmi_mode_valid;
    135         plat_data->configure_phy = th1520_hdmi_phy_configure;
    136         plat_data->priv_data = hdmi;
    137 
    138         hdmi->dw_hdmi = dw_hdmi_probe(pdev, plat_data);
--> 139         if (IS_ERR(hdmi))
    140                 return PTR_ERR(hdmi);

s/hdmi/hdmi->dw_hdmi/

    141 
    142         platform_set_drvdata(pdev, hdmi);
    143 
    144         return 0;
    145 }

This email is a free service from the Smatch-CI project [smatch.sf.net].

regards,
dan carpenter

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

             reply	other threads:[~2026-04-10 10:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 10:11 Dan Carpenter [this message]
2026-04-10 10:15 ` [bug report] drm/bridge: add a driver for T-Head TH1520 HDMI controller Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adjM7-DcN_6KvbE7@stanley.mountain \
    --to=error27@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=uwu@icenowy.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox