From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Xingyu Wu <xingyu.wu@starfivetech.com>
Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh+dt@kernel.org>, Conor Dooley <conor@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Hal Feng <hal.feng@starfivetech.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 01/11] dt-bindings: clock: Add StarFive JH7110 System-Top-Group clock and reset generator
Date: Tue, 21 Feb 2023 14:37:59 +0100 [thread overview]
Message-ID: <ae468e63-d8d3-dbfb-64da-75a147e1cd2d@linaro.org> (raw)
In-Reply-To: <43d00fd9-ab24-442e-3f82-208edaf399d0@starfivetech.com>
On 21/02/2023 14:01, Xingyu Wu wrote:
> On 2023/2/21 19:25, Krzysztof Kozlowski wrote:
>> On 21/02/2023 09:33, Xingyu Wu wrote:
>>> Add bindings for the System-Top-Group clock and reset generator (STGCRG)
>>> on the JH7110 RISC-V SoC by StarFive Ltd.
>>>
>>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>>
>>
>>> + };
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 93eb504c3b21..2e70c9f21989 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -19914,6 +19914,7 @@ F: arch/riscv/boot/dts/starfive/
>>> STARFIVE JH71X0 CLOCK DRIVERS
>>> M: Emil Renner Berthing <kernel@esmil.dk>
>>> M: Hal Feng <hal.feng@starfivetech.com>
>>> +M: Xingyu Wu <xingyu.wu@starfivetech.com>
>>
>> No improvements here. You add here new bindings for one device and then
>> - without explanation - add yourself to all Starfive clock bindings.
>> Either explain it or drop it or move it to separate patch.
>>
>> You already got comment for this.
>>
>
> Sorry, I didn't understand what you meant before. Now my understanding is that,
> If I improvements JH71X0 driver no JH7110 driver, I could add this here. Right?
>
> Is it OK if I do it this way to move it to separate patch like this?:
> +STARFIVE JH7110 STG CLOCK DRIVERS
> +M: Xingyu Wu <xingyu.wu@starfivetech.com>
If you want to be the maintainer of all drivers, add separate commit for
this, so this is obvious. Or at least explain this change in commit msg.
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-02-21 13:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 8:33 [PATCH v2 00/11] Add new partial clock and reset drivers for StarFive JH7110 Xingyu Wu
2023-02-21 8:33 ` [PATCH v2 01/11] dt-bindings: clock: Add StarFive JH7110 System-Top-Group clock and reset generator Xingyu Wu
2023-02-21 11:25 ` Krzysztof Kozlowski
2023-02-21 13:01 ` Xingyu Wu
2023-02-21 13:37 ` Krzysztof Kozlowski [this message]
2023-02-22 1:48 ` Xingyu Wu
2023-03-02 15:05 ` Emil Renner Berthing
2023-03-03 3:14 ` Xingyu Wu
2023-02-21 8:33 ` [PATCH v2 02/11] reset: starfive: jh7110: Add StarFive System-Top-Group reset support Xingyu Wu
2023-02-21 8:33 ` [PATCH v2 03/11] clk: starfive: Add StarFive JH7110 System-Top-Group clock driver Xingyu Wu
2023-03-02 15:16 ` Emil Renner Berthing
2023-02-21 8:33 ` [PATCH v2 04/11] dt-bindings: clock: Add StarFive JH7110 Image-Signal-Process clock and reset generator Xingyu Wu
2023-02-21 11:26 ` Krzysztof Kozlowski
2023-02-21 8:33 ` [PATCH v2 05/11] reset: starfive: jh7110: Add StarFive Image-Signal-Process reset support Xingyu Wu
2023-02-21 8:33 ` [PATCH v2 06/11] clk: starfive: Add StarFive JH7110 Image-Signal-Process clock driver Xingyu Wu
2023-03-02 15:39 ` Emil Renner Berthing
2023-03-03 3:59 ` Xingyu Wu
2023-03-03 9:01 ` Emil Renner Berthing
2023-03-03 9:14 ` Xingyu Wu
2023-02-21 8:33 ` [PATCH v2 07/11] dt-bindings: clock: Add StarFive JH7110 Video-Output clock and reset generator Xingyu Wu
2023-02-21 11:27 ` Krzysztof Kozlowski
2023-02-21 8:33 ` [PATCH v2 08/11] reset: starfive: jh7110: Add StarFive Video-Output reset support Xingyu Wu
2023-02-21 8:33 ` [PATCH v2 09/11] clk: starfive: Add StarFive JH7110 Video-Output clock driver Xingyu Wu
2023-03-02 15:48 ` Emil Renner Berthing
2023-03-03 3:37 ` Xingyu Wu
2023-03-03 9:23 ` Emil Renner Berthing
2023-03-03 9:44 ` Xingyu Wu
2023-03-03 9:51 ` Emil Renner Berthing
2023-02-21 8:33 ` [PATCH v2 10/11] riscv: dts: starfive: jh7110: Add DVP and HDMI TX pixel external clocks Xingyu Wu
2023-02-27 19:55 ` Conor Dooley
2023-02-28 1:40 ` Xingyu Wu
2023-02-21 8:33 ` [PATCH v2 11/11] riscv: dts: starfive: jh7110: Add STGCRG/ISPCRG/VOUTCRG nodes Xingyu Wu
2023-02-27 19:53 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae468e63-d8d3-dbfb-64da-75a147e1cd2d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hal.feng@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox