From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52E54F5A8B8 for ; Mon, 20 Apr 2026 20:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=5ShCEGYy71+m+1Sb92x3YKzSs7zNKeZ/eVeMDgFYRmU=; b=rB+0zH9AKxaIRpTu5ZFQmZm+As Q8Zq8h34Px2kgqPZSGpGd0tXX3UBCCZiNxd8X+rbjH1TsoivrclelS3jOG3VYl8vZq6x8nD6jeTfD P8IuXIezNL4bP8pFekfxWAGKRNapleaDUpgkgz6Y+cv73ZTFB058ESAD+lPdZLnczIwet+mgBg5si /URY53iDVDVr57JCcvvnbXT+1o0kAhewzYDBJfKfAEDxv/QD+smFs5XmCLwfbciWzErW/p/3czFNq vei1DSDzEkfwhWzjUb3uuFfa9qfE5EU6Vp3OnOUGeyRUA2djdtXULRXhIi5HJolbesjz+WUK9C4jI /FiHyL6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEut2-00000007bmd-2aIx; Mon, 20 Apr 2026 20:06:28 +0000 Received: from mail-pj1-x1049.google.com ([2607:f8b0:4864:20::1049]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wEusz-00000007blJ-32P7 for linux-riscv@lists.infradead.org; Mon, 20 Apr 2026 20:06:27 +0000 Received: by mail-pj1-x1049.google.com with SMTP id 98e67ed59e1d1-35da97f6a6dso3338806a91.0 for ; Mon, 20 Apr 2026 13:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776715583; x=1777320383; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=TZxYUqD2nNuvPN56vUHQyfWGRkh1zwfXr7oE1wyS0SA=; b=wUloowvRrnlhU2SSlwVQyNXJtgDtcGzpq5PcWEK33lLzyX83WnEO/H/wjaWTQQMZ1e 3mI3sMenr4X9LX+niV1n/Eoeb4l3jvIlF8aAAWK0+In04b9yhpFEoKob0sn+Uf7NeXKU iaJCUNK9sx50bNpBkuGp7wdFNOPW79kqk1XtI+l4NY6+WJImBhYroUQ0w+aFzeavpZKZ 71j8kLryYvxiM9Io/paqIJX4jf00OIjTLWPpzbPw0YrsRmDw1xqmjjKza13HsfLzaCbH iVRH+IfNS8dE26cjheqIDToCGYIHqX9V/qsBfQlcN1VibssJT3jmpwssRK45pClClmii ThrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776715583; x=1777320383; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TZxYUqD2nNuvPN56vUHQyfWGRkh1zwfXr7oE1wyS0SA=; b=Go3zAwuoSgeYrJ2lu7+FKJN4wUI8WHsBoGYyBojiBF/UkBDPkow7MR3yJYH3LlEg// 26aQ5guXjOoPF3kOHko/dEGfkcdhG/hj1DIgLcKEp4AYUaJ0SjXMsHiCaUf913LojlUt 2Le/d4RFgQMpW/sKKJdpABgnCuwxZKw4mh2MqhMjGCiH4NOW+Jzs3+0Sj4zps1s3+Jmm onHQoxvZWiLf/rK/Zu09Pd8Ec5CjcRfCOu/qWnR6M+OGi6hpEbEBVnw+41lzDIB3vQOs UPoSsRbw9XkKHKScsqbcxOaCgqZ0uDrX0Fdfjcfn/AYfeiOg4Hedc0Pa0l9ULGaub3pf fp/A== X-Forwarded-Encrypted: i=1; AFNElJ/BnIko4d2bhFxFgorJlRsdsOpqsDAahQHM/xxEb7G1pEdx33pBR1E7sq5q8Ev51+OWpOwEXzDxk50C/w==@lists.infradead.org X-Gm-Message-State: AOJu0YyhD00kRu8HUlBtcn/FEH0UnCjfQKE80I5m7lE71PZiDqt6j4rs pQzIL9QApeS7ThOCttJeVlnXFT43CCmUgNXVclMHKA1Tm+dZptEO0ra+G6g4T7qi9ZCPUcGANiw BP9JMHA== X-Received: from pjbkx16.prod.google.com ([2002:a17:90b:2290:b0:35f:c299:a451]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:164a:b0:35b:96bb:47ba with SMTP id 98e67ed59e1d1-361404c0ca8mr14786253a91.26.1776715583185; Mon, 20 Apr 2026 13:06:23 -0700 (PDT) Date: Mon, 20 Apr 2026 13:06:21 -0700 In-Reply-To: <20260220004223.4168331-2-dmatlack@google.com> Mime-Version: 1.0 References: <20260220004223.4168331-1-dmatlack@google.com> <20260220004223.4168331-2-dmatlack@google.com> Message-ID: Subject: Re: [PATCH v2 01/10] KVM: selftests: Use gva_t instead of vm_vaddr_t From: Sean Christopherson To: David Matlack Cc: Paolo Bonzini , Ackerley Tng , Albert Ou , Alexandre Ghiti , Andrew Jones , Anup Patel , Atish Patra , Bibo Mao , Christian Borntraeger , Claudio Imbrenda , Colin Ian King , David Hildenbrand , Fuad Tabba , Huacai Chen , James Houghton , Janosch Frank , Joey Gouly , kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, Lisa Wang , loongarch@lists.linux.dev, Marc Zyngier , Maxim Levitsky , Nutty Liu , Oliver Upton , Palmer Dabbelt , Paul Walmsley , "Pratik R. Sampat" , Rahul Kumar , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Wu Fei , Yosry Ahmed , Zenghui Yu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260420_130625_756978_A123A40C X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Feb 20, 2026, David Matlack wrote: > Replace all occurrences of vm_vaddr_t with gva_t to align with KVM code > and with the conversion helpers (e.g. addr_gva2hva()). Also replace > vm_vaddr in function names with gva to align with the new type name. ... > @@ -716,22 +716,22 @@ void vm_mem_region_move(struct kvm_vm *vm, uint32_t slot, uint64_t new_gpa); > void vm_mem_region_delete(struct kvm_vm *vm, uint32_t slot); > struct kvm_vcpu *__vm_vcpu_add(struct kvm_vm *vm, uint32_t vcpu_id); > void vm_populate_vaddr_bitmap(struct kvm_vm *vm); > -vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min); > -vm_vaddr_t vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min); > -vm_vaddr_t __vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t vaddr_min, > - enum kvm_mem_region_type type); > -vm_vaddr_t vm_vaddr_alloc_shared(struct kvm_vm *vm, size_t sz, > - vm_vaddr_t vaddr_min, > - enum kvm_mem_region_type type); > -vm_vaddr_t vm_vaddr_alloc_pages(struct kvm_vm *vm, int nr_pages); > -vm_vaddr_t __vm_vaddr_alloc_page(struct kvm_vm *vm, > - enum kvm_mem_region_type type); > -vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm); > +gva_t gva_unused_gap(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); > +gva_t gva_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min); > +gva_t __gva_alloc(struct kvm_vm *vm, size_t sz, gva_t vaddr_min, > + enum kvm_mem_region_type type); > +gva_t gva_alloc_shared(struct kvm_vm *vm, size_t sz, > + gva_t vaddr_min, > + enum kvm_mem_region_type type); > +gva_t gva_alloc_pages(struct kvm_vm *vm, int nr_pages); > +gva_t __gva_alloc_page(struct kvm_vm *vm, > + enum kvm_mem_region_type type); > +gva_t gva_alloc_page(struct kvm_vm *vm); The existing vm_vaddr_alloc() and friends are pretty bad names. gva_alloc() is far, far worse. The APIs aren't just allocation a guest virtual address, they're allocating guest physical memory, finding a usable virtual address, and creating mappings. I don't see any reason to have vaddr or gva in the name. E.g. malloc() isn't virt_malloc(). But I do think they need to be explicitly scoped to KVM, and to a VM. I'll drop API renames from this patch, and rename them to vm_alloc() and friends in a separate patch. Amusingly, that naming scheme will still work if "vm" is misconstrued as "virtual memory" instead of "virtual machine". P.S. This is a great example of why I insist on one logical change per patch, with judicious exemptions for opportunistic cleanups/changes. If this has been a separate patch, it would have taken me all of two seconds to unwind. As it was, I spent a good 10-15 minutes dealing with this. In large part because I kept making goofs, but that's the whole point: there was no reason to put me in a position to make goofs. The other argument against these sorts of "Also do xyz" add-ons is that of a slippery slope. Why rename these APIs in this patch, but not the myriad vaddr variables? Then after a few "I'll just clean this up too" changes, there's an entire series in what is purportedly just a typedef rename. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv