From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C310CD6E4A for ; Sun, 31 May 2026 01:51:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GkO8A7aiuM8nOp4zFFuIoEfnFrh8J4oAI1FVPYYuSoQ=; b=FprVK+HhnXvoap GOhlqECMHX5HhOETF5K5RXGTeTwVrJZQ5xtYAEHNJ22DKSJQS98AArF+N7M0sSzj63i8jZurcwA0x OHujVzWJbuar1UevzA0+H+w5Yau1zbgQN8gWZggfrNWkkblGLqk2Nt+NHDPrXPOLyfLi2fIkrza/9 R0CxZf995Z1X7kSUs2WWYVKTi/ComvnDpMoBbFM1iqtwNspwFevC3sg3Vf1QrlLlBvwgyyTiIpf33 2K+qKX470khdkZ/831LoiB5OTAVb4atOaBEzNbbT5vf5eIerb2oJ/urixKrkDgDGcixG75n1xepHy J+b9xVW7L/57yx4el+Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wTVKg-00000009A8Y-1qy8; Sun, 31 May 2026 01:51:18 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wTVKd-00000009A85-36sQ for linux-riscv@lists.infradead.org; Sun, 31 May 2026 01:51:16 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 6956E408F4; Sun, 31 May 2026 01:51:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 766BE1F00893; Sun, 31 May 2026 01:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780192272; bh=1miKEZAnGiSRcJQWtswcD5dFRkY3BK0eDKYXOh7h6zk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=kLY60WfhyXnSawaNZl+ilX4Ak1L0nLfHZVo5wooZbVNLdLl6+VwBm6FBMlSa46wp2 RhTtMwa0RiiIopa/dJ6a4pY7B1OWJ6JG6HV0TQp+U2W/HKI248r6TyYHbRTreyNyVz yUz2338GeKxTE6CjYYCC6b361QBAF7FbhAnXKsfdt2WOCXOxGmOr6XE4nuBsWSm68w aiWbuaU68w9QP8FiUzIoZ1Bv2H7Ru5HQw2gQGmLT2bdMaYe7+sdfPcvgs8KQZWMZpX upA3cR23f39TzrUVNIHAGvC/dbMTqphfDDHLjSUuECnm+NaeIS8qJ8xIn5Vit4bcaE MoQcXwuCuMEJw== Date: Sat, 30 May 2026 18:51:01 -0700 From: Drew Fustini To: Sunil V L Subject: Re: [PATCH RFC v5 16/18] ACPI: RISC-V: Parse RISC-V Quality of Service Controller (RQSC) table Message-ID: References: <20260524-ssqosid-cbqri-rqsc-v7-0-v5-0-78d3a7ba9dbe@kernel.org> <20260524-ssqosid-cbqri-rqsc-v7-0-v5-16-78d3a7ba9dbe@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260530_185115_825771_8204BBB8 X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, Atish Patra , Sebastian Andrzej Siewior , Adrien Ricciardi , Atish Kumar Patra , Conor Dooley , Nicolas Pitre , linux-kernel@vger.kernel.org, Gong Shuai , Liu Zhiwei , "H. Peter Anvin" , guo.wenjia23@zte.com.cn, Krzysztof Kozlowski , Ingo Molnar , linux-riscv@lists.infradead.org, Rob Herring , linux-acpi@vger.kernel.org, Alexandre Ghiti , Jonathan Corbet , "Rafael J. Wysocki" , acpica-devel@lists.linux.dev, Robert Moore , liu.qingtao2@zte.com.cn, Dave Hansen , Ben Horgan , linux-rt-devel@lists.linux.dev, James Morse , Radim =?utf-8?B?S3LEjW3DocWZ?= , Dave Martin , Clark Williams , Len Brown , Gong Shuai , Fenghua Yu , Chen Pei , Albert Ou , Kornel =?utf-8?Q?Dul=C4=99ba?= , Steven Rostedt , Babu Moger , Weiwei Li , Borislav Petkov , yunhui cui , Paul Walmsley , Ved Shanbhogue , Reinette Chatre , Vasudevan Srinivasan , Tony Luck , Peter Newman , linux-doc@vger.kernel.org, Conor Dooley , Conor Dooley , Samuel Holland , Palmer Dabbelt , Thomas Gleixner , Paul Walmsley , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, May 25, 2026 at 01:53:09PM +0530, Sunil V L wrote: > > + if (info.mcid_count > CBQRI_MAX_MCID) { > > + pr_warn("controller at %pa: mcid_count %u exceeds CBQRI_MAX_MCID %u, skipping\n", > > + &info.addr, info.mcid_count, CBQRI_MAX_MCID); > > + continue; > > + } > > + > Do you also want to add a check for the statement in the spec "At > least one of RCID Count or MCID Count must be non-zero." ? Good idea, I'll add a skip with pr_warn when both are zero. > > +/* RQSC v0.9.2 Table 4: Resource Type values for acpi_rqsc_resource.type. */ > > +#define ACPI_RQSC_RESOURCE_TYPE_CACHE 0 > > +#define ACPI_RQSC_RESOURCE_TYPE_MEMORY 1 > > + > > +/* RQSC v0.9.2 Table 4: Resource ID Type values for .id_type. */ > > +#define ACPI_RQSC_RESOURCE_ID_TYPE_PROCESSOR_CACHE 0 > > +#define ACPI_RQSC_RESOURCE_ID_TYPE_MEMORY_RANGE 1 > > + > Memory-Side Cache, ACPI, PCI devices missing? I'll add the constants for the future. Thanks, Drew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv