Re: [PATCH v2 4/5] riscv: dts: thead: Add IO labels for the IO expansion on I2C1

From: Drew Fustini <fustini@kernel.org>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: Icenowy Zheng <zhengxingda@iscas.ac.cn>,
	Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, MoeLeak <i@leak.moe>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>
Subject: Re: [PATCH v2 4/5] riscv: dts: thead: Add IO labels for the IO expansion on I2C1
Date: Mon, 20 Jul 2026 09:56:58 -0700	[thread overview]
Message-ID: <al5TWhx7pLIZguAc@gen8> (raw)
In-Reply-To: <1E3154C2-B5BE-46FD-BBFC-87E56FAE3AFE@icenowy.me>

On Fri, Jul 17, 2026 at 12:11:23PM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2026年7月17日 GMT+08:00 04:52:19，Drew Fustini <fustini@kernel.org> 写道：
> >On Tue, Jul 14, 2026 at 03:45:14PM +0800, Icenowy Zheng wrote:
> >> From: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> >> 
> >> Add labels for GPIOs on the IO expansion chip on the I2C1 bus.
> >> 
> >> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> >> [Icenowy: Splitted off the patch adding all 3 IO expansions]
> >> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
> >> ---
> >>  arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts | 8 ++++++++
> >>  1 file changed, 8 insertions(+)
> >> 
> >> diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> >> index 74b120c6b063a..78f5979a56c14 100644
> >> --- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> >> +++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> >> @@ -128,6 +128,14 @@ ioexp2: gpio@18 {
> >>  		reg = <0x18>;
> >>  		gpio-controller;
> >>  		#gpio-cells = <2>;
> >> +		gpio-line-names = "",
> >> +				  "cam0_reset",
> >> +				  "cam1_reset",
> >> +				  "cam2_reset",
> >> +				  "wl_host_wake",
> >
> >I am not sure the line name really matters all that, but it seems that
> >pin 4 is also used as a reset gpio:
> 
> The "host" here is subject, which means "this pins is used by the host to wake the wl".
> 
> Maybe I should take the schematics name, "wl_host_wake_dev"? Or use another name on the page for Wi-Fi, "wl_reg_on"?

I thnk "wl_host_wake_dev" is slightly better in terms of searching the
PDF [1] and finding the "IO Expansion 2" section. This is minor change
so I can just fix up when applying if you are okay with that.

Thanks,
Drew

[1] https://dl.sipeed.com/shareURL/LICHEE/licheepi4a/02_Schematic

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv