From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93C13C4451C for ; Sat, 18 Jul 2026 09:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1YlGHjaPgS4lQrg0GIqVtJIOM/wdXC/y8+FcfacHfQs=; b=hiw9JQtRrYxhvh +hlm7Raz6gHrOTyDbAW2G7VXpx3qZ2BAWdHV4JYVWmde2ux8cJwpEzt8aJXnBNL+88WAZPSUwZxRy y3dvmNv8Wrl96tRoYPBW1sRxpNkhxklwr6YNSfZBfNWOfIyrsaKu/K+4/nrEGlWCPH6lNwATkT2Ol Z/HJYfYN4HZu7wywNcmhPzKvMTdH7usQ/oHc6WDlkh0WkCL5j++4xfQvbyFFshy8olo77cLUQrQEu 6IfTcr5dZwk32HcMccs3r2fDEwZk/x1veyCi4c8L2Z9KsFLKpbnZrLQ0NIzBa3/XQIsedRI62GQ8i rLOCcVtLqtEaFckLSAOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wl122-00000003vsc-31We; Sat, 18 Jul 2026 09:08:26 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wl11z-00000003vrs-2OhX for linux-riscv@lists.infradead.org; Sat, 18 Jul 2026 09:08:25 +0000 Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfhigh.phl.internal (Postfix) with ESMTP id 1FB9814000DD; Sat, 18 Jul 2026 05:08:20 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Sat, 18 Jul 2026 05:08:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rembrandt.dev; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1784365700; x= 1784452100; bh=P940IKil3KNOg79W+B7JzGaqUQgGye5SZmAiJUN64ok=; b=W Q1f7ceT6jaXflfHiJXwp45MXVXt3Iaj/TKOHZApzKKKMz7rh9feWEssWdB6keQRc nYA5wpGbsGWgZB5clGG612mfZVPASFVVPIdCafYfFtI91rzp64MZrX6fCrhJn1XZ xIogyW/ieUzpiE3NayLOozub9jemWiBxwXF1yWBRFKKJja0R8SpQc2Lkmpayj/4l 85u/xnkaJ8O3id6hwsXaUFE6kCFP0Cay4+i8Ls7HQLhLxzpXwS8ZpenBCP/paVfZ ZrBV6xVgUxvzOVEw2jjZa9qNIxciY4EHPzlB9zDx2H9pXl4Qq44YgDDiaLzdn+1F +cUmVG4Ql0Eb4yhRvXVcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1784365700; x=1784452100; bh=P940IKil3KNOg79W+B7JzGaqUQgGye5SZmA iJUN64ok=; b=azBElWfG5/Hjbs06IY8t+VEmGwr+DfvnIt5r2+LsNrwLjRZ+GCH DPQWvzz2oI/4QlqYdxFLdnjp3ZnJa7Ei/kMq2b+I/ne3tJ3OQ/Dgo04bJjdy2JtX RiG7PaIi4yJK8NkBMZtxUrRTMKHlGCMNJANc8Oe2Abm7ndaeQsqh9sBuaMOJWed3 Noq4B2exiXB8fvxaXKAJ0BNBuZkxOJivkGefIaOkrm4zNfUq/6cfSzqMuxlnitaf 2IpeODcDjomVHaBsAQS+KWXtlryBJcqe6QrIJFFwNlwW1GTbjKAmHSYRKnRmCWu6 4vg6iPqM6Hdo+zIaKYI4hyVAhJ2Ar5N3AVQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGvs6vg5bE9KEwkUoXOCAsx94wlDVx5fS+eeKRsAnDA3OiT9zI4z7yuoEIULyFdG+ zZ5fAbRrnMzL/9vbBZUilAyxABUVj+ar0DtN6R0fJ1Jx6i8162iqn3X7KE/92uaZr0/WwI 7muFHLBWdKvHJ9gStLs8xxDUqJ5KzYgsoagQ5SmRXm2KG2KhhNBuQ3P9gK7cAGms1jIqKj Xv7uvJrjn/PvtTgQ1lbAVkHyH48i6itw9fmI+wGgCfNn52crlPsfEbdsNA/em0OlqBzxJR szTlg2Bhq+R1Id3kWBukBUyPlIym1Usty297/fUeynfSgBftMO4gZa3Y1YBSQcq5u/EZOf erC+91nY9ktXN1UYYRKZATTbgEoTumaoYc2ScJLWbGgJQmaAub8ha3V9TtsOexPJACFx1Z UPZ3kjuKtSaRkA+Ao71kMMebBqFkZe/GnwWzcKCI+ftieDB7SBMKOuBkCmOuMz38w5FAXy uWa8BNtuBrzvPUHecne9JEnlXW1HqPb/uyhYS/G0oKYzN3DxmCpNhmVKtCCod1jnAs0KNW BeBvQnfvFkBlpX6Ry84GbSCX0UAqbS+oQML60SBGomJZuHP9iZvfK2XQOygGDWE8MuopTO wyjAXYdLo8S+TOLQbxnnS8jPqaOylnCO4Nlp3oed0pGF3Ibq0nK/clwqbfQA X-ME-Proxy: Feedback-ID: iec564b6b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Jul 2026 05:08:17 -0400 (EDT) Date: Sat, 18 Jul 2026 11:07:16 +0200 From: Andrew Rembrandt To: E Shattow Cc: Yixun Lan , Inochi Amaoto , linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: dts: spacemit: k3-pico-itx: Fix non-functional ethernet TX timing Message-ID: References: <20260608182358.170489-1-kernel@rembrandt.dev> <77a48b81-7906-4e18-9229-48643a67f402@freeshell.de> <20260710022551-GKA106000@kernel.org> <738ce6b8-798b-4689-a0f5-791fe85addbc@freeshell.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <738ce6b8-798b-4689-a0f5-791fe85addbc@freeshell.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260718_020824_147356_1FEE942D X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi E, Yixun, On Fri, Jul 10, 2026 at 07:34:34 am E Shattow wrote: > On the topic of this ethernet TX timing thread I don't know what > this does? Is there a test situation I may try to know if it is doing > anything? Thanks very much, -E Apologies for the slow reply -- I've been swamped the past month. Thank you for taking the time to test this; your results are what prompted me to go back and re-test properly, and it turns out my original premise was wrong. The non-functional TX I originally saw was not fixed by this delay property at all. An unrelated commit that landed between v7.1-rc1 and v7.1-rc7 is what actually fixed the dead TX on my board. While developing this patch I'd inadvertently picked up that change, and I wrongly concluded the tx-internal-delay-ps addition was what got traffic flowing. To confirm, I re-ran a series of iperf3 tests without the delay patch and saw no transmission problem whatsoever -- a full 1Gb/s in both directions with no errors. So this matches exactly what you and perhaps Yixun also observed: on a current base the property makes no measurable difference, because the TX path already works without it. Given that, the patch isn't the fix as described in the changelog, and the property has no functional effect on this board. Yixun -- since you've already applied it, could you drop it from your tree? A revert is fine too if it's landed somewhere non-rewindable, but I don't think it should go upstream as-is: the "Fixes:" tag and the "no ethernet traffic passes" rationale are both wrong. Sorry for the hassle, and thanks for queuing it in good faith. Sorry again for the noise, and thanks E for the careful testing that caught this. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv