From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61713C56207 for ; Thu, 6 Aug 2026 14:51:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N//FtuWylSaIRI+FQ53yMrYM+SL+QxwNAWHdZQirQX0=; b=uV+i8Wtxr/Ovk6 JBiexQQoEGKI4dG3wugPM08CAzJr0JFKwXNuZrVzGP6ROBAY2FGWoWWpAkFQu2Jt0cBphO/F3J3Vv S/xnC+Te2sSVY3WF6qGW1vlPmIvPLf9Q6Lm+/NuqKotHErYNPwy9L5FwcnDXQKmVusPPl8dCVBVxD kS54Z151bU3HRw4lzOUrI9rWgYeJMlZ9ZqhtNP6A/reJfq7DCqnDEamKHsnpk1FMVc2RDRo1wpOqd dcptzgi9lDP2mwjkjTg8BBEtBMaMEFETPCTCpNuoG22RAfCCWQ6+HB3cOiK2POAVtNsIEid4yhYuG GwtsjI66GDGXBrIIgevA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrzRY-0000000627d-2oWw; Thu, 06 Aug 2026 14:51:36 +0000 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrzRW-00000006273-19hD for linux-riscv@lists.infradead.org; Thu, 06 Aug 2026 14:51:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=pPGzVx4G8LgdTlTv/38zHzZ7a/0MlpsoUhuTgEmW0mg=; b=vChC1Qx3zD1SwVeyMLXj3b+S5k Cdp9Tvj39YQvk+8zDhirk7TWV9D9T9r8H9eXfqe0iCPPAXCNe7bdjO01wc1JcwRe8CvEpEdVWub8z ozsQFUGM0QWudAONkt+k9nLAI130zyEHGvdhFol3c+gOSC0V0L2rHncmCejQTUzeXIOVt+MEYHqiy e7gLCSlnRJB0druBTAQE36yvuCISqkIMygDriiaUV2kknYvPFb3A2qAxrrxBC+4k6AxP3R27dtnJf 8WuPEwdT8DCeBIZB6l2g182RM7aVAZmAOQPC6M3GNxS+elQSNNrfylg5FKGIOkXksfTaGd80hB6+B aK7QQMUA==; Received: from authenticated user by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wrzR2-0000000Deyk-1X5z; Thu, 06 Aug 2026 16:51:04 +0200 Date: Thu, 6 Aug 2026 16:51:03 +0200 From: Aurelien Jarno To: Yixun Lan Cc: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Anirudh Srinivasan , Jennifer Berringer , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] Add UFS Host driver support for SpacemiT K3 SoC Message-ID: Mail-Followup-To: Yixun Lan , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Anirudh Srinivasan , Jennifer Berringer , linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260806-08-k3-ufs-support-v3-0-037fb322acdb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260806-08-k3-ufs-support-v3-0-037fb322acdb@kernel.org> User-Agent: Mutt/2.4.1 (2026-07-04) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260806_075134_319845_D75E3630 X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2026-08-06 02:56, Yixun Lan wrote: > This series try to add UFS support for SpacemiT K3 SoC, the controller > components consists of System Bus Interface Unit, UFS Host Controller > Interface, UFS Transport Protocol Layer, UFS Host Registers, Device > Management Entity (DME), Transport Layer, Network Layer, Data Link > Layer, PHY Adapter Layer, and M-PHY Interface. A more detail functional > block diagram can be found in SpacemiT website, chapter 9.7.3 [1] > > Please note, in order to test this driver, the UFS clock driver[2] here > should be applied first as a prerequisite patch. > > One known issue is that the device will occasionally raise BKOPS interrupt > when doing some high load test, log from dmesg shows > > [ 806.710763] ufshcd-spacemit c0e00000.ufshc: ufshcd_bkops_exception_event_handler: device raised urgent BKOPS exception for bkops status 1 > > Link: https://spacemit.com/community/document/info?nodepath=hardware/key_stone/k3/k3_docs/k3_usermanual/09_memory_storage.md&lang=en [1] > Link: https://lore.kernel.org/all/20260630-06-clk-ufs-support-v1-0-cf7521d1d0fe@kernel.org/ [2] > Signed-off-by: Yixun Lan > --- > Changes in v3: > - fix dt-binding warning reported-by sashiko > - fix low freq in opp-2 table > - fix err checking in check_hibern8() > - propagate err code in link_startup_notify() > - update documents for event_notify() > - Link to v2: https://patch.msgid.link/20260725-08-k3-ufs-support-v2-0-45036a2a2418@kernel.org > > Changes in v2: > - fix missing interrupts property > - move ufs node to k3-com260.dtsi > - convert freq-table-hz to operating-points-v2 > - rework reset_control, fix header and drop global variable > - drop dump_host_regs() debug interface > - converge and refactor dme_set() operations > - massive reduce of busy delay() loops > - drop vendor specific hce_enable_notify(), fallback to default > - drop unused member from struct ufs_spacemit_host > - add COMPILE_TEST support to Kconfig > - comment style fix > - Link to v1: https://patch.msgid.link/20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@kernel.org > > --- > Yixun Lan (3): > scsi: ufs: spacemit: dt-bindings: Add UFS controller for K3 SoC > scsi: ufs: spacemit: k3: Add UFS Host Controller driver > riscv: dts: spacemit: k3: Add UFS support > > .../devicetree/bindings/ufs/spacemit,k3-ufshc.yaml | 56 ++ > arch/riscv/boot/dts/spacemit/k3-com260.dtsi | 4 + > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 4 + > arch/riscv/boot/dts/spacemit/k3.dtsi | 22 + > drivers/ufs/host/Kconfig | 12 + > drivers/ufs/host/Makefile | 1 + > drivers/ufs/host/ufs-spacemit.c | 687 +++++++++++++++++++++ > drivers/ufs/host/ufs-spacemit.h | 79 +++ > 8 files changed, 865 insertions(+) > --- > base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 > change-id: 20260605-08-k3-ufs-support-c8b308e415e2 > Thanks for this new version, and no worries about not adding the previous Tested-by tags. I have also tested this version, so patches 2 and 3 are: Tested-by: Aurelien Jarno Regards Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://aurel32.net _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv