From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52A26C5B572 for ; Wed, 19 Aug 2026 07:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iLF+TJy2BytKp17FXcYCdLp0hfSn2dOXVG4Dvk/7NKE=; b=GGXTp8lPMJ7Bz+ FAVB//JufFkInk0oW2H1Q6Tp2gMFeWb7ovqCqMLMn6oZKuubmo7XLaN0luuei9vm2pTNop58Si2Sw z5mBnz12f7gUVX3QPKAuMcdiFW6cqguhqwYHXxNQAa5eRC/S5oOgDmTvu+sYJ7oUj/M7r4gQN1Rxu l6H6y869y6/r52yj0RcM2+70vnphqsSqCSyOr8vcyGiSGTADuvWnfpsLvnusJwhcwcQO+tn3dKJ8Y DUGMvNOkfqQZKHRst5ZGg7iOhXl4CAPiEJk8XeUsYy4fq69ll3YafWjvKaagrdlYhb80v/xWnHuVp ImTKe2XwC9pCVF7ffoFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwaIv-000000099GP-3xlk; Wed, 19 Aug 2026 07:01:41 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wwaIv-000000099Fv-122i; Wed, 19 Aug 2026 07:01:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id E558B40E0B; Wed, 19 Aug 2026 07:01:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0E0F1F000E9; Wed, 19 Aug 2026 07:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787122900; bh=aMKxJGzD04KmpYdtuo6wR1wjBXa3j2PKTFpPFdjXzYU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=W218OjmEyHpxk8/viVdeC99qw0slMQEIeb88kkfoCArZxB5b+ptrrTJCAevq6VxDC vMLWsCTCZofQBaxR8oOPqWS3kHD49USp31sbZl8DRPCFt4KACVCCQrNyM/PgNyaQHR VkV0HOObXqdXGCJvNJhTxaqj9fmO35W5uT1jdRtJNLUOb/HjegZxblTMNGIV/GVRRM flhucOwsPBVMpfnwxRKIG1ToXGaPjBMWqxwbx+olsHHxa7QcV4g0KWxIkN0N9mv8Xz L8AUvX3FOqiw4smqbYXS27a0Eeumx4rnsMmynElmR0J9GQkX0rxY+csbE6hJYTSs4X O/LT5KmkF12xg== Date: Wed, 19 Aug 2026 10:01:25 +0300 From: Mike Rapoport To: Brendan Jackman Cc: Andrew Morton , Adrian =?utf-8?Q?Barna=C5=9B?= , Albert Ou , Alexander Gordeev , Alexandre Ghiti , Andy Lutomirski , Borislav Petkov , Catalin Marinas , Christian Borntraeger , Dave Hansen , David Hildenbrand , Gerald Schaefer , Heiko Carstens , Huacai Chen , Ingo Molnar , Len Brown , Palmer Dabbelt , Paul Walmsley , Pavel Machek , Peter Zijlstra , "H. Peter Anvin" , "Rafael J. Wysocki" , Ryan Roberts , Sven Schnelle , Thomas Gleixner , Uladzislau Rezki , Vasily Gorbik , WANG Xuerui , Will Deacon , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, loongarch@lists.linux.dev Subject: Re: [PATCH 4/6] mm/vmalloc: make set_area_direct_map HUGE_VMAP friendly Message-ID: References: <20260816-execmem-set-vm-perms-v0-2-v1-0-90944a3ad43f@kernel.org> <20260816-execmem-set-vm-perms-v0-2-v1-4-90944a3ad43f@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Aug 17, 2026 at 02:21:41PM +0200, Brendan Jackman wrote: > On Sun Aug 16, 2026 at 12:59 PM CEST, Mike Rapoport (Microsoft) wrote: > > set_area_direct_map() always updates direct map alias permissions in > > single page increments. > > > > For HUGE_VMAP areas it's suboptimal. Not only the loop in > > set_area_direct_map() needlessly has more iterations (e.g times 512 on > > x86), but it also causes fragmentation of the direct map that could be > > avoided for the HUGE_VMAP areas populated with large pages. > > > > All pages in an area are always of the same order: either same-order > > large pages when VM_ALLOW_HUGE_VMAP is set and all huge pages were > > successfully allocated, or order-0 page when VM_ALLOW_HUGE_VMAP is > > cleared or when huge pages allocation fails and fallback path is taken. > > > > Instead of updating the direct map permissions for every order-0 page in > > an area, use the area's page_order as the loop increment and update the > > large pages in one call to set_direct_map_{invalid,default}_noflush(). > > > > Signed-off-by: Mike Rapoport (Microsoft) > > --- > > mm/vmalloc.c | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index fc7993db4152..11170d1ee5be 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3361,12 +3361,15 @@ static inline void set_area_direct_map(const struct vm_struct *area, > > int (*set_direct_map)(struct page *page, > > unsigned int nr)) > > { > > - unsigned long i; > > + unsigned int nr = (1U << vm_area_page_order(area)); > > + > > + for (unsigned long i = 0; i < area->nr_pages; i += nr) { > > + if (page_address(area->pages[i])) { > > + int err = set_direct_map(area->pages[i], nr); > > > > - /* HUGE_VMALLOC passes small pages to set_direct_map */ > > - for (i = 0; i < area->nr_pages; i++) > > - if (page_address(area->pages[i])) > > - set_direct_map(area->pages[i], 1); > > + WARN_ON_ONCE(err); > > Nit: Maybe worth a comment on why this is expected to always succeed? > I.e. I think we are assuming the only failure mode is allocation but > because we know vm_area_page_order() there shouldn't be any allocation? The assumption we relying on is more involved, but yeah, I can add a comment. -- Sincerely yours, Mike. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv