From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 628C9C5DF8C for ; Sat, 22 Aug 2026 13:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xLAxdm92CnpOW+hnSuxfBvv5MoHpqSyNZyEN+gi/Ac8=; b=1sztf/FNIoaFck g+z4Msd61pqXm6daTug29Ivuk5uIYsYvjzkqP9p6KWjjXDGBheND/wEB+vypQOuVjFpqJ+2dR+K7k 6yclWonSsrbAcgV2KTAYs5BfxXMbbv+9Zw3TuKj4kwMwRdCRak/rptMUb+0ruA2sFDRoPx8hqnb/o XBAThhdz0CiXBEHRSgGOf89PS8lO0FDSSfqZjNAUeQ0QuEwscGiXXAT42QbJPGP/upN+G7R2fYMWo C0tDqchtba7EDPZ42ONJgBsK5g9SpPBmyUCjF4VQAyA/gxKH5hL8cvoa34DIf2lItpocWUpxX/F35 tCls9gvxbjYjK2j7M4bQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxlv2-0000000EXqr-32is; Sat, 22 Aug 2026 13:37:56 +0000 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wxlv0-0000000EXqU-0B07 for linux-riscv@lists.infradead.org; Sat, 22 Aug 2026 13:37:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=zDBgsV3+jDmiqlzEZNoPIOW8mF2ckwIKQWsrUdzM27s=; b=GwWRbV3p3phXULnOIKKsbeIyxS a/iq7+zFdy9cVFu/p5GT0uvFZcKL/jOrlXlWyZO/pKcyELSZ+EyqiT/hLnNjiJVPc7+gLn07NHLrY k+U1K7ZIalmwwMd8oFtHZAcfV30WWqqP/GxA8vm86RCRSvnLfqGO0P8YMGbyLFsPy2W0IUXUhfRrx /rpYcsaaPRMO6rKxggF8NWaHgPla149UaPEa8pQJMsVFrXbe8asH8i2bzd8VNdDBWMsOAC8BVntZ1 1T+z26BdC9S0L1tkDnBnT/PRfDE4jaEi2cVRPoDTQxOeOGDjVPnLtKcFONUL/whLvqaRjpNvNrHUy us1Wi0fg==; Received: from authenticated user by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wxluw-0000000GuRp-1pH4; Sat, 22 Aug 2026 15:37:50 +0200 Date: Sat, 22 Aug 2026 15:37:49 +0200 From: Aurelien Jarno To: Inochi Amaoto Cc: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" Subject: Re: [PATCH v3 1/5] riscv: dts: spacemit: k3: move USB3 phy to board level Message-ID: Mail-Followup-To: Inochi Amaoto , linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" References: <20260819162115.2252812-1-aurelien@aurel32.net> <20260819162115.2252812-2-aurelien@aurel32.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.4.1 (2026-07-04) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260822_063754_112382_731AB61E X-CRM114-Status: GOOD ( 30.32 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2026-08-22 20:33, Inochi Amaoto wrote: > On Sat, Aug 22, 2026 at 11:37:44AM +0200, Aurelien Jarno wrote: > > On 2026-08-22 10:17, Inochi Amaoto wrote: > > > On Wed, Aug 19, 2026 at 06:15:42PM +0200, Aurelien Jarno wrote: > > > > On the SpacemiT K3 SoC, the combo phy provides 8 lines that can > > > > either be used for PCIe or USB3, depending on its configuration > > > > (spacemit,apmu). This configuration is defined at the board level, and > > > > assigning a phy line to a USB3 controller while it is configured as PCIe > > > > results in an "Invalid PHY mode" error. > > > > > > > > Move the USB3 phy at the board level, the as it is done for the > > > > submitted PCIe controller [1]. Keep the USB2 phy at the SoC level as > > > > there is one phy per USB controller. > > > > > > > > [1] https://lore.kernel.org/20260727094726.890179-3-inochiama@gmail.com/ > > > > > > > > Fixes: 46380e4b1534c1626cecd7f4d0abb5e0cce09af6 ("riscv: dts: spacemit: k3: add USB controller and USB phy support") > > > > Cc: Inochi Amaoto > > > > Signed-off-by: Aurelien Jarno > > > > --- > > > > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 3 +++ > > > > arch/riscv/boot/dts/spacemit/k3.dtsi | 5 ++--- > > > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > > > index b084a35aa00e..171bd2f40aa6 100644 > > > > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > > > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts > > > > @@ -328,5 +328,8 @@ &usb3d_u2phy { > > > > }; > > > > > > > > &usb3d { > > > > + phys = <&usb3d_u2phy>, > > > > + <&combophy 4 PHY_TYPE_USB3>; > > > > + phy-names = "usb2-phy", "usb3-phy"; > > > > status = "okay"; > > > > }; > > > > diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi > > > > index c3f2dce0969c..3e24054d2084 100644 > > > > --- a/arch/riscv/boot/dts/spacemit/k3.dtsi > > > > +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi > > > > @@ -452,9 +452,8 @@ usb3d: usb@81a00000 { > > > > <&syscon_apmu RESET_APMU_USB3_D_VCC>, > > > > <&syscon_apmu RESET_APMU_USB3_D_PHY>; > > > > reset-names = "ahb", "vcc", "phy"; > > > > > > > - phys = <&usb3d_u2phy>, > > > > - <&combophy 4 PHY_TYPE_USB3>; > > > > - phy-names = "usb2-phy", "usb3-phy"; > > > > + phys = <&usb3d_u2phy>; > > > > + phy-names = "usb2-phy"; > > > > > > I suggest removing this completely as we can not determine the > > > phy we used. I think it is suitable for setting this in board > > > file only > > > > Yes, moving all the phy definition to the board level is an option. I > > decided to keep the USB2 phy at the SoC level, because contrary to the > > USB3 phys, there is a one to one mapping between the controller and the > > phy. Do you think it is a wrong assumption? > > > > By default, I prefer to make the forgotten thing as an error in > validation for any flexible field. If you leave the default value, > the forgotten field will lead to a downgrade hardware (or maybe > broken hardware). So I prefer to remove this rather than give a > default value. Ok, thanks for the feedback, i'll fix that in the v4. Regards Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://aurel32.net _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv