From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D215C79F9F for ; Thu, 10 Sep 2026 11:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D/TLHe6kOzYsvLrsAjV9ppNBa76FrO44MyueCkeV/U8=; b=Pd9MYYaUSb/+j+ riGn2HGarZ6vIJE9hqthI2HwYUHPlfqdR5M24bg1askw0ndgS3qKgbiWH+3ivTWfXqIAXMIMwDoUI mA0HAsmTlBDM+Oggodb0K8NUVhOiTiFgW80eold0Ja/J2zvssS/3SwuvXrsAtra8MSyjtLcc5ytGX CkNhuUW5UnyN0Ajg/1PqGWpCv1hluYBT1d5DB0BlzcA+k0W/iyiMcHfcuuuNAw19ceMI20ytFTVPh OzQ+0GPdXPqzGjFE/EXGEqEgPOx8+3w5bofYcDNy2BX4LdasQyUoHTyT1ONs+OmPyvR9oS2PjQblk qzxs83McnBOH888dqG6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4cWj-0000000E8XQ-21Nm; Thu, 10 Sep 2026 11:01:09 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4cWh-0000000E8Wq-3ka2; Thu, 10 Sep 2026 11:01:08 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 17EB2600CB; Thu, 10 Sep 2026 11:01:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02A131F000FF; Thu, 10 Sep 2026 11:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789038066; bh=Ysr1aeZRruTO/kwpd2zBCB/fNXGYRvMbwiFBQZsaXX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=GjHfMNbgWtZXVVvy4yrx1x7YF9AP8Mkzu4MlbWX7VmxRm6mAWLc8LgSERp1bsM8Km CnvTgQrePYoKl4p0NLebsW2NiVhAdO2zkErs2FPVzEm81ikhbTZNMlrI9O78VSSEY5 GB/+eamdB4pr4CorF7GtvDp7uxnZ1C2g/ftMtcUejQ1eyZZ62naguabdSTu+5r3f5G HI55m9alQspSOEkxuPadAmKxLi7xNxDtZHogQEam3ZPw2SU0occeQ7t9wplr8R9SkV 99O4PaCwWfiABccklZHYAViUdHa6Mu8mwlM3lO8H9TioVDN1ifQAh6OHZg3NZhRsLV f9GUdaQ6/6IpA== Date: Thu, 10 Sep 2026 12:00:52 +0100 From: "Lorenzo Stoakes (ARM)" To: Nicolas Schier Cc: Linus Torvalds , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Masahiro Yamada , Alexey Gladkov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Arnd Bergmann , Catalin Marinas , Will Deacon , Mark Rutland , Ard Biesheuvel , Ilias Apalodimas , Josh Poimboeuf , Peter Zijlstra , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , Onur =?utf-8?B?w5Z6a2Fu?= , Jonathan Corbet , Randy Dunlap , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, Jens Axboe Subject: Re: [PATCH 01/23] scripts/mksysmap: drop the MODULE_INFO() symbols from kallsyms Message-ID: References: <20260908-build-speedup-v1-0-5dc1ac01672d@kernel.org> <20260908-build-speedup-v1-1-5dc1ac01672d@kernel.org> <178898323844.67740.9621915831851570155.b4-review@b4> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <178898323844.67740.9621915831851570155.b4-review@b4> X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Sep 09, 2026 at 09:47:18PM +0200, Nicolas Schier wrote: > > Commit 3e86e4d74c04 ("kbuild: keep .modinfo section in vmlinux.unstripped") > > keeps .modinfo symbols out of System.map and kallsyms, which assumes unique > > IDs have a format like '__UNIQUE_ID_modinfo123'. > > > > However, commit afb026b6d35c ("compiler: Tweak __UNIQUE_ID() naming"), sent > > in the same cycle, changes this to '__UNIQUE_ID_modinfo_123'. > > > > As a result this regexp has never matched and every kernel since v6.18 has > > carried one kallsyms entries for every MODULE_INFO() declaration in the > > kernel whether the modules are compiled or not. > > > > That's 5,810 entries for an x86 defconfig build and 15,200 for arm64. > > > > On x86 defconfig that is 113 KiB of kallsyms tables and 32 KiB of bzImage, > > and every lookup walks past them. > > > > Fix the pattern. > > > > Fixes: 3e86e4d74c04 ("kbuild: keep .modinfo section in vmlinux.unstripped") > > > > No measurable change in build time, the smaller tables are not on any path > > the build waits for. > > > > For consistency, it would be nice to have the 'Fixes:' trailer at the > beginning of the trailer block (that is: here.) Yeah sorry my screw up when rejigging the commit message :) > > > Assisted-by: LLM > > Signed-off-by: Lorenzo Stoakes (ARM) > > > > diff --git a/scripts/mksysmap b/scripts/mksysmap > > index c4531eacde20..56a8b8bbdb37 100755 > > --- a/scripts/mksysmap > > +++ b/scripts/mksysmap > > @@ -83,7 +83,7 @@ > > / _SDA2_BASE_$/d > > > > # MODULE_INFO() > > -/ __UNIQUE_ID_modinfo[0-9]*$/d > > +/ __UNIQUE_ID_modinfo_[0-9]*$/d > > > > # --------------------------------------------------------------------------- > > # Ignored patterns > > Thanks! > > Reviewed-by: Nicolas Schier Thanks! > > -- > Nicolas > -- Cheers, Lorenzo _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv