From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E19C0606A626 for ; Fri, 20 Nov 2026 16:46:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=kLNJyvOf; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=IUmdIXLO DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=0SDWVLQx+Z8+vxJPHbLx4rG2imXk9YfbZycTSh9916A=; b=kLNJyvOfDKm35QK/TxyTNOPZoe tJHD1ogulRAgb0ss/RWOsd5EsBcZwdKdYnvsLivKz9cZzFKP6LZ8s9t/nM5AGXNzf8bvNo6s0MDK0 qGD17jcIoUDocO17iOHaxJYqyUsMgp3PdA/hXVOg36uxu0FGBO7KhS2SWXWxaRkheHdId1yN8lXPX LbM9mxZvNY4nd94O9/pxQtoxBpdUKGPB68SyMinEHTF0XlQBhyHJEeWREAvQwEEmkwGtOdRQeo6sh 9LpUwS8s2XSCTi6Zf4JVUzmO4E2CkK1swEvwtDVQNHZsPyYRiV26L0mE33sSv9KN52BpDqIunb59E ku49nQJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xURkF-0000000FaCL-3xjK; Fri, 20 Nov 2026 16:45:53 +0000 Received: from out-106.mta1.migadu.com ([95.215.58.106] helo=mta1.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xURk7-0000000FaB0-48V1 for linux-riscv@lists.infradead.org; Fri, 20 Nov 2026 16:45:47 +0000 X-Envelope-To: linux-riscv@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=YDYRuiqu28FARVRycYUTo1yCu3WrQdKNTM4EinGTQu4=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795193141; v=1; x=1795797941; b=IUmdIXLOLZJAcDHLhA6tijmSJT/IIjTV4JEhVpDYEe+W646jUacK2MwNXkRvdPJjCNlg9Vs9 KhHiuN8cvLrGb1lxYd+nQlBxaLGPHo1a1mJhVYxiKjDNDRzm64Q+oQzDxu225AB3eDl/TfuyIN7 R/kEaWOmKPS7ZQ2wHfzjxPrY= X-Envelope-To: linux-riscv@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id 41424811bc9a0852; Fri, 20 Nov 2026 16:45:39 +0000 X-Mizu-Trace-ID: 41424811bc9a0852 X-Migadu-Flow: FLOW_OUT Date: Fri, 20 Nov 2026 17:45:09 +0100 From: Andrew Jones To: Koichiro Den Cc: Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Bingyu Xian , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] RISC-V: KVM: Skip steal-time updates when run_delay is unchanged Message-ID: References: <20261118062242.2914385-1-den@valinux.co.jp> <20261118062242.2914385-3-den@valinux.co.jp> X-Archived-By: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261118062242.2914385-3-den@valinux.co.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261120_084546_517499_25CF9ED7 X-CRM114-Status: GOOD ( 15.35 ) X-Spam-Score: -2.8 (--) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Nov 18, 2026 at 03:22:42PM +0900, Koichiro Den wrote: > Check run_delay against last_steal and skip the update if they match. > This avoids accessing the SBI STA shared structure and marking its page > dirty on vCPU loads with no new steal time to report. > > Signed-off-by: Koichiro Den > --- > arch/riscv/kvm/vcpu_sbi_sta.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kvm/vcpu_sbi_sta.c b/arch/riscv/kvm/vcpu_sbi_sta.c > index cfc6f22c3e33..8b2499876fb4 100644 > --- a/arch/riscv/kvm/vcpu_sbi_sta.c > +++ b/arch/riscv/kvm/vcpu_sbi_sta.c > @@ -31,7 +31,7 @@ void kvm_riscv_vcpu_record_steal_time(struct kvm_vcpu *vcpu) > __le32 sequence_le; > __le64 steal_le; > u32 sequence; > - u64 steal; > + u64 steal, run_delay; > unsigned long hva; > bool dirty = false, success = false; > gfn_t gfn; > @@ -52,6 +52,10 @@ void kvm_riscv_vcpu_record_steal_time(struct kvm_vcpu *vcpu) > return; > } > > + run_delay = READ_ONCE(current->sched_info.run_delay); > + if (run_delay == last_steal) > + return; > + If we move the new check to just below the 'if (shmem == INVALID_GPA)' check then we also avoid a memslot lookup. > st = (struct sbi_sta_struct __user *)(hva + offset_in_page(shmem)); > might_fault(); > if (WARN_ON(!user_access_begin(st, sizeof(*st)))) > @@ -66,7 +70,7 @@ void kvm_riscv_vcpu_record_steal_time(struct kvm_vcpu *vcpu) > smp_wmb(); > unsafe_get_user(steal_le, &st->steal, update_sequence); > steal = le64_to_cpu(steal_le); > - vcpu->arch.sta.last_steal = READ_ONCE(current->sched_info.run_delay); > + vcpu->arch.sta.last_steal = run_delay; > steal += vcpu->arch.sta.last_steal - last_steal; > unsafe_put_user(cpu_to_le64(steal), &st->steal, update_sequence); > success = true; > -- > 2.54.0 > Otherwise, Reviewed-by: Andrew Jones _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv