From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1EA3C433EF for ; Fri, 7 Jan 2022 17:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qdwHIzomAr6Yh41Ib5qB2fQUvKFvIdSo0WV/qxy+9ws=; b=0+eBf0+ksuFoVCfSSIqeDD0uO0 2d21oTYlalEj+fvTCER8uoHoLsG/Ovww3l8c7txiy0kmAJnr4Riev2PxMdfKwrbWgvNrmY7GTwyDM 24c0Lbzgh2AqQEszVqdpIVoPLOp74x4bH7/teb98Z5tpNmpynBANVW7VHw/o4PUqNj53wyNVBiVOb rcySuMUBfjDcjDwgf0HLefCAJ1/Xx8apEFQXdOrPMJLDV62GuQoqfYNa9eIRYlUNLMSms3Qz/3qE1 Fxy3sbVnwX4w0byG5bFFgtH7pyd9OG9WwiPiDHcjBGv7PopmhdsXwezbn5Z2Xw/Si1KYNDtE6MTDh /zi/xpiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5srA-004j03-F0; Fri, 07 Jan 2022 17:16:48 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5sr7-004iz2-4H for linux-riscv@lists.infradead.org; Fri, 07 Jan 2022 17:16:47 +0000 Received: from fraeml740-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4JVqWg6H9Pz67ZhV; Sat, 8 Jan 2022 01:11:43 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml740-chm.china.huawei.com (10.206.15.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 7 Jan 2022 18:16:40 +0100 Received: from [10.47.89.210] (10.47.89.210) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 7 Jan 2022 17:16:37 +0000 Subject: Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI To: Bjorn Helgaas CC: Niklas Schnelle , Mauro Carvalho Chehab , Arnd Bergmann , Hans Verkuil , Ettore Chimenti , "Greg Kroah-Hartman" , Arnd Bergmann , Bjorn Helgaas , Nick Hu , Greentime Hu , Vincent Chen , "Paul Walmsley" , Palmer Dabbelt , Albert Ou , Guo Ren , "Damien Le Moal" , Ian Abbott , "H Hartley Sweeten" , Linus Walleij , Bartosz Golaszewski , Jean Delvare , Guenter Roeck , Dmitry Torokhov , Karsten Keil , "Sathya Prakash" , Sreekanth Reddy , Suganath Prabu Subramani , Michael Grzeschik , "David S. Miller" , "Jakub Kicinski" , Jesse Brandeburg , Tony Nguyen , Kalle Valo , Jouni Malinen , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Kashyap Desai , Sumit Saxena , Shivasharan S , Nilesh Javali , , Mark Brown , Sudip Mukherjee , "Teddy Wang" , Forest Bond , Jiri Slaby , "Wim Van Sebroeck" , Jaroslav Kysela , "Takashi Iwai" , , , , , , , , , , , , , , , , , , , , , , References: <20220106181409.GA297735@bhelgaas> From: John Garry Message-ID: Date: Fri, 7 Jan 2022 17:16:23 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20220106181409.GA297735@bhelgaas> Content-Language: en-US X-Originating-IP: [10.47.89.210] X-ClientProxiedBy: lhreml745-chm.china.huawei.com (10.201.108.195) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_091645_501571_B23D90E1 X-CRM114-Status: GOOD ( 20.58 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 06/01/2022 18:14, Bjorn Helgaas wrote: >> That driver would prob not be used on systems which does not support PIO, >> and so could have a HAS_IOPORT dependency. But it is not strictly necessary. > I don't want the path of "this driver isn't needed because the device > is unlikely to be used on this arch." Sure, that was just a one off example. As I mentioned before, I think that Arnd already did most of the ifdeffery work, but it was not included in this series. > > Maybe it's not_always_ possible, but if the device can be plugged > into the platform, I think we should be able to build the driver for > it. > > If the device requires I/O port space and the platform doesn't support > it, the PCI core or the driver should detect that and give a useful > diagnostic. > I'm not sure what the driver can say apart from -ENODEV. Or IO port management in resource.c could warn for requesting IO port region when it's unsupported. Anyway, this same conversion was had with Linus before I got involved. If you think it is worth discussing again then I suppose the authors here need to gain consensus. Thanks, John _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv