From: JeeHeng Sia <jeeheng.sia@starfivetech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"conor@kernel.org" <conor@kernel.org>,
"kernel@esmil.dk" <kernel@esmil.dk>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"emil.renner.berthing@canonical.com"
<emil.renner.berthing@canonical.com>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leyfoon Tan <leyfoon.tan@starfivetech.com>
Subject: RE: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive
Date: Tue, 28 Nov 2023 05:25:40 +0000 [thread overview]
Message-ID: <b423574c710b44aabb36cd434693b3e2@EXMBX066.cuchost.com> (raw)
In-Reply-To: <07fc5ebe-47b2-4843-ad49-36e6686e5a9a@kernel.org>
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Monday, November 27, 2023 4:49 PM
> To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu;
> conor@kernel.org; kernel@esmil.dk; robh+dt@kernel.org; emil.renner.berthing@canonical.com
> Cc: linux-riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan <leyfoon.tan@starfivetech.com>
> Subject: Re: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive
>
> On 27/11/2023 02:36, Sia Jee Heng wrote:
> > This patch adds the new compatible string for StarFive JH8100 SoC
> >
> > Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com>
> > Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > ---
> > drivers/tty/serial/xilinx_uartps.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> > index 66a45a634158..170901c143c2 100644
> > --- a/drivers/tty/serial/xilinx_uartps.c
> > +++ b/drivers/tty/serial/xilinx_uartps.c
> > @@ -1210,7 +1210,7 @@ OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup);
> > OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup);
> > OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup);
> > OF_EARLYCON_DECLARE(cdns, "xlnx,zynqmp-uart", cdns_early_console_setup);
> > -
> > +OF_EARLYCON_DECLARE(cdns, "starfive,jh8100-uart", cdns_early_console_setup);
> >
> > /* Static pointer to console port */
> > static struct uart_port *console_port;
> > @@ -1448,6 +1448,7 @@ static const struct of_device_id cdns_uart_of_match[] = {
> > { .compatible = "cdns,uart-r1p8", },
> > { .compatible = "cdns,uart-r1p12", .data = &zynqmp_uart_def },
> > { .compatible = "xlnx,zynqmp-uart", .data = &zynqmp_uart_def },
> > + { .compatible = "starfive,jh8100-uart", },
>
> Why you do not express compatibility in your bindings? Skip this driver
> change.
The compatibility string was added to the binding in the 5th patch. We need to add this compatibility string to the driver, as the other compatibilities were used for other SoCs.
>
> Best regards,
> Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-11-28 5:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 1:35 [PATCH 0/7] Initial device tree support for StarFive JH8100 SoC Sia Jee Heng
2023-11-27 1:35 ` [PATCH 1/7] dt-bindings: riscv: Add StarFive Dubhe compatibles Sia Jee Heng
2023-11-27 8:47 ` Krzysztof Kozlowski
2023-11-27 1:35 ` [PATCH 2/7] dt-bindings: riscv: Add StarFive JH8100 SoC Sia Jee Heng
2023-11-27 1:35 ` [PATCH 3/7] dt-bindings: timer: Add StarFive JH8100 clint Sia Jee Heng
2023-11-27 8:47 ` Krzysztof Kozlowski
2023-11-28 5:24 ` JeeHeng Sia
2023-11-28 7:19 ` Krzysztof Kozlowski
2023-11-28 7:56 ` JeeHeng Sia
2023-11-27 1:35 ` [PATCH 4/7] dt-bindings: interrupt-controller: Add StarFive JH8100 plic Sia Jee Heng
2023-11-27 8:48 ` Krzysztof Kozlowski
2023-11-27 1:36 ` [PATCH 5/7] dt-bindings: xilinx: Add StarFive compatible string Sia Jee Heng
2023-11-27 8:48 ` Krzysztof Kozlowski
2023-11-28 5:24 ` JeeHeng Sia
2023-11-27 1:36 ` [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive Sia Jee Heng
2023-11-27 8:49 ` Krzysztof Kozlowski
2023-11-28 5:25 ` JeeHeng Sia [this message]
2023-11-28 7:21 ` Krzysztof Kozlowski
2023-11-28 7:57 ` JeeHeng Sia
2023-11-27 1:36 ` [PATCH 7/7] riscv: dts: starfive: Add initial StarFive JH8100 device tree Sia Jee Heng
2023-11-27 8:50 ` Krzysztof Kozlowski
2023-11-27 9:20 ` Conor Dooley
2023-11-27 9:29 ` Krzysztof Kozlowski
2023-11-28 3:23 ` JeeHeng Sia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b423574c710b44aabb36cd434693b3e2@EXMBX066.cuchost.com \
--to=jeeheng.sia@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=kernel@esmil.dk \
--cc=krzk@kernel.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox