From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BC9C07E95 for ; Fri, 16 Jul 2021 10:24:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E5CF613F9 for ; Fri, 16 Jul 2021 10:24:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E5CF613F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=codethink.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RRW2RDPY5fNWmGt8HHebn0eMC+brOFVMYx6hbibc52E=; b=xtyofEbhJuJ4EYHS1y9XkF5unX sIGaiIpCtEk/vVbsYpvoF0Qhw8UytHZYB73C20NTW8QU7QCgEBy3Y61waIcpqWXy5nHn9o9Uj2AH5 UXdpBiv4ypSZZZM6mZLYBIcy5b1Bf5eyUbyD4dHtGEmWB4ywITNCCcWno+2zxBP1cZsV0WeErof/V SFBfVYXGv2TeS2MEhCmKqehejbm9hGUjItd69zS+bfN79L382nD6aiO9QrJuNOLTKm3VGDv7FnuNt qak5iI92r1e60ZqZkn1niakDWh0HY03YYTf/yAASwAFSsYJs0Z0jQWG+fVIMtvGhalZFAX2Z5GJuy dw4NBxYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4L0l-00443o-Kx; Fri, 16 Jul 2021 10:24:03 +0000 Received: from imap2.colo.codethink.co.uk ([78.40.148.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4L0c-0043zK-Ei for linux-riscv@lists.infradead.org; Fri, 16 Jul 2021 10:23:56 +0000 Received: from [167.98.27.226] (helo=[10.35.5.170]) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1m4L0W-0006x0-GA; Fri, 16 Jul 2021 11:23:48 +0100 Subject: Re: [PATCH] riscv: add correct as-options for assembly in modules To: linux-kernel@lists.codethink.co.uk, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20210712174849.2202287-1-ben.dooks@codethink.co.uk> From: Ben Dooks Organization: Codethink Limited. Message-ID: Date: Fri, 16 Jul 2021 11:23:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210712174849.2202287-1-ben.dooks@codethink.co.uk> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_032354_569935_D207DB9F X-CRM114-Status: GOOD ( 21.37 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 12/07/2021 18:48, Ben Dooks wrote: > When trying to load modules built for riscv which include assembly > the kernel loader errors with "unexpected relocation type 'R_RISCV_ALIGN'" > due to R_RISCV_ALIGN relocations being generated by the assembler. > > In commit 7a8e7da42250138 ("RISC-V: Fixes to module loading") > the fix for gcc adds -mno-relax to the command line when building > C files. However this was never applied to assembly flags, and gcc > does no pass -mno-relax to gas when presented with a .S file. > > The fix (other than making gcc always pass -mno-relax to gas) is > to add -Wa,-mno-relax to gcc to make sure the as is invoked with > the right options. > > Signed-off-by: Ben Dooks Just wanted to find out if anyone has had time to review this. If this is ok, should we also send to -stable ? > --- > arch/riscv/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile > index 1f5c03082976..fca40511a8c6 100644 > --- a/arch/riscv/Makefile > +++ b/arch/riscv/Makefile > @@ -60,6 +60,7 @@ ifeq ($(CONFIG_PERF_EVENTS),y) > endif > > KBUILD_CFLAGS_MODULE += $(call cc-option,-mno-relax) > +KBUILD_AFLAGS_MODULE += $(call as-option,-Wa$(comma)-mno-relax) > > # GCC versions that support the "-mstrict-align" option default to allowing > # unaligned accesses. While unaligned accesses are explicitly allowed in the > -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv