From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3611DC5AE59 for ; Sun, 25 May 2025 21:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-ID:Content-Type: MIME-Version:References:Message-ID:In-Reply-To:Subject:cc:To:Date:From: Reply-To:Content-Transfer-Encoding:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=erxtk+DkU6LdzlIQa7jkwCEPvHiSvnNSqsYknxT74ss=; b=BQ+VFaDis63OtDZtehR/uw5QdK i8/BUapyah+mFlDqdaVHMCAEymC0vMHThhQ0y0QJX7lLvF+qAjgF/LAgxodcni6DEXbhj5KfiYkDo Dk+1h6Lz5i1XJ4tZFu65I2Jy+d1ftTOfojmCjwf30aR7WeYZomM/SpjNmwyRdlq2BKT2Sz6mXgBZq bkcdQMk2cflFDnkVdeEs/0+t0VSSieCpwxdyRB5T6s+9pcHg/33OI1Hm7NLo98ngwkcFRgVIB7Jq1 INlNSgxhbi/fi73jFd/9XnYroDMTUjk7XxHF0otKOVjN4nPkBJvB5gXE6OcJx+pWxFiXLBpLbuZaU qDn5zhIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uJJHl-00000007jyl-3Lg8; Sun, 25 May 2025 21:53:37 +0000 Received: from mgamail.intel.com ([198.175.65.11]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uJJHi-00000007jy7-46yG; Sun, 25 May 2025 21:53:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748210015; x=1779746015; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version:content-id; bh=y5rT2ewj429hL1YZNClBKAuoapp2CjjiHYqsoHYBDa8=; b=n1thvU2nsN1FekQdLWKzOwYQeuWZcLH4BM61MM6F/Lveg8ERF3nrMIUP mkAREHfVaZCius/8GkG9imgSXPV0oo48VuUmmgI8gU8AztmBoLLdhSPF0 oCH+3OqERJTs8rxkrfXfPHfsHWnDFGNfwNZz9jClh/Xru/Namb4AqyGuB 3skJ60V6LGOOQVKijDHWh0saYGFNojrrTPzjeDLjhCIp+AYB84l0YW3Wb gJHGm2tG3mv8MHjzAPZTMHJY1Qc29ElxMKf9+HlgZSl6R55lCHBicJLAr V17yIdDC9O+67KroxtscWk4nRjAdyWmnOYUUK7pzwebacR81rf+he13h8 w==; X-CSE-ConnectionGUID: we3o1whcT5+ZmU/UNIEyeg== X-CSE-MsgGUID: LN02mRA0RNu8Q8tW98ijhw== X-IronPort-AV: E=McAfee;i="6700,10204,11444"; a="60435803" X-IronPort-AV: E=Sophos;i="6.15,314,1739865600"; d="scan'208";a="60435803" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2025 14:53:32 -0700 X-CSE-ConnectionGUID: srkUUk2LSiS9AVRoLfAP+A== X-CSE-MsgGUID: abYToWTKQVe6L6ZrKUUaNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,314,1739865600"; d="scan'208";a="141991367" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.99]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2025 14:53:16 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Mon, 26 May 2025 00:53:13 +0300 (EEST) To: Kees Cook cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Henrique de Moraes Holschuh , Hans de Goede , "Rafael J. Wysocki" , Len Brown , Masami Hiramatsu , Ard Biesheuvel , Mike Rapoport , Michal Wilczynski , Juergen Gross , Andy Shevchenko , "Kirill A. Shutemov" , Roger Pau Monne , David Woodhouse , Usama Arif , "Guilherme G. Piccoli" , Thomas Huth , Brian Gerst , kvm@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, "Gustavo A. R. Silva" , Christoph Hellwig , Marco Elver , Andrey Konovalov , Andrey Ryabinin , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , LKML , kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 04/14] x86: Handle KCOV __init vs inline mismatches In-Reply-To: <20250523043935.2009972-4-kees@kernel.org> Message-ID: References: <20250523043251.it.550-kees@kernel.org> <20250523043935.2009972-4-kees@kernel.org> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323328-965883235-1748206555=:933" Content-ID: <8656ab6c-8f8d-81d1-5dfa-740e7f21544c@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250525_145335_056513_153A674B X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-965883235-1748206555=:933 Content-Type: text/plain; CHARSET=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: On Thu, 22 May 2025, Kees Cook wrote: > When KCOV is enabled all functions get instrumented, unless the > __no_sanitize_coverage attribute is used. To prepare for > __no_sanitize_coverage being applied to __init functions, we have to > handle differences in how GCC's inline optimizations get resolved. For > x86 this means forcing several functions to be inline with > __always_inline. >=20 > Signed-off-by: Kees Cook > --- > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: > Cc: "H. Peter Anvin" > Cc: Paolo Bonzini > Cc: Vitaly Kuznetsov > Cc: Henrique de Moraes Holschuh > Cc: Hans de Goede > Cc: "Ilpo J=E4rvinen" > Cc: "Rafael J. Wysocki" > Cc: Len Brown > Cc: Masami Hiramatsu > Cc: Ard Biesheuvel > Cc: Mike Rapoport > Cc: Michal Wilczynski > Cc: Juergen Gross > Cc: Andy Shevchenko > Cc: "Kirill A. Shutemov" > Cc: Roger Pau Monne > Cc: David Woodhouse > Cc: Usama Arif > Cc: "Guilherme G. Piccoli" > Cc: Thomas Huth > Cc: Brian Gerst > Cc: > Cc: > Cc: > Cc: > Cc: > Cc: > Cc: > --- > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/= thinkpad_acpi.c > index e7350c9fa3aa..0518d5b1f4ec 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -559,12 +559,12 @@ static unsigned long __init tpacpi_check_quirks( > =09return 0; > } > =20 > -static inline bool __pure __init tpacpi_is_lenovo(void) > +static __always_inline bool __pure tpacpi_is_lenovo(void) > { > =09return thinkpad_id.vendor =3D=3D PCI_VENDOR_ID_LENOVO; > } > =20 > -static inline bool __pure __init tpacpi_is_ibm(void) > +static __always_inline bool __pure tpacpi_is_ibm(void) > { > =09return thinkpad_id.vendor =3D=3D PCI_VENDOR_ID_IBM; > } Hi Kees, What's your plan on upstreaming route/timeline for this? I'd prefer to=20 retain full control over this file as we were planning on some=20 reorganization of files into lenovo/ subdir. --=20 i. --8323328-965883235-1748206555=:933 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv --8323328-965883235-1748206555=:933--