From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9509E77198 for ; Mon, 6 Jan 2025 13:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7TfEXwgyqXQIZAjgkeVo/tDFb3fE9u39he90wGjx+sw=; b=f0lyrlZrb1JJ+n 75zEEUXvzUl3BAJj5jDplHVMf9eyne/yzoyVBt8yOXR8CcvNtkPgwYUJ2AsPhbhsrF5wJaT6On4iw geae5xp3QnrlqvodjlSZc1rXXXOCZI7dB683WfhzL2OrKRCBTp1S+VV87VhkwVi94kUp9H4RlLipN 9NPCg9p+EzOyboS7c3cMkribY+XqHFOI/xkzmi781x0Rc2mIzFopSUJaBCxscP6szikQUn1MigZRl HBBIWxxVv+M3cU439VH6xHzl5Cv8KPcmmwyDHkC9dBl/Lr5UgptvHX8pbospVNbgRc5CewLyiKM3S AFROnT/Ap0y41qLhyiug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tUn55-00000001O5V-2HJB; Mon, 06 Jan 2025 13:23:43 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tUn4m-00000001Nww-1uNr for linux-riscv@lists.infradead.org; Mon, 06 Jan 2025 13:23:26 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-21654fdd5daso191315095ad.1 for ; Mon, 06 Jan 2025 05:23:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736169803; x=1736774603; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=af8Jbj+kqP+p1W8uyVyt9V0YBDVs6Wu8XxDGXWv1rDo=; b=h9je9bnkJ1K58rmo3mSBqhalm02umZk1VXKIKRBynSte3n2WUgiyTcOIiSPptpo21H YFKE/FruLpWnKeu34E8koURHHuofMbKF/SELtRHw4QpibjA0JsTuZcIrsdtZ8u7DVE8v rTkYn387OP5F0u4RJiGU7tpgLPidWfh1rGjCeVgGoS0bxKJ5Avkrq45pw3razAO0fUyz YMQPx0UrprOMxHIbUiHcKsPoiWKhuH8Z1mNUje/NZA4i5QwGnBgTQ1R0PiTgPwkxV8iO 0NZvASmMB23NHO6/Khq/JXAw5WaQHtc7xJ3JQwzL52b5oMeOoKt6p4eM+FGHqxkauUGE eU4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736169803; x=1736774603; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=af8Jbj+kqP+p1W8uyVyt9V0YBDVs6Wu8XxDGXWv1rDo=; b=iXh6GutnZgESAYmr+jHgeB8n+DoMBwOkSsAqP0J5UCo46T7UdKukkMprqiq0+tUvav twopOZhcdFdcfOTFgWzwMKPsMdSdl14jjUk1I5eEHYGQbQTjwQE0bxJLXxkyXbKraGJk +cAo9HEHhDCx9RHFGlP4U2q15zzfFZK84p3TCtIfW/RFDqkezI2FoOV4J2HAtURae3Kn m6oQ7BeTNmrk7TWSxZePavWh4YqTOU2gNdJnwy559yqlp84YAroHViaA8gkWEZOYdBoY m5fk7yDmXPSF7peaU8dwBhYOVC4yKd3XEpcqHUPBXilkflCXMDU/hurOMNxMsCG8HsLy wrpQ== X-Forwarded-Encrypted: i=1; AJvYcCWIhJitRnvnFGra/5F3YPPhyZNdEOKi3LfLMU9MYmygK38j+4l2qmq2MhRWaP2ri/3SX69mryhIWWSgdQ==@lists.infradead.org X-Gm-Message-State: AOJu0YxAq5tFqCqQ31jzwsZ3kKAYadQVslDK3qB+FC7wE4YUjxDfH94f jZ1SxpsUAuvqcj2e2nYZS2gvEnUjyfNZmp7FEuU1lO/2hzEXTi14QQ09uOdAn2k= X-Gm-Gg: ASbGncu/T0UilxCZxTlJPVvLE09ED1PMZ7benaGTQgBvKJw+qZF3q3IoL3k0mMKZyoH 0UxcXm0nHws3JbmHACUOzEdvZW6cfRkHl1CzPgBj7DtXQaK0cpHU35CH8Gy9FTqHLW/5THg/iJO WDsytihureSYcCCiCjYHq5vKMv1zLuCHxqM2qhDUY2tMR8RWH5pnSex0xXxaW4ad3BvnqJMW/T9 bth8KlaQff62V3DE1OymIxzRomKlOH7me5EjP3Yd/CWFjO/w9FUvBxP+/GO0owd1bjl6KNck6LD aaH+gj6mVINhmw5p+zdw524eMyws3OHAvh0qOBjFqAI1eFlp7UEd X-Google-Smtp-Source: AGHT+IE/ZrXmD5LZyqp5+IF7XucHWltqSucrfnZMLD6UEt/qaBj6OXgwMq9je0lWMbXPRWlni+TKWA== X-Received: by 2002:a05:6a20:2d07:b0:1e1:b44f:cff1 with SMTP id adf61e73a8af0-1e5e07f9c06mr81291446637.33.1736169803320; Mon, 06 Jan 2025 05:23:23 -0800 (PST) Received: from ?IPV6:2409:8a28:f44:d64:296c:a8f3:f81e:f88b? ([2409:8a28:f44:d64:296c:a8f3:f81e:f88b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad90c149sm31371677b3a.191.2025.01.06.05.23.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 05:23:22 -0800 (PST) Message-ID: Date: Mon, 6 Jan 2025 21:23:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 07/15] mm: pgtable: introduce pagetable_dtor() Content-Language: en-US To: Alexander Gordeev Cc: peterz@infradead.org, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <8ada95453180c71b7fca92b9a9f11fa0f92d45a6.1735549103.git.zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250106_052324_503407_E90247B4 X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2025/1/6 20:36, Alexander Gordeev wrote: > On Mon, Jan 06, 2025 at 06:55:58PM +0800, Qi Zheng wrote: >>>> +static inline void pagetable_dtor(struct ptdesc *ptdesc) >>>> +{ >>>> + struct folio *folio = ptdesc_folio(ptdesc); >>>> + >>>> + ptlock_free(ptdesc); >>>> + __folio_clear_pgtable(folio); >>>> + lruvec_stat_sub_folio(folio, NR_PAGETABLE); >>>> +} >>>> + >>> >>> If I am not mistaken, it is just pagetable_pte_dtor() rename. >>> What is the point in moving the code around? >> >> No, this is to unify pagetable_p*_dtor() into pagetable_dtor(), so >> that we can move pagetable_dtor() to __tlb_remove_table(), and then >> ptlock and PTE page can be freed together through RCU, which is >> also the main purpose of this patch series. > > I am only talking about this patch. pagetable_dtor() code above is > the same pagetable_pte_dtor() below - it is only the function name > that changed. So why to move the function body? Anyway, that is Ah, I just don't want to put pagetable_dtor() in between pagetable_pte_ctor() and ___pte_offset_map(), so I moved it above pagetable_pte_ctor(). No other special reason. ;) Thanks! > just a nit. > >> Thanks! > >>>> -static inline void pagetable_pte_dtor(struct ptdesc *ptdesc) >>>> -{ >>>> - struct folio *folio = ptdesc_folio(ptdesc); >>>> - >>>> - ptlock_free(ptdesc); >>>> - __folio_clear_pgtable(folio); >>>> - lruvec_stat_sub_folio(folio, NR_PAGETABLE); >>>> -} > > Thank you! _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv