Re: [PATCH v4 0/5] Add support for the PolarFire SoC system controller

Jassi Brar
2021-03-30T23:54:53Z

On Tue, Mar 30, 2021 at 6:06 AM <Conor.Dooley@microchip.com> wrote:

> >> create mode 100644
> >> Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml
> >> create mode 100644 drivers/mailbox/mailbox-mpfs.c
> >> create mode 100644 drivers/soc/microchip/Kconfig
> >> create mode 100644 drivers/soc/microchip/Makefile
> >> create mode 100644 drivers/soc/microchip/mpfs-sys-controller.c
> >> create mode 100644 include/soc/microchip/mpfs.h
> >
> > The only problem I see here is that patch #3 (the driver for the system
> > controller) comes before patch #4 (the DT bindings for that driver).
> > That
> > triggers a checkpatch warning. I can just reorder it, but it would be
> > great to
> > have some reviews from the DT and mailbox people. If not I'll try and
> > find
> > some time to take a closer look.
>
> I've had a fair bit of back and forth with Rob about the dt bindings,
> hopefully this version he happy with - think all of his concerns have
> now been addressed. Haven't heard anything from Jassi Brar on the device
> tree side however
>
Nowhere is explained how the controller works, and the bindings seem
trivial, so I have no concern.

-j