From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
"Conor.Dooley@microchip.com" <Conor.Dooley@microchip.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Cc: "Cyril.Jean@microchip.com" <Cyril.Jean@microchip.com>,
"david.abdurachmanov@gmail.com" <david.abdurachmanov@gmail.com>,
"Daire.McNamara@microchip.com" <Daire.McNamara@microchip.com>,
Anup Patel <Anup.Patel@wdc.com>,
Atish Patra <Atish.Patra@wdc.com>,
"Lewis.Hanly@microchip.com" <Lewis.Hanly@microchip.com>
Subject: Re: [PATCH 1/6] mbox: add polarfire soc system controller mailbox
Date: Tue, 1 Dec 2020 10:11:49 +0000 [thread overview]
Message-ID: <bf2e38ae-dbc0-8952-9a30-b56a5340c28a@codethink.co.uk> (raw)
In-Reply-To: <CH2PR04MB6522D8B7E1EC319733D72CA5E7F50@CH2PR04MB6522.namprd04.prod.outlook.com>
On 30/11/2020 21:50, Damien Le Moal wrote:
> On 2020/11/30 22:23, Conor.Dooley@microchip.com wrote:
>> On 20/11/2020 00:05, Damien Le Moal wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> On 2020/11/20 2:05, conor.dooley@microchip.com wrote:
>>>> From: Conor Dooley <conor.dooley@microchip.com>
>>>>
>>>> This driver adds support for the single mailbox channel of the MSS
>>>> system controller on the Microchip PolarFire SoC.
>>>>
>>>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>>>> ---
>>>> drivers/mailbox/Kconfig | 12 ++
>>>> drivers/mailbox/Makefile | 2 +
>>>> drivers/mailbox/mailbox-mpfs.c | 296 +++++++++++++++++++++++++++++++++
>>>> 3 files changed, 310 insertions(+)
>>>> create mode 100644 drivers/mailbox/mailbox-mpfs.c
>>>>
>>>> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
>>>> index 05b1009e2820..4881a519683a 100644
>>>> --- a/drivers/mailbox/Kconfig
>>>> +++ b/drivers/mailbox/Kconfig
>>>> @@ -153,6 +153,18 @@ config MAILBOX_TEST
>>>> Test client to help with testing new Controller driver
>>>> implementations.
>>>>
>>>> +config MPFS_MBOX
>>>> + tristate "MPFS Mailbox"
>>>> + depends on HAS_IOMEM
>>> Shouldn't this dependency be on SOC_MICROCHIP_POLARFIRE ?
>> Not entirely sure what you mean by this one. You want the HAS_IOMEM to be selected by SOC_MICROCHIP_POLARFIRE ?
>
> Sorry, I was not clear. I was referring to MPFS_MBOX: shouldn't it be dependent
> on SOC_MICROCHIP_POLARFIRE ? E.g.:
>
> config MPFS_MBOX
> tristate "MPFS Mailbox"
> depends on HAS_IOMEM
> depends on SOC_MICROCHIP_POLARFIRE
> ...
probably depends on SOC_MICROCHIP_POLARFIRE || COMPILE_TEST
so that you can build a "compile test" kernel with as much enabled as
possible
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-12-01 10:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 17:04 [PATCH 1/6] mbox: add polarfire soc system controller mailbox conor.dooley
2020-11-20 0:05 ` Damien Le Moal
2020-11-30 13:23 ` Conor.Dooley
2020-11-30 21:50 ` Damien Le Moal
2020-12-01 10:11 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf2e38ae-dbc0-8952-9a30-b56a5340c28a@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=Conor.Dooley@microchip.com \
--cc=Cyril.Jean@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Lewis.Hanly@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).