Re: [PATCH v2 2/3] drivers: watchdog: Add StarFive Watchdog driver

Xingyu Wu
2023-02-17T07:29:24Z

On 2023/2/17 10:30, Xingyu Wu wrote:
> On 2023/2/16 22:57, Guenter Roeck wrote:
>> On 2/15/23 23:11, Xingyu Wu wrote:
>>> On 2023/2/2 6:46, Guenter Roeck wrote:
>>>> On Mon, Dec 19, 2022 at 05:42:32PM +0800, Xingyu Wu wrote:
>>>>> Add watchdog driver for the StarFive JH7110 SoC.
>>>>>
>>>>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>>>>> +
>>>>> [...]
>>>>> +
>>>>> +static const struct watchdog_info starfive_wdt_ident = {
>>>>> +    .options = OPTIONS,
>>>>> +    .firmware_version = 0,
>>>>
>>>> It is not necessary to initilize a static variable with 0.
>>>>
>>>>> +    .identity = "StarFive Watchdog",
>>>>> +};
>>>
>>> Hi Guenter,
>>>
>>> It would be a compilation error if drop the '0'. I found that other files
>>
>> No.
>>
>>> initialize this static variable as well.
>>>
>>
>> Ah, the old "others do it, so do I" argument.
>> Sorry, that is not a valid argument.
>>
>
> Can I assign ‘firmware_version’ to a macro definition in the probe?
>

Or drop the 'firmware_version' ?

Best regards,
Xingyu Wu