From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88EE9C5AE59 for ; Tue, 3 Jun 2025 18:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:From:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5aHBT1x915ZYtjzG5zxRCpxkU3iawBal10XrrQLXNlQ=; b=Mkh8hjNN75+iB4 d9+isuzU9XfAEzQd12r/1CYbFbXpbIBdYmHV5T8wIzwIVMaYwCyTbao97McC/2KKhhu9JkRV865CW npErTCrrww9b09Os6p6mr5Qq2BI6vSz7XdSZWVo6HjxaIgm1w2a9HAm0ghEZlURsTg+O92713n8he o6fRw40tG4H4jmx/tZlQFMlYKG95aIKngGnFzYavAB0ugIgLwNRbjGhzpQVVht0X2QmfGm3vOh4cF DhEL1worgwt0WK7Q/K034iGB2cDrMXnC4zJ+BY8O72p7SJQVSXToucR+4QpGcAXWe/2eVyptXVorp rsJI33IjdGDK2N5aDrMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uMWeE-0000000Bdkr-0X7D; Tue, 03 Jun 2025 18:46:06 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uMWeA-0000000BdkH-0j6v for linux-riscv@lists.infradead.org; Tue, 03 Jun 2025 18:46:04 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20250603184558euoutp0281c7af604e3672111d1d027566534f34~FnLtl1I4k1370413704euoutp02F for ; Tue, 3 Jun 2025 18:45:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20250603184558euoutp0281c7af604e3672111d1d027566534f34~FnLtl1I4k1370413704euoutp02F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1748976359; bh=uQI33aeDB3YvTs31NM2w9GJCDXa/2VEkwRCdI0P0nAY=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=p6R6G1I/UJlWGGgHhiFgapjrXWtpYAp0wFUx+fMIeVC0whJhUVE4iLcwGu6uJQPDX tbymJJR4kt4AxTqJInTfFfiW/lTUg8oDgKpcT8YaXuF+Wcy7NCxP5XcIu6LOegllpE FPNMEGF9lWfUX5vjxWznVNzeajEcJYE5LuvBrQxA= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20250603184558eucas1p179c610c48e6f475d839e9e25585cbe2a~FnLs7Ny4R3131431314eucas1p1h; Tue, 3 Jun 2025 18:45:58 +0000 (GMT) Received: from [192.168.1.44] (unknown [106.210.136.40]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250603184557eusmtip2e68f8fe1c77ac8990d75a102efcf9f08~FnLr3jqqk0715807158eusmtip2N; Tue, 3 Jun 2025 18:45:57 +0000 (GMT) Message-ID: Date: Tue, 3 Jun 2025 20:45:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/8] riscv: dts: thead: Add GPU power sequencer node To: Krzysztof Kozlowski Cc: Drew Fustini , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Philipp Zabel , Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Ulf Hansson , Marek Szyprowski , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Language: en-US From: Michal Wilczynski In-Reply-To: <20250603-gleaming-mammoth-of-kindness-538add@kuoka> X-CMS-MailID: 20250603184558eucas1p179c610c48e6f475d839e9e25585cbe2a X-Msg-Generator: CA X-RootMTR: 20250529222408eucas1p20f62cea4c9c64bb5dda6db1fd38fb333 X-EPHeader: CA X-CMS-RootMailID: 20250529222408eucas1p20f62cea4c9c64bb5dda6db1fd38fb333 References: <20250530-apr_14_for_sending-v3-0-83d5744d997c@samsung.com> <20250530-apr_14_for_sending-v3-6-83d5744d997c@samsung.com> <20250603-gleaming-mammoth-of-kindness-538add@kuoka> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250603_114602_821818_2C67545C X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 6/3/25 15:22, Krzysztof Kozlowski wrote: > On Fri, May 30, 2025 at 12:23:53AM GMT, Michal Wilczynski wrote: >> Add the device tree node for the T-HEAD TH1520 GPU power sequencer >> (gpu_pwrseq) to the th1520.dtsi file. >> >> This node instantiates the thead,th1520-gpu-pwrseq driver, which > > Explain the hardware, not what drivers do. > >> is responsible for managing the GPU's power-on/off sequence. The node >> specifies the gpu-clkgen reset, which is one of the resources >> controlled by this sequencer. >> >> Signed-off-by: Michal Wilczynski >> --- >> arch/riscv/boot/dts/thead/th1520.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi >> index bdbb1b985b0b76cf669a9bf40c6ec37258329056..6170eec79e919b606a2046ac8f52db07e47ef441 100644 >> --- a/arch/riscv/boot/dts/thead/th1520.dtsi >> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi >> @@ -238,6 +238,12 @@ aon: aon { >> #power-domain-cells = <1>; >> }; >> >> + gpu_pwrseq: pwrseq { > > Node names should be generic. See also an explanation and list of > examples (not exhaustive) in DT specification: > https://protect2.fireeye.com/v1/url?k=a53ea5d3-c4434f50-a53f2e9c-74fe48600158-c81092475ef416b3&q=1&e=d333d06b-0b06-493e-a358-e29ca542dfe7&u=https%3A%2F%2Fdevicetree-specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-basics.html%23generic-names-recommendation > >> + compatible = "thead,th1520-gpu-pwrseq"; >> + resets = <&rst TH1520_RESET_ID_GPU_CLKGEN>; >> + reset-names = "gpu-clkgen"; > > What is the point of pwrseq if there is no consumer/user of it? Looks > like simple placeholder and anyway maybe the future consumer should just > use reset directly. Yeah I think you're right, I wanted to explore adding the pwrseq provider in separate node per discussion in v2 [1]. But for the v4 I think I'll revert to the v2 way of handling this reset [2]. [1] - https://lore.kernel.org/all/CAPDyKFpi6_CD++a9sbGBvJCuBSQS6YcpNttkRQhQMTWy1yyrRg@mail.gmail.com/ [2] - https://lore.kernel.org/all/20250414-apr_14_for_sending-v2-2-70c5af2af96c@samsung.com/ > > Best regards, > Krzysztof > > Best regards, -- Michal Wilczynski _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv