Re: [PATCH v5 3/9] riscv/kprobe: Prepare the skeleton to prepare optimized kprobe

Björn Töpel
2023-01-04T08:59:11Z

"liaochang (A)" <liaochang1@huawei.com> writes:

>>> + */
>>> + rel = (unsigned long)slot - (unsigned long)orig->addr;
>>> + if (!in_auipc_jalr_range(rel)) {
>>> + /*
>>> + * Different from x86, we free code buf directly instead
>>> of
>>
>> Reword for readers that are not familiar with x86.
>
> OK, BTW, i think the code following tag on_error is fairly self-explanatoty,
> perhaps this comment is no need anymore.

Fair enough! :-)

Björn