Re: [PATCH v2 5/6] ACPI: NUMA: Remove ARCH depends option in ACPI_NUMA Kconfig

From: "Arnd Bergmann" <arnd@arndb.de>
To: "Haibo Xu" <haibo1.xu@intel.com>
Cc: "Alison Schofield" <alison.schofield@intel.com>,
	"Jisheng Zhang" <jszhang@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Björn Töpel" <bjorn@rivosinc.com>,
	"Conor.Dooley" <conor.dooley@microchip.com>,
	guoren <guoren@kernel.org>, "Zong Li" <zong.li@sifive.com>,
	"James Morse" <james.morse@arm.com>,
	linux-riscv@lists.infradead.org,
	"Ard Biesheuvel" <ardb@kernel.org>, "Baoquan He" <bhe@redhat.com>,
	acpica-devel@lists.linux.dev,
	"Robert Moore" <robert.moore@intel.com>,
	linux-acpi@vger.kernel.org,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Greentime Hu" <greentime.hu@sifive.com>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Len Brown" <lenb@kernel.org>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alexghiti@rivosinc.com>,
	"Charlie Jenkins" <charlie@rivosinc.com>,
	"Chen Jiahao" <chenjiahao16@huawei.com>,
	"Yuntao Wang" <ytcoode@gmail.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Clément Léger" <cleger@rivosinc.com>,
	"Haibo Xu" <xiaobo55x@gmail.com>,
	"Anup Patel" <apatel@ventanamicro.com>,
	"Tony Luck" <tony.luck@intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Evan Green" <evan@rivosinc.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Andrew Jones" <ajones@ventanamicro.com>
Subject: Re: [PATCH v2 5/6] ACPI: NUMA: Remove ARCH depends option in ACPI_NUMA Kconfig
Date: Thu, 07 Mar 2024 09:44:03 +0100	[thread overview]
Message-ID: <c9e9da9f-ff81-48eb-beec-4f54921cd268@app.fastmail.com> (raw)
In-Reply-To: <f23da383a8fdbee15acd41fdcd38ef3a89045a43.1709780590.git.haibo1.xu@intel.com>

On Thu, Mar 7, 2024, at 09:47, Haibo Xu wrote:
> x86/arm64/loongarch would select ACPI_NUMA by default and riscv
> would do the same thing, so the dependency is no longer needed
> since these are the four architectures that support ACPI.
>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Suggested-by: Sunil V L <sunilvl@ventanamicro.com>
> Signed-off-by: Haibo Xu <haibo1.xu@intel.com>
> ---
>  drivers/acpi/numa/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig
> index 849c2bd820b9..2bf47ad1ec9b 100644
> --- a/drivers/acpi/numa/Kconfig
> +++ b/drivers/acpi/numa/Kconfig
> @@ -2,7 +2,6 @@
>  config ACPI_NUMA
>  	bool "NUMA support"
>  	depends on NUMA
> -	depends on (X86 || ARM64 || LOONGARCH)
>  	default y if ARM64

Can we remove the prompt as well and make this a
hidden option? I think this is now always selected
when it can be used anyway.

If we make it

      def_bool NUMA && !X86

then the select statements except for the X86_64_ACPI_NUMA
can also go away.

      Arnd

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv