Re: [PATCH v5 2/3] reset: tenstorrent: Add reset controller for Atlantis

[Krzysztof Kozlowski <krzk@kernel.org>]

On 05/02/2026 15:18, Anirudh Srinivasan wrote:
> Hello Krzysztof,
> 
> On Thu, Feb 5, 2026 at 3:27 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Mon, Feb 02, 2026 at 01:46:50PM -0600, Anirudh Srinivasan wrote:
>>> diff --git a/include/soc/tenstorrent/atlantis-prcm.h b/include/soc/tenstorrent/atlantis-prcm.h
>>> new file mode 100644
>>> index 000000000000..841516cbefd9
>>> --- /dev/null
>>> +++ b/include/soc/tenstorrent/atlantis-prcm.h
>>> @@ -0,0 +1,31 @@
>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>> +/*
>>> + * Shared definitions for Atlantis PRCM Clock and Reset Drivers
>>> + *
>>> + * Copyright (c) 2026 Tenstorrent
>>> + */
>>> +#ifndef __SOC_ATLANTIS_PRCM_H__
>>> +#define __SOC_ATLANTIS_PRCM_H__
>>> +
>>> +#include <linux/bits.h>
>>> +#include <linux/types.h>
>>> +
>>> +struct atlantis_prcm_adev {
>>> +     struct auxiliary_device adev;
>>> +     struct regmap *regmap;
>>> +};
>>
>> Drop, there is no driver-wide user of this.
> 
>>
>>> +
>>> +static inline struct atlantis_prcm_adev *
>>> +to_atlantis_prcm_adev(struct auxiliary_device *adev)
>>
>> Same here.
>>
>> Do not add symbols to headers which nothing uses. These are private to
>> the driver so they must stay ONLY in the driver.
> 
> The definitions in these files are shared between the clock and reset
> driver (which are in drivers/clk/tenstorrent/ and drivers/reset/),
> hence they have been put here.


Ah, but then I wonder why your clock driver needs to access reset driver
structures. Or vice versa. You are only expected to get regmap from the
parent, no?


Best regards,
Krzysztof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv