Re: [PATCH] riscv: Update k210 defconfigs

[Damien Le Moal <damien.lemoal@opensource.wdc.com>]

On 11/15/22 05:05, Conor Dooley wrote:
> On Mon, Nov 14, 2022 at 10:31:51AM +0900, Damien Le Moal wrote:
>> In preparation for SLOB deprecation, update the nommu_k210_* defconfigs
>> to switch to using SLUB. To save memory, CONFIG_SLUB_CPU_PARTIAL is not
>> selected.
>>
>> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
>> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> 
> Hey,
> Gave it a go w/ your v21 branch. To me, seems about as usable as it was
> before...

Please use upstream buildroot. Everything is in master for this board and
that v21 branch is dead now.

> Tested-by: Conor Dooley <conor.dooley@microchip.com>

I used buildroot defconfigs sipeed_maix_bit_defconfig and
sipeed_maix_bit_sd_card_defconfig. Both had the same issue with SLUB: lots
of errors with the shell, including failures for the init shell commands.
And sometimes I end up with a prompt but no way to run any shell command
at all. I guess that depends on fragmentation of the memory after boot
completes.

> 
> btw, what's the craic with that? Looks like you actually landed in
> upstream buildroot fairly soon after you pointed me at your series.
> Anything missing from buildroot, or did it all land?

Everything landed, plus some (some build fixes).

Palmer,

Please hold on before applying this patch. Discussion still going on about
SLUB.

> 
> Thanks,
> Conor.
> 
>> ---
>>  arch/riscv/configs/nommu_k210_defconfig        | 6 +++---
>>  arch/riscv/configs/nommu_k210_sdcard_defconfig | 6 +++---
>>  2 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/riscv/configs/nommu_k210_defconfig b/arch/riscv/configs/nommu_k210_defconfig
>> index 96fe8def644c..18de91e84d1c 100644
>> --- a/arch/riscv/configs/nommu_k210_defconfig
>> +++ b/arch/riscv/configs/nommu_k210_defconfig
>> @@ -23,9 +23,6 @@ CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>>  # CONFIG_ADVISE_SYSCALLS is not set
>>  # CONFIG_KALLSYMS is not set
>>  CONFIG_EMBEDDED=y
>> -# CONFIG_VM_EVENT_COUNTERS is not set
>> -# CONFIG_COMPAT_BRK is not set
>> -CONFIG_SLOB=y
>>  # CONFIG_MMU is not set
>>  CONFIG_SOC_CANAAN=y
>>  CONFIG_NONPORTABLE=y
>> @@ -39,6 +36,9 @@ CONFIG_CMDLINE_FORCE=y
>>  # CONFIG_BLOCK is not set
>>  CONFIG_BINFMT_FLAT=y
>>  # CONFIG_COREDUMP is not set
>> +# CONFIG_SLUB_CPU_PARTIAL is not set
>> +# CONFIG_COMPAT_BRK is not set
>> +# CONFIG_VM_EVENT_COUNTERS is not set
>>  CONFIG_DEVTMPFS=y
>>  CONFIG_DEVTMPFS_MOUNT=y
>>  # CONFIG_FW_LOADER is not set
>> diff --git a/arch/riscv/configs/nommu_k210_sdcard_defconfig b/arch/riscv/configs/nommu_k210_sdcard_defconfig
>> index 379740654373..718d2729a03e 100644
>> --- a/arch/riscv/configs/nommu_k210_sdcard_defconfig
>> +++ b/arch/riscv/configs/nommu_k210_sdcard_defconfig
>> @@ -15,9 +15,6 @@ CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>>  # CONFIG_ADVISE_SYSCALLS is not set
>>  # CONFIG_KALLSYMS is not set
>>  CONFIG_EMBEDDED=y
>> -# CONFIG_VM_EVENT_COUNTERS is not set
>> -# CONFIG_COMPAT_BRK is not set
>> -CONFIG_SLOB=y
>>  # CONFIG_MMU is not set
>>  CONFIG_SOC_CANAAN=y
>>  CONFIG_NONPORTABLE=y
>> @@ -32,6 +29,9 @@ CONFIG_CMDLINE_FORCE=y
>>  # CONFIG_MQ_IOSCHED_KYBER is not set
>>  CONFIG_BINFMT_FLAT=y
>>  # CONFIG_COREDUMP is not set
>> +# CONFIG_SLUB_CPU_PARTIAL is not set
>> +# CONFIG_COMPAT_BRK is not set
>> +# CONFIG_VM_EVENT_COUNTERS is not set
>>  CONFIG_DEVTMPFS=y
>>  CONFIG_DEVTMPFS_MOUNT=y
>>  # CONFIG_FW_LOADER is not set
>> -- 
>> 2.38.1
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv

-- 
Damien Le Moal
Western Digital Research


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv