From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7A2BC7618A for ; Mon, 20 Mar 2023 07:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uqHFsr1VgQdoOFI7IG1zbX0eu90uJdCcs7Lu4yP0GxQ=; b=vUKGDZQMapE8x0 TuQj0DfTXpfflkqSt/QzefOKYU1rByK8UUxdAHDs43MZ6YwGgTkjGag6/0FyyWvfKywziaBKrf4ci HAj/WtASEWqrltbmIcivSjljqiwnh6aQQ6beZ59nlgte8OP2I2tOTI/4ZhaBLxut74wEhhq/2Ms8O hHO6SJ4gfuLZzQkN2QdvwyZ+jljZ5fGhNvgwCKeMcb+o1Idm/TnooWJC7FCmAnzBEJQvnVDn0+dTb azVvBfJe2k321WB4WNY9h7BZP+rHeguFBWuhyiQOLpm5QJ/oeDj7R/HmND3+zPNSl874oTlibeGtq AOqq+5DGe18h7dDULjog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peA0N-008JUh-1R; Mon, 20 Mar 2023 07:32:31 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peA0K-008JTk-00 for linux-riscv@lists.infradead.org; Mon, 20 Mar 2023 07:32:29 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 5D21524E269; Mon, 20 Mar 2023 15:32:16 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 20 Mar 2023 15:32:16 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 20 Mar 2023 15:32:15 +0800 Message-ID: Date: Mon, 20 Mar 2023 15:32:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RESEND v6 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc Content-Language: en-US To: Krzysztof Kozlowski , , , CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Emil Renner Berthing" References: <20230315055813.94740-1-william.qiu@starfivetech.com> <20230315055813.94740-2-william.qiu@starfivetech.com> <850bc37e-c6d1-2381-a851-965a4cbee8a0@linaro.org> From: William Qiu In-Reply-To: X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_003228_398485_2478FA1C X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2023/3/20 14:38, Krzysztof Kozlowski wrote: > On 20/03/2023 06:54, William Qiu wrote: >> >> >> On 2023/3/19 20:27, Krzysztof Kozlowski wrote: >>> On 15/03/2023 06:58, William Qiu wrote: >>>> Add documentation to describe StarFive System Controller Registers. >>>> >>>> Signed-off-by: William Qiu >>>> --- >>>> .../soc/starfive/starfive,jh7110-syscon.yaml | 41 +++++++++++++++++++ >>>> MAINTAINERS | 5 +++ >>>> 2 files changed, 46 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml >>>> new file mode 100644 >>>> index 000000000000..ae7f1d6916af >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml >>>> @@ -0,0 +1,41 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/soc/starfive/starfive,jh7110-syscon.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: StarFive JH7110 SoC system controller >>>> + >>>> +maintainers: >>>> + - William Qiu >>>> + >>>> +description: | >>>> + The StarFive JH7110 SoC system controller provides register information such >>>> + as offset, mask and shift to configure related modules such as MMC and PCIe. >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - enum: >>>> + - starfive,jh7110-aon-syscon >>>> + - starfive,jh7110-stg-syscon >>>> + - starfive,jh7110-sys-syscon >>>> + - const: syscon >>> >>> Does not look like you tested the bindings. Please run `make >>> dt_binding_check` (see >>> Documentation/devicetree/bindings/writing-schema.rst for instructions). >>> >>> ... or your PLL clock controller was not tested. >>> >>> Best regards, >>> Krzysztof >>> >> Hi Krzysztof, >> >> I've already done`make dt_binding_check`, and get no error. So maybe PLL clock controller >> was not tested which I didn't add in this patch series. And PLL clock controller belongs >> to Xingyu Wu, I would tell him. > > What's confusing you do not allow here clock controller. > > Best regards, > Krzysztof > I'll add it then. Best regards William _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv