Re: [PATCH v3 07/11] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator

Stephen Boyd
2023-02-21T22:17:33Z

Quoting Conor Dooley (2023-02-16 10:20:34)
> Hey Hal!
>
> On Thu, Feb 16, 2023 at 10:42:20PM +0800, Hal Feng wrote:
> > On Tue, 27 Dec 2022 20:15:20 +0000, Conor Dooley wrote:
> > > On Mon, Dec 26, 2022 at 12:26:32AM +0800, Hal Feng wrote:
> > >> On Tue, 20 Dec 2022 23:14:39 +0000, Conor Dooley wrote:
> > >> > On Tue, Dec 20, 2022 at 08:50:50AM +0800, Hal Feng wrote:
> > >> > > From: Emil Renner Berthing <kernel@esmil.dk>
> > >> > >
> > >> > > Add bindings for the system clock and reset generator (SYSCRG) on the
> > >> > > JH7110 RISC-V SoC by StarFive Ltd.
> > >> > >
> > >> > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
> > >> > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> > >
> > >> > > + clocks:
> > >> > > + items:
> > >> > > + - description: Main Oscillator (24 MHz)
> > >> > > + - description: GMAC1 RMII reference
> > >> > > + - description: GMAC1 RGMII RX
> > >> > > + - description: External I2S TX bit clock
> > >> > > + - description: External I2S TX left/right channel clock
> > >> > > + - description: External I2S RX bit clock
> > >> > > + - description: External I2S RX left/right channel clock
> > >> > > + - description: External TDM clock
> > >> > > + - description: External audio master clock
> > >> >
> > >> > So, from peeking at the clock driver & the dt - it looks like a bunch of
> > >> > these are not actually required?
> > >>
> > >> These clocks are used as root clocks or optional parent clocks in clock tree.
> > >> Some of them are optional, but they are required if we want to describe the
> > >> complete clock tree of JH7110 SoC.
> > >
> > > Perhaps I have a misunderstand of what required means. To me, required
> > > means "you must provide this clock for the SoC to operate in all
> > > configurations".
> > > Optional therefore would be for things that are needed only for some
> > > configurations and may be omitted if not required.
> > >
> > > From your comment below, boards with a JH7110 may choose not to populate
> > > both external clock inputs to a mux. In that case, "dummy" clocks should
> > > not have to be provided in the DT of such boards to satisfy this binding
> > > which seems wrong to me..

I agree. We don't want there to be "dummy" clks in DT. It should never
be required.

> >
> > Please see the picture of these external clocks in clock tree.
> >
> > # mount -t debugfs none /mnt
> > # cat /mnt/clk/clk_summary
> > enable prepare protect duty hardware
> > clock count count count rate accuracy phase cycle enable
> > -------------------------------------------------------------------------------------------------------
> > *mclk_ext* 0 0 0 12288000 0 0 50000 Y
> > *tdm_ext* 0 0 0 49152000 0 0 50000 Y
> > *i2srx_lrck_ext* 0 0 0 192000 0 0 50000 Y
> > *i2srx_bclk_ext* 0 0 0 12288000 0 0 50000 Y
> > *i2stx_lrck_ext* 0 0 0 192000 0 0 50000 Y
> > *i2stx_bclk_ext* 0 0 0 12288000 0 0 50000 Y
> > *gmac1_rgmii_rxin* 0 0 0 125000000 0 0 50000 Y
> > gmac1_rx 0 0 0 125000000 0 0 50000 Y
> > gmac1_rx_inv 0 0 0 125000000 0 180 50000 Y
> > *gmac1_rmii_refin* 0 0 0 50000000 0 0 50000 Y
> > gmac1_rmii_rtx 0 0 0 50000000 0 0 50000 Y
> > gmac1_tx 0 0 0 50000000 0 0 50000 N
> > gmac1_tx_inv 0 0 0 50000000 0 180 50000 Y
> > *osc* 4 4 0 24000000 0 0 50000 Y
> > apb_func 0 0 0 24000000 0 0 50000 Y
> > ...
> >
> > The clock "gmac1_rgmii_rxin" and the clock "gmac1_rmii_refin" are
> > actually used as the parent of other clocks.
>
> > The "dummy" clocks
> > you said are all internal clocks.
>
> No, what I meant by "dummy" clocks is that if you make clocks "required"
> in the binding that are not needed by the hardware for operation a
> customer of yours might have to add "dummy" clocks to their devicetree
> to pass dtbs_check.

They can set the phandle specifier to '<0>' to fill in the required
property when there isn't anything there. If this is inside an SoC, it
is always connected because silicon can't change after it is made
(unless this is an FPGA). Therefore, any and all input clocks should be
listed as required. If the clk controller has inputs that are
pads/balls/pins on the SoC then they can be optional if a valid design
can leave those pins not connected.