From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209BAC2BA2B for ; Thu, 16 Apr 2020 06:52:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E30342087E for ; Thu, 16 Apr 2020 06:52:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tBmDKWUm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E30342087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GzKnfdPHSSyk++KhyxtKH6yUrlGFiJs/c8C/QRry8IQ=; b=tBmDKWUmisOI6v acx5TnKuh6aZd9Mqs4gXIRrZBiiNdYG7g6Fg3sNG0EsPPVhT5+bVV46bVPrte3Hmye455Or7GkTmt ywrq7T2BkwVYf9ZinvBGmA+AcPcEo4lt4RLPvtA3uMqaLTT6ofnap7Orjz4624UR4cyXCNWsix+J6 UBkLg9mRTKcz1Yfh9Jm6UDi9PtsETBtfGTDOX0rQY8FNpOtn1Rs6NrIXSwnGs1lYHZD/p6RbRsD+E H6QkIB2q5hCNudUuix8Vvz1OJ9yxC4RzP40hmWoHLtrBu46HmsmlKoIdRgjMuTKZ76i8uLt4nb0W6 JxMBnxnj0mJHvx7a/bqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOyNj-0000Cj-3K; Thu, 16 Apr 2020 06:52:15 +0000 Received: from smtprelay0251.hostedemail.com ([216.40.44.251] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOyNV-0008RT-TJ; Thu, 16 Apr 2020 06:52:03 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 0A616100E7B43; Thu, 16 Apr 2020 06:51:59 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wheel34_84bb3b9f86d3c X-Filterd-Recvd-Size: 3344 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Thu, 16 Apr 2020 06:51:52 +0000 (UTC) Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref' From: Joe Perches To: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 15 Apr 2020 23:49:40 -0700 In-Reply-To: <20200416005549.9683-2-robh@kernel.org> References: <20200416005549.9683-1-robh@kernel.org> <20200416005549.9683-2-robh@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_235202_011687_AF8C63D9 X-CRM114-Status: GOOD ( 11.74 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Ulf Hansson , Heiko Stuebner , Sam Ravnborg , linux-iio@vger.kernel.org, linux-pci@vger.kernel.org, Linus Walleij , linux-remoteproc@vger.kernel.org, Alexandre Belloni , dri-devel@lists.freedesktop.org, Bjorn Andersson , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Pavel Machek , linux-riscv@lists.infradead.org, Lee Jones , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Florian Fainelli , Fabio Estevam , Daniel Lezcano , Krzysztof Kozlowski , Bartosz Golaszewski , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Guenter Roeck , linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Alexandre Torgue , alsa-devel@alsa-project.org, Maxime Ripard , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, Mark Brown , Jacek Anaszewski , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Stephen Boyd , Greg Kroah-Hartman , Dmitry Torokhov , linux-mmc@vger.kernel.org, Amit Kucheria , linux-spi@vger.kernel.org, Vinod Koul , netdev@vger.kernel.org, Jonathan Cameron Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, 2020-04-15 at 19:55 -0500, Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09 json-schema spec and '$ref' can be mixed with other > keywords. The json-schema library doesn't yet support this, but the > tooling now does a fixup for this and either way works. > > This has been a constant source of review comments, so let's change this > treewide so everyone copies the simpler syntax. This is a large change. Was this done manually or by some script? If it was done manually, how likely is it there are defects in the conversion?