Re: [PATCH v2 2/2] riscv: signal: fix signal_minsigstksz

From: Alexandre Ghiti <alex@ghiti.fr>
To: Yong-Xuan Wang <yongxuan.wang@sifive.com>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Cc: greentime.hu@sifive.com, vincent.chen@sifive.com,
	AndybnAC@gmail.com, zong.li@sifive.com,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Haibo Xu" <haibo1.xu@intel.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Usama Arif" <usamaarif642@gmail.com>,
	"Hanjun Guo" <guohanjun@huawei.com>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Alexandre Ghiti" <alexghiti@rivosinc.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Björn Töpel" <bjorn@rivosinc.com>
Subject: Re: [PATCH v2 2/2] riscv: signal: fix signal_minsigstksz
Date: Mon, 6 Jan 2025 15:07:41 +0100	[thread overview]
Message-ID: <dab16ea0-e021-4038-a6c7-bd2b1f4d84b5@ghiti.fr> (raw)
In-Reply-To: <20241220083926.19453-3-yongxuan.wang@sifive.com>

Hi Yong-Xuan,

On 20/12/2024 09:39, Yong-Xuan Wang wrote:
> The init_rt_signal_env() funciton is called before the alternative patch
> is applied, so using the alternative-related API to check the availability
> of an extension within this function doesn't have the intended effect.
> This patch reorders the init_rt_signal_env() and apply_boot_alternatives()
> to get the correct signal_minsigstksz.
>
> Fixes: e92f469b0771 ("riscv: signal: Report signal frame size to userspace via auxv")
> Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com>
> Reviewed-by: Zong Li <zong.li@sifive.com>
> ---
>   arch/riscv/kernel/setup.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 016b48fcd6f2..b7c91f546453 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -324,8 +324,8 @@ void __init setup_arch(char **cmdline_p)
>   
>   	riscv_init_cbo_blocksizes();
>   	riscv_fill_hwcap();
> -	init_rt_signal_env();
>   	apply_boot_alternatives();
> +	init_rt_signal_env();
>   
>   	if (IS_ENABLED(CONFIG_RISCV_ISA_ZICBOM) &&
>   	    riscv_isa_extension_available(NULL, ZICBOM))

Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Thanks for your fixes!

Alex

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv