* [PATCH 2/2] clk: sifive: Allow building the driver as a module
[not found] <20230717210356.2794736-1-samuel.holland@sifive.com>
@ 2023-07-17 21:03 ` Samuel Holland
2023-07-19 14:18 ` Emil Renner Berthing
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Holland @ 2023-07-17 21:03 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd
Cc: Samuel Holland, Conor Dooley, Palmer Dabbelt, Paul Walmsley,
Yang Li, linux-clk, linux-kernel, linux-riscv
This can reduce the kernel image size in multiplatform configurations.
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
---
drivers/clk/sifive/Kconfig | 2 +-
drivers/clk/sifive/sifive-prci.c | 8 +++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig
index 2322f634a910..49597d95602e 100644
--- a/drivers/clk/sifive/Kconfig
+++ b/drivers/clk/sifive/Kconfig
@@ -10,7 +10,7 @@ menuconfig CLK_SIFIVE
if CLK_SIFIVE
config CLK_SIFIVE_PRCI
- bool "PRCI driver for SiFive SoCs"
+ tristate "PRCI driver for SiFive SoCs"
default ARCH_SIFIVE
select RESET_CONTROLLER
select RESET_SIMPLE
diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
index e317f3454e93..8c67d1a7c8df 100644
--- a/drivers/clk/sifive/sifive-prci.c
+++ b/drivers/clk/sifive/sifive-prci.c
@@ -7,6 +7,7 @@
#include <linux/clkdev.h>
#include <linux/delay.h>
#include <linux/io.h>
+#include <linux/module.h>
#include <linux/of_device.h>
#include "sifive-prci.h"
#include "fu540-prci.h"
@@ -618,9 +619,6 @@ static struct platform_driver sifive_prci_driver = {
},
.probe = sifive_prci_probe,
};
+module_platform_driver(sifive_prci_driver);
-static int __init sifive_prci_init(void)
-{
- return platform_driver_register(&sifive_prci_driver);
-}
-core_initcall(sifive_prci_init);
+MODULE_LICENSE("GPL");
--
2.40.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] clk: sifive: Allow building the driver as a module
2023-07-17 21:03 ` [PATCH 2/2] clk: sifive: Allow building the driver as a module Samuel Holland
@ 2023-07-19 14:18 ` Emil Renner Berthing
2023-07-25 0:19 ` Samuel Holland
0 siblings, 1 reply; 3+ messages in thread
From: Emil Renner Berthing @ 2023-07-19 14:18 UTC (permalink / raw)
To: Samuel Holland
Cc: Michael Turquette, Stephen Boyd, Conor Dooley, Palmer Dabbelt,
Paul Walmsley, Yang Li, linux-clk, linux-kernel, linux-riscv
On Wed, 19 Jul 2023 at 10:07, Samuel Holland <samuel.holland@sifive.com> wrote:
>
> This can reduce the kernel image size in multiplatform configurations.
I don't mind this, but booting without this driver also means there is
no uart for debug output or any other peripheral until the kernel gets
to the initrd to load the driver. Does the earlycon console work all
the way until we reach the initrd? Otherwise I can't imagine many
scenarios where configuring this as a module is desirable.
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
> ---
>
> drivers/clk/sifive/Kconfig | 2 +-
> drivers/clk/sifive/sifive-prci.c | 8 +++-----
> 2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig
> index 2322f634a910..49597d95602e 100644
> --- a/drivers/clk/sifive/Kconfig
> +++ b/drivers/clk/sifive/Kconfig
> @@ -10,7 +10,7 @@ menuconfig CLK_SIFIVE
> if CLK_SIFIVE
>
> config CLK_SIFIVE_PRCI
> - bool "PRCI driver for SiFive SoCs"
> + tristate "PRCI driver for SiFive SoCs"
> default ARCH_SIFIVE
> select RESET_CONTROLLER
> select RESET_SIMPLE
> diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
> index e317f3454e93..8c67d1a7c8df 100644
> --- a/drivers/clk/sifive/sifive-prci.c
> +++ b/drivers/clk/sifive/sifive-prci.c
> @@ -7,6 +7,7 @@
> #include <linux/clkdev.h>
> #include <linux/delay.h>
> #include <linux/io.h>
> +#include <linux/module.h>
> #include <linux/of_device.h>
> #include "sifive-prci.h"
> #include "fu540-prci.h"
> @@ -618,9 +619,6 @@ static struct platform_driver sifive_prci_driver = {
> },
> .probe = sifive_prci_probe,
> };
> +module_platform_driver(sifive_prci_driver);
>
> -static int __init sifive_prci_init(void)
> -{
> - return platform_driver_register(&sifive_prci_driver);
> -}
> -core_initcall(sifive_prci_init);
Maybe also add the MODULE_AUTHOR() and MODULE_DESCRIPTION() macros
while you're at it.
> +MODULE_LICENSE("GPL");
> --
> 2.40.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] clk: sifive: Allow building the driver as a module
2023-07-19 14:18 ` Emil Renner Berthing
@ 2023-07-25 0:19 ` Samuel Holland
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Holland @ 2023-07-25 0:19 UTC (permalink / raw)
To: Emil Renner Berthing
Cc: Michael Turquette, Stephen Boyd, Conor Dooley, Palmer Dabbelt,
Paul Walmsley, Yang Li, linux-clk, linux-kernel, linux-riscv
On 2023-07-19 9:18 AM, Emil Renner Berthing wrote:
> On Wed, 19 Jul 2023 at 10:07, Samuel Holland <samuel.holland@sifive.com> wrote:
>>
>> This can reduce the kernel image size in multiplatform configurations.
>
> I don't mind this, but booting without this driver also means there is
> no uart for debug output or any other peripheral until the kernel gets
> to the initrd to load the driver. Does the earlycon console work all
> the way until we reach the initrd? Otherwise I can't imagine many
> scenarios where configuring this as a module is desirable.
Thanks for the review.
Yes, an "earlycon" command-line argument still works after this change, since
the stdout-path UART already has its clock set up by a previous boot stage.
>> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
>> ---
>>
>> drivers/clk/sifive/Kconfig | 2 +-
>> drivers/clk/sifive/sifive-prci.c | 8 +++-----
>> 2 files changed, 4 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig
>> index 2322f634a910..49597d95602e 100644
>> --- a/drivers/clk/sifive/Kconfig
>> +++ b/drivers/clk/sifive/Kconfig
>> @@ -10,7 +10,7 @@ menuconfig CLK_SIFIVE
>> if CLK_SIFIVE
>>
>> config CLK_SIFIVE_PRCI
>> - bool "PRCI driver for SiFive SoCs"
>> + tristate "PRCI driver for SiFive SoCs"
>> default ARCH_SIFIVE
>> select RESET_CONTROLLER
>> select RESET_SIMPLE
>> diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
>> index e317f3454e93..8c67d1a7c8df 100644
>> --- a/drivers/clk/sifive/sifive-prci.c
>> +++ b/drivers/clk/sifive/sifive-prci.c
>> @@ -7,6 +7,7 @@
>> #include <linux/clkdev.h>
>> #include <linux/delay.h>
>> #include <linux/io.h>
>> +#include <linux/module.h>
>> #include <linux/of_device.h>
>> #include "sifive-prci.h"
>> #include "fu540-prci.h"
>> @@ -618,9 +619,6 @@ static struct platform_driver sifive_prci_driver = {
>> },
>> .probe = sifive_prci_probe,
>> };
>> +module_platform_driver(sifive_prci_driver);
>>
>> -static int __init sifive_prci_init(void)
>> -{
>> - return platform_driver_register(&sifive_prci_driver);
>> -}
>> -core_initcall(sifive_prci_init);
>
> Maybe also add the MODULE_AUTHOR() and MODULE_DESCRIPTION() macros
> while you're at it.
Will do.
>> +MODULE_LICENSE("GPL");
>> --
>> 2.40.1
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-25 0:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230717210356.2794736-1-samuel.holland@sifive.com>
2023-07-17 21:03 ` [PATCH 2/2] clk: sifive: Allow building the driver as a module Samuel Holland
2023-07-19 14:18 ` Emil Renner Berthing
2023-07-25 0:19 ` Samuel Holland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox