Re: [PATCH v2 1/3] dt-bindings: spi: add reference file to YAML

Krzysztof Kozlowski
2023-07-13T10:13:18Z

On 13/07/2023 11:00, William Qiu wrote:
> Add primecell.yaml as a refereence file to YAML.

This we see from the diff, but why you are doing it? Please provide
rationale and answer to "why" in your commits.

Also typo: reference.

>
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
> ---
> Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> index 91e540a92faf..5e5a704a766e 100644
> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> @@ -11,6 +11,7 @@ maintainers:
>
> allOf:
> - $ref: spi-controller.yaml#
> + - $ref: /schemas/arm/primecell.yaml#
>
> # We need a select here so we don't match all nodes with 'arm,primecell'
> select:

Best regards,
Krzysztof