From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Arnd Bergmann <arnd@arndb.de>, Conor Dooley <mail@conchuod.ie>
Cc: <conor.dooley@microchip.com>, Olof Johansson <olof@lixom.net>,
linux-riscv <linux-riscv@lists.infradead.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] soc: microchip: make mpfs_sys_controller_put static
Date: Mon, 28 Feb 2022 17:25:04 +0100 [thread overview]
Message-ID: <e2a05dbb-8687-6a14-71f9-9dcf2260f5d7@microchip.com> (raw)
In-Reply-To: <CAK8P3a2y2j=zSsPtAFDZxv9b_e2SG6V5DBy__voiHRnDw5n4Aw@mail.gmail.com>
On 28/02/2022 at 16:42, Arnd Bergmann wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Sat, Feb 26, 2022 at 1:48 PM Conor Dooley <mail@conchuod.ie> wrote:
>>
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> dsafsdfd0054 ("soc: add microchip polarfire soc system controller")
>> incorrectly exported mpfs_sys_controller_put. Remove the export and make
>> the function static instead. This fixes the "no previous prototype
>> for 'mpfs_sys_controller_put'" warning spotted by the kernel test robot.
>>
>> Fixes: dsafsdfd0054 ("soc: add microchip polarfire soc system
>> controller")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> Signed-off-by: Conor Dooley <mail@conchuod.ie>
>
> For reference, I saw the same report and added a different fix for this
> at first, but replaced it with this patch now. No need to add it to the at91
> tree. Nicolas, in case there is another problem with this patch, let me know.
Ok Arnd, thanks.
For the record:
Reviewed-by: Nicolas Ferre <nicolas.ferre@microchip.com>
--
Nicolas Ferre
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2022-02-28 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 12:48 [PATCH] soc: microchip: make mpfs_sys_controller_put static Conor Dooley
2022-02-28 15:42 ` Arnd Bergmann
2022-02-28 16:25 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2a05dbb-8687-6a14-71f9-9dcf2260f5d7@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=arnd@arndb.de \
--cc=conor.dooley@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=mail@conchuod.ie \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox