From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F1E4C282C1 for ; Fri, 28 Feb 2025 02:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QNYUomTLmnjeFPQ4IsBWdqCzFRAk6HY7Y0xtdfVZnck=; b=LXJxjQZREKYLb6 WoAbDBoBssC91c1rjFtFL3hVXm9LLDv7idvygR5fDLGl90Skn2piFZScsloZWZGtGiASIIA2kxy8g OMSOeM9jLML02feA/FqYSV7VLzpOjIB9Wm62D8oE3Sz3MQS/jyvs+A6TXLXAlAMpO/q4raT+84ZW9 dqne96gwIUerXZ69gTJcDoaDsygQ86SBi7JUUOsMT9m9bC0kkWCv+V/OOuaRzUUfmYUSmENcSSO33 T8JuP1IK6mTjr0L0muLmocldEZGpE/IPJKdO3crhRILGz21QD/H5BvrYyCTqGv0B8koQ1ZQGVq8Zw zbTDOKUn9o9riMO3GA1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnqMg-00000009WBK-1jHl; Fri, 28 Feb 2025 02:44:38 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnqMc-00000009W9v-2ncp for linux-riscv@lists.infradead.org; Fri, 28 Feb 2025 02:44:36 +0000 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2fe96dd93b4so3639679a91.0 for ; Thu, 27 Feb 2025 18:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740710673; x=1741315473; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KrHEppDznEYNt+aFJHMFnsD9ySUlfKEU8kXo3t7+HP0=; b=SFMkUn2tP+coX5ljIHaBjr7iXerXaEH6ucIaRGNYdMeveB05kdHgBxH1ya1Qsxsvj3 dsFgX7w3DBWhPg8nvQmwZtRnZxC69/wLdQIqBhdyWfYTynVU+lm5ymMpiPhYW5NpsBNo ZfbJSseUHpmfM63kZstC1bYJTGrr2/IcQA4bjAKs6jBNpQyz85bAv2XyVU++m2q0ZqkH ztFbCsAP64jfPe3GhY/ujXgT5UuBqVKunvLbPpoV/GeK3oDqxGSCJrRQuAMqlZdJux5/ J6b5HY9Wr7Gs33mZFxDFvha/C2xEUrbN1Pbjdi4uUyUtskYriR1aAQ5jguv7qzIO30+/ EflQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740710673; x=1741315473; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KrHEppDznEYNt+aFJHMFnsD9ySUlfKEU8kXo3t7+HP0=; b=RKFrZnd/SpgF3I4S76CpbbQyQkiSmDoSfXOXH3aKmHbE6QYmDRkqFWcyxNL/wmXaTM PWUsaAuvfPlZ7rn52lHAzslTxwH93Ea3AoURsvDI6vhuCc18Ak8HrLqVEkpn8vx1mYpp BqlfdmbKlg5T8pr4w2/joDpdiLLABtSPFNyuL9YxCZ/cYPp3t7tfN53KLqrze1gS4Znr kynrPG/XTdVQj3pqO+rI/RBjhx0GRproLI50aSTwSbkoXSqx1BVfrqjSYB6qtPPMUdVR RAiyuDW0GDAuCxxDyZ0AgLOLXRvY/0YCOVxXaO+konuiSGxSzVKbx37ofpqhIPp2EitR h8Dw== X-Forwarded-Encrypted: i=1; AJvYcCUH4NR9tQa9m1xSmzq5CYA6NueHUUOy6FEUwOqKAGrcJEDM9UCgVSLK6xe3Vxp+95M1nYCtbOeBoRBVKA==@lists.infradead.org X-Gm-Message-State: AOJu0Yzxcwq/k8tDoy3KWtEs2xOeBk1U6w2/CTEZtjNEELtGQlCNvamQ pkQjf1zKJfXMnuhBPc1a4d/Pqk0oyBDjG/cugsCUn8AveWr+A2DIDptVw77EVy4= X-Gm-Gg: ASbGncvepkQLYwthf9fqGNWEqk4+MGAdFvhREwwtbNUrNnehZddvHYsv2fJnhHOB1JV fedpedIFqrSmFtwF8jFlJRzeKMyDDEQTxphMhqsu/wrkCJPbebPmnnwfZzVcsMNczGkPdpAwgmC EN+7GAqZjRZmhK7hIOIzcgWwsz2vcXflZOqBlizvSWVBS7oRTzi2xKb4oo9DvnraE8i4Oo9Dolz YI13dsRDLxOfLfcg9m0YVO92o0RcmnVMYvDvYTIU9aGQc1iVJQBI/CE38BIgoMyJOvYUV2Den9P 2dpoKY79R2cz/y6+ieeC7ljfNiFfCi87Q+xI9c03NoxxR0TkOg== X-Google-Smtp-Source: AGHT+IF4hsdZRiz/aSbemK655CZrsY9ZUuvu4Xu2ENST8y9hxHTSO7PJo35OmCgDgimYWycuvOakGg== X-Received: by 2002:a05:6a20:1591:b0:1ee:d19c:45f9 with SMTP id adf61e73a8af0-1f2f3e11f86mr2902815637.19.1740710672736; Thu, 27 Feb 2025 18:44:32 -0800 (PST) Received: from [10.68.122.90] ([63.216.146.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7349fe514besm2559832b3a.71.2025.02.27.18.44.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Feb 2025 18:44:32 -0800 (PST) Message-ID: Date: Fri, 28 Feb 2025 10:44:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] mm: pgtable: convert some architectures to use tlb_remove_ptdesc() To: Geert Uytterhoeven Cc: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org References: <19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250227_184434_699627_007B8D26 X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2/27/25 9:21 PM, Geert Uytterhoeven wrote: > Hi Qi, > > On Tue, 25 Feb 2025 at 04:46, Qi Zheng wrote: >> Now, the nine architectures of csky, hexagon, loongarch, m68k, mips, >> nios2, openrisc, sh and um do not select CONFIG_MMU_GATHER_RCU_TABLE_FREE, >> and just call pagetable_dtor() + tlb_remove_page_ptdesc() (the wrapper of >> tlb_remove_page()). This is the same as the implementation of >> tlb_remove_{ptdesc|table}() under !CONFIG_MMU_GATHER_TABLE_FREE, so >> convert these architectures to use tlb_remove_ptdesc(). >> >> The ultimate goal is to make the architecture only use tlb_remove_ptdesc() >> or tlb_remove_table() for page table pages. >> >> Signed-off-by: Qi Zheng >> Suggested-by: Peter Zijlstra (Intel) > > Thanks for your patch! > >> arch/m68k/include/asm/sun3_pgalloc.h | 3 +-- > > Acked-by: Geert Uytterhoeven # m68k Thanks for your review. > >> --- a/arch/m68k/include/asm/sun3_pgalloc.h >> +++ b/arch/m68k/include/asm/sun3_pgalloc.h >> @@ -19,8 +19,7 @@ extern const char bad_pmd_string[]; >> >> #define __pte_free_tlb(tlb, pte, addr) \ >> do { \ >> - pagetable_dtor(page_ptdesc(pte)); \ >> - tlb_remove_page_ptdesc((tlb), page_ptdesc(pte)); \ >> + tlb_remove_ptdesc((tlb), page_ptdesc(pte)); \ >> } while (0) >> > > With only a single statement remaining, you can remove the do { ... } > while construct, too. Ah, right. Will do in the next version. Thanks! > > Gr{oetje,eeting}s, > > Geert > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv