From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C775FC77B7C for ; Fri, 26 May 2023 09:03:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HLNBOgLcZG9JQJHM10Q9Eya6SCoIz5DbB6Fq9evn7KE=; b=UhMs7balb4FIUL +P80KSzXy2D3+mRlt68Tk190NDqfJaaMtoMuBOHl16B7mSMbPirzIAKpwug+KOfgQrcLkD7qRAYw1 3l3ixfFCOx/A44FzgI8APGQwf7bj9zFVqmDRNVnVv8VZXPHr19mfsLvJZwEmuYHdZJADO8CUA5hot jUTDgIzmtRKHKMj03wY8Yn1wcQ7Id9UVGUEQ5hraj1GnB0wYEBF7HTurWAMCBawMymfqzkcnqxNMs au8V1jWj8TyzdSoB/j57x6OAo8VkCb2cYSeLgN5yrjN5hS2fKZMJQwfAtyvCTjbi3VXqiketfonqV jub+PxYMj+kVLBJ/Q/nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2TME-001iIy-2v; Fri, 26 May 2023 09:03:34 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2TMB-001iHu-0J; Fri, 26 May 2023 09:03:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2628664E59; Fri, 26 May 2023 09:03:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56931C433EF; Fri, 26 May 2023 09:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685091809; bh=kSKZ86I+lTSZTXGMg1Akcs5h/eSGnlCoUt0BSTxhePw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=S7aAp3exjFno7lb0oMw0tw8REIvp0RgcNAnlXMPDkE8bg5nlt+H3ixeqn1Bljq1Iz xaPShxHw0v2UppdW1W+0+RX+uY52sSwOy5RsMnjUShX8RBifW5sw8gNZgckGa5BQ5F z23c04YNnfQrF45DEAWHOEGRGQBPH2lk9Hdn1BaglK2y4ix67rZr/ryOh4fPlx2ZW5 +X5lga2Go0KUqPTuzGxbG4JRnP64OKtYzSOPTBlr7ThMDal8vMUVqifIMIAIDowTbx ecJWxIjbNL5o3293G3abMhAPae6a/VP2tP7kuYTyfBw913zttqxNG/13BdmwY9c2zp GFcHzP8Gl7dMw== Message-ID: Date: Fri, 26 May 2023 12:03:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v6 0/7] Add JH7110 USB and USB PHY driver support Content-Language: en-US To: Minda Chen , Emil Renner Berthing , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, linux-riscv@lists.infradead.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Mason Huo References: <20230518112750.57924-1-minda.chen@starfivetech.com> From: Roger Quadros In-Reply-To: <20230518112750.57924-1-minda.chen@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_020331_242244_91B92E94 X-CRM114-Status: GOOD ( 31.31 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 18/05/2023 14:27, Minda Chen wrote: > This patchset adds USB driver and USB PHY for the StarFive JH7110 SoC. > USB work mode is peripheral and using USB 2.0 PHY in VisionFive 2 board. > The patch has been tested on the VisionFive 2 board. > > This patchset should be applied after the patchset [1], [2] and [3]: > [1] https://patchwork.kernel.org/project/linux-riscv/cover/20230518101234.143748-1-xingyu.wu@starfivetech.com/ > [2] https://patchwork.kernel.org/project/linux-clk/cover/20230512022036.97987-1-xingyu.wu@starfivetech.com > [3] https://patchwork.kernel.org/project/linux-phy/cover/20230412084540.295411-1-changhuang.liang@starfivetech.com/ > > This patchset is base on v6.4-rc1 > > patch 1 is usb phy dt-binding document. > patch 2 is Pcie PHY dt-binding document. > patch 3 is USB 2.0 PHY driver. > patch 4 is PCIe PHY driver. > patch 5 is usb dt-binding document. > patch 6 is the wrapper module driver of Cadence USB3. USB controller IP is Cadence USB3. > patch 7 is USB device tree configuration. > > previous version > --- > version 1 patchset are split to different kernel organization. It is > incorrect. But they were sent, and Emil sent comments. I think I should > reserve them in cover-letter. To read the change records and previous version, > please start with version 2. > > v1: https://patchwork.kernel.org/project/linux-usb/cover/20230306095212.25840-1-minda.chen@starfivetech.com/ > v2: https://patchwork.kernel.org/project/linux-usb/cover/20230308082800.3008-1-minda.chen@starfivetech.com/ > v3: https://patchwork.kernel.org/project/linux-usb/cover/20230315104411.73614-1-minda.chen@starfivetech.com/ > v4: https://patchwork.kernel.org/project/linux-usb/cover/20230406015216.27034-1-minda.chen@starfivetech.com/ > v5: https://patchwork.kernel.org/project/linux-usb/cover/20230420110052.3182-1-minda.chen@starfivetech.com/ > > changes > v6: > 1. (patch 3) remove the platform remove function. > 2. (patch 4) > - add switch to pcie mode function. > - remove the redundant init/exit function. > 3. (patch 5) > - dts split to wrapper layer and cdns node. The codes are > like v3. > - add cdns3 sub node dts-binding references. > 4. (patch 6) > For stg-syscon iomem 0x10240000 - 0x10240010 actually is belonged > to usb, so USB contain its own registers. So do not merge the dts node. > The codes are like v3. > - remove the cdns3_platform_add function. > - remove phy ops because cdns3 contain all the phy ops. > - runtime suspend function just shutdown the clocks. > 5. (patch 7) > - add cdns3 subnode again. > > v5: > 1. (patch 1) set correct model name and commit title. > 2. (patch 2) change to '-item' in syscon property. change commit title. > 3. (patch 5) > - change to '-item' in syscon configure. > - change commit title and doc title. > 4. (patch 6) > - add clk and phy deinit function > - add clk deinit function if phy init failed. > - coding style changes and other format changes. > > v4: > 1. (patch 1) split PCIe PHY dt-binding doc to patch 2. > 2. (patch 2) PCIe PHY add stg and sys con configuration to dt-binding doc. > 3. (patch 3) > - split PCIe PHY driver to patch 4. > - replace dr_mode to phy mode in jh7110_usb2_phy. > 4. (patch 4) > - Makefile and Kconfig sorted by alphabet sequence. > - Add PCIe PHY stg and syscon PHY connection configuration > for USB 3.0. > 5. (patch 5) > - commit message changed. > - merge wrapper dts node and cdns3 node in example. > - Add interrupts, reg, phy and dr_mode in property. > - Add reset-name in property example. > 6. (patch 6) > - For dts node is merged, Using platform_device_alloc and > platform_device_add to generate cadence sub device. > - IOMEM and IRQ resource are passed to Cadence sub device. > - Add PHY ops process for PHY dts setting can not be passed to > Cadence USB driver. > - remove the stg and sys USB 3.0 PHY configuration. > - Change the suspend clock reset and clock enable sequence. > - Get all reset and clock resources before enable them in > cdns_clk_rst_init. > - commit message changed. > 7. (patch 7) > - merge wrapper dts node and cdns3 node in usb dts. > - move the stg and sys USB 3.0 PHY confiuration to > PCIe PHY dts node. > - commit message changed. > - Add reset-names dts. > > v3: > 1. Add patch 1 - 4. Add USB PHY driver and dt-binding doc. > USB PHY codes are moved to patch 3 and patch 4. > 2. (patch 5) > - USB wrapper module dts document is moved to usb directory. > - Remove the 'dr_mode' and 'starfive,usb2-only' setting. > - Some dts format changes. dts binding check pass. > 3. (patch 6) > - Remove the PHY codes. > - Search 'dr_mode' and phy setting from Cadence subnode. > 4. (patch 7) > - Add USB PHY dts configurion. > - 'dr_mode' is moved to Cadence controller submode. > > v2: > 1. (patch 5) dt-binding changes. The document example is the same as dts config. > 2. (patch 6) using dev_err_probe and syscon_regmap_lookup_by_phandle_args function. Some formats changes > 3. (patch 7) dts nodes sorted by the address after @ > > Minda Chen (7): > dt-bindings: phy: Add StarFive JH7110 USB PHY > dt-bindings: phy: Add StarFive JH7110 PCIe PHY > phy: starfive: Add JH7110 USB 2.0 PHY driver > phy: starfive: Add JH7110 PCIE 2.0 PHY driver > dt-bindings: usb: Add StarFive JH7110 USB controller > usb: cdns3: Add StarFive JH7110 USB driver > riscv: dts: starfive: Add USB dts configuration for JH7110 > > .../phy/starfive,jh7110-pcie-phy.yaml | 58 +++++ > .../bindings/phy/starfive,jh7110-usb-phy.yaml | 50 ++++ > .../bindings/usb/starfive,jh7110-usb.yaml | 115 ++++++++ > MAINTAINERS | 14 + > .../jh7110-starfive-visionfive-2.dtsi | 5 + > arch/riscv/boot/dts/starfive/jh7110.dtsi | 53 ++++ > drivers/phy/starfive/Kconfig | 21 ++ > drivers/phy/starfive/Makefile | 2 + > drivers/phy/starfive/phy-jh7110-pcie.c | 204 +++++++++++++++ > drivers/phy/starfive/phy-jh7110-usb.c | 150 +++++++++++ > drivers/usb/cdns3/Kconfig | 11 + > drivers/usb/cdns3/Makefile | 1 + > drivers/usb/cdns3/cdns3-starfive.c | 246 ++++++++++++++++++ > 13 files changed, 930 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-pcie-phy.yaml > create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml > create mode 100644 Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml > create mode 100644 drivers/phy/starfive/phy-jh7110-pcie.c > create mode 100644 drivers/phy/starfive/phy-jh7110-usb.c > create mode 100644 drivers/usb/cdns3/cdns3-starfive.c > For this series: Reviewed-by: Roger Quadros _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv