From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76468C433DF for ; Mon, 6 Jul 2020 10:12:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CDE32075B for ; Mon, 6 Jul 2020 10:12:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ptBQy5Ua" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CDE32075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lBNpHvxkvc99zgARwGjGHl5pwlwq6f586xcvm5kJQ7I=; b=ptBQy5UaBhDkELVzWZNGA6DX6 UGYiACaPi9/na6z8LOCpMyBsBIhrnNPb17kvekl4KFwUt5niIpJMrOibJFZPzUxOuw0+QoifEplog x7u+8Kq9E3Wf3NuYEwkfqpcUB5mHs2Dgmbpz+8CaF8YsBrpw5LIWswt4BCUwKKG0P36jHJZaABjED upOCVw4bI+DZWVuQn38JwQRuyPOp/+AQYdlSww2HFdEbMjjTx9PVQhZ5R0UgrhgbjpfOqFHrXuWws 0ock5KKrwA5goVSnAgyPlwugevWBGkBoUgIEC0YPyoROKIslSzhNXG0FcvIk3KYXzyKjWi41/rOzg ZVry5NC5w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsO6e-0001jr-Cd; Mon, 06 Jul 2020 10:12:12 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsO6b-0001iw-U1 for linux-riscv@lists.infradead.org; Mon, 06 Jul 2020 10:12:10 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jsO6X-0005Zp-Qg; Mon, 06 Jul 2020 10:12:05 +0000 Subject: Re: syzkaller on risc-v To: David Abdurachmanov References: From: Colin Ian King Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= mQINBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABtCVDb2xpbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+iQI2BBMBCAAhBQJOkyQoAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEGjCh9/GqAImsBcP9i6C/qLewfi7iVcOwqF9avfGzOPf7CVr n8CayQnlWQPchmGKk6W2qgnWI2YLIkADh53TS0VeSQ7Tetj8f1gV75eP0Sr/oT/9ovn38QZ2 vN8hpZp0GxOUrzkvvPjpH+zdmKSaUsHGp8idfPpZX7XeBO0yojAs669+3BrnBcU5wW45SjSV nfmVj1ZZj3/yBunb+hgNH1QRcm8ZPICpjvSsGFClTdB4xu2AR28eMiL/TTg9k8Gt72mOvhf0 fS0/BUwcP8qp1TdgOFyiYpI8CGyzbfwwuGANPSupGaqtIRVf+/KaOdYUM3dx/wFozZb93Kws gXR4z6tyvYCkEg3x0Xl9BoUUyn9Jp5e6FOph2t7TgUvv9dgQOsZ+V9jFJplMhN1HPhuSnkvP 5/PrX8hNOIYuT/o1AC7K5KXQmr6hkkxasjx16PnCPLpbCF5pFwcXc907eQ4+b/42k+7E3fDA Erm9blEPINtt2yG2UeqEkL+qoebjFJxY9d4r8PFbEUWMT+t3+dmhr/62NfZxrB0nTHxDVIia u8xM+23iDRsymnI1w0R78yaa0Eea3+f79QsoRW27Kvu191cU7QdW1eZm05wO8QUvdFagVVdW Zg2DE63Fiin1AkGpaeZG9Dw8HL3pJAJiDe0KOpuq9lndHoGHs3MSa3iyQqpQKzxM6sBXWGfk EkK5Ag0ETpMkKAEQAMX6HP5zSoXRHnwPCIzwz8+inMW7mJ60GmXSNTOCVoqExkopbuUCvinN 4Tg+AnhnBB3R1KTHreFGoz3rcV7fmJeut6CWnBnGBtsaW5Emmh6gZbO5SlcTpl7QDacgIUuT v1pgewVHCcrKiX0zQDJkcK8FeLUcB2PXuJd6sJg39kgsPlI7R0OJCXnvT/VGnd3XPSXXoO4K cr5fcjsZPxn0HdYCvooJGI/Qau+imPHCSPhnX3WY/9q5/WqlY9cQA8tUC+7mgzt2VMjFft1h rp/CVybW6htm+a1d4MS4cndORsWBEetnC6HnQYwuC4bVCOEg9eXMTv88FCzOHnMbE+PxxHzW 3Gzor/QYZGcis+EIiU6hNTwv4F6fFkXfW6611JwfDUQCAHoCxF3B13xr0BH5d2EcbNB6XyQb IGngwDvnTyKHQv34wE+4KtKxxyPBX36Z+xOzOttmiwiFWkFp4c2tQymHAV70dsZTBB5Lq06v 6nJs601Qd6InlpTc2mjd5mRZUZ48/Y7i+vyuNVDXFkwhYDXzFRotO9VJqtXv8iqMtvS4xPPo 2DtJx6qOyDE7gnfmk84IbyDLzlOZ3k0p7jorXEaw0bbPN9dDpw2Sh9TJAUZVssK119DJZXv5 2BSc6c+GtMqkV8nmWdakunN7Qt/JbTcKlbH3HjIyXBy8gXDaEto5ABEBAAGJAh8EGAEIAAkF Ak6TJCgCGwwACgkQaMKH38aoAiZ4lg/+N2mkx5vsBmcsZVd3ys3sIsG18w6RcJZo5SGMxEBj t1UgyIXWI9lzpKCKIxKx0bskmEyMy4tPEDSRfZno/T7p1mU7hsM4owi/ic0aGBKP025Iok9G LKJcooP/A2c9dUV0FmygecRcbIAUaeJ27gotQkiJKbi0cl2gyTRlolKbC3R23K24LUhYfx4h pWj8CHoXEJrOdHO8Y0XH7059xzv5oxnXl2SD1dqA66INnX+vpW4TD2i+eQNPgfkECzKzGj+r KRfhdDZFBJj8/e131Y0t5cu+3Vok1FzBwgQqBnkA7dhBsQm3V0R8JTtMAqJGmyOcL+JCJAca 3Yi81yLyhmYzcRASLvJmoPTsDp2kZOdGr05Dt8aGPRJL33Jm+igfd8EgcDYtG6+F8MCBOult TTAu+QAijRPZv1KhEJXwUSke9HZvzo1tNTlY3h6plBsBufELu0mnqQvHZmfa5Ay99dF+dL1H WNp62+mTeHsX6v9EACH4S+Cw9Q1qJElFEu9/1vFNBmGY2vDv14gU2xEiS2eIvKiYl/b5Y85Q QLOHWV8up73KK5Qq/6bm4BqVd1rKGI9un8kezUQNGBKre2KKs6wquH8oynDP/baoYxEGMXBg GF/qjOC6OY+U7kNUW3N/A7J3M2VdOTLu3hVTzJMZdlMmmsg74azvZDV75dUigqXcwjE= Message-ID: Date: Mon, 6 Jul 2020 11:12:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_061210_087945_F13880CE X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Albert Ou , Andreas Schwab , Paul Walmsley , syzkaller , Palmer Dabbelt , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Tobias Klauser , linux-riscv , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org FYI, increasing the THREAD_SIZE_ORDER to 2 fixes the gcov stack crashes I'm seeing on a 5.4 kernel. On 30/06/2020 14:57, David Abdurachmanov wrote: > On Tue, Jun 30, 2020 at 4:38 PM Colin Ian King wrote: >> >> I believe I'm also seeing some potential stack smashing issues in the >> lua engine in ZFS on risc-v. It is taking a while for me to debug, but I >> don't see the failure on other arches. Is there a way to bump the stack >> size up temporarily to test with larger stacks on risc-v? > > Dmitry wrote on the original email that the follow solves issues with > KCOV enabled: > > --- a/arch/riscv/include/asm/thread_info.h > +++ b/arch/riscv/include/asm/thread_info.h > -#define THREAD_SIZE_ORDER (1) > +#define THREAD_SIZE_ORDER (2) > > I see MIPS have: > > [..] > 80 /* thread information allocation */ > 81 #if defined(CONFIG_PAGE_SIZE_4KB) && defined(CONFIG_32BIT) > 82 #define THREAD_SIZE_ORDER (1) > 83 #endif > 84 #if defined(CONFIG_PAGE_SIZE_4KB) && defined(CONFIG_64BIT) > 85 #define THREAD_SIZE_ORDER (2) > [..] > > david > >> >> Colin >> >> On 30/06/2020 14:26, David Abdurachmanov wrote: >>> On Tue, Jun 30, 2020 at 4:04 PM Andreas Schwab wrote: >>>> >>>> On Jun 30 2020, Dmitry Vyukov wrote: >>>> >>>>> I would assume some stack overflows can happen without KCOV as well. >>>> >>>> Yes, I see stack overflows quite a lot, like this: >>>> >>>> [62192.908680] Kernel panic - not syncing: corrupted stack end detected inside scheduler >>>> [62192.915752] CPU: 0 PID: 12347 Comm: ld Not tainted 5.7.5-221-default #1 openSUSE Tumbleweed (unreleased) >>>> [62192.925204] Call Trace: >>>> [62192.927646] [] walk_stackframe+0x0/0xaa >>>> [62192.933030] [] show_stack+0x2a/0x34 >>>> [62192.938066] [] dump_stack+0x6e/0x88 >>>> [62192.943098] [] panic+0xe8/0x26a >>>> [62192.947785] [] schedule+0x0/0xb2 >>>> [62192.952561] [] _cond_resched+0x32/0x44 >>>> [62192.957859] [] invalidate_mapping_pages+0xe0/0x1ce >>>> [62192.964193] [] inode_lru_isolate+0x238/0x298 >>>> [62192.970012] [] __list_lru_walk_one+0x5e/0xf6 >>>> [62192.975826] [] list_lru_walk_one+0x42/0x98 >>>> [62192.981470] [] prune_icache_sb+0x32/0x72 >>>> [62192.986941] [] super_cache_scan+0xe4/0x13e >>>> [62192.992586] [] do_shrink_slab+0x10e/0x17e >>>> [62192.998142] [] shrink_slab_memcg+0x10a/0x1de >>>> [62193.003957] [] shrink_node_memcgs+0x12e/0x1a4 >>>> [62193.009861] [] shrink_node+0xfa/0x43c >>>> [62193.015067] [] shrink_zones+0x78/0x18c >>>> [62193.020365] [] do_try_to_free_pages+0x9e/0x23e >>>> [62193.026352] [] try_to_free_pages+0xb2/0xf4 >>>> [62193.031991] [] __alloc_pages_slowpath.constprop.0+0x2d0/0x6c2 >>>> [62193.039284] [] __alloc_pages_nodemask+0x156/0x1b2 >>>> [62193.045535] [] do_anonymous_page+0x58/0x41c >>>> [62193.051266] [] handle_pte_fault+0x12e/0x156 >>>> [62193.056994] [] __handle_mm_fault+0xca/0x118 >>>> [62193.062725] [] handle_mm_fault+0xa0/0x152 >>>> [62193.068278] [] do_page_fault+0xd6/0x370 >>>> [62193.073666] [] ret_from_exception+0x0/0xc >>>> [62193.079222] [] copy_page_to_iter_iovec+0x4c/0x154 >>> >>> There was a report from Canonical that enabling gcov causes similar issues. >>> >>> linux: riscv: corrupted stack detected inside scheduler >>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1877954 >>> >>> Adding Colin to CC. So far we couldn't reproduce this locally, I >>> guess, because we don't have the right config. >>> >>> david >>> >>> >>>> >>>> or this: >>>> >>>> [200460.114397] Kernel panic - not syncing: corrupted stack end detected inside scheduler >>>> [200460.121553] CPU: 0 PID: 32619 Comm: sh Not tainted 5.7.5-221-default #1 openSUSE Tumbleweed (unreleased) >>>> [200460.131090] Call Trace: >>>> [200460.133623] [] walk_stackframe+0x0/0xaa >>>> [200460.139091] [] show_stack+0x2a/0x34 >>>> [200460.144212] [] dump_stack+0x6e/0x88 >>>> [200460.149335] [] panic+0xe8/0x26a >>>> [200460.154109] [] schedule+0x0/0xb2 >>>> [200460.158969] [] _cond_resched+0x32/0x44 >>>> [200460.164348] [] aa_sk_perm+0x38/0x138 >>>> [200460.169559] [] apparmor_socket_sendmsg+0x18/0x20 >>>> [200460.175817] [] security_socket_sendmsg+0x2a/0x42 >>>> [200460.182061] [] sock_sendmsg+0x1a/0x40 >>>> [200460.195979] [] xprt_sock_sendmsg+0xb2/0x2b6 [sunrpc] >>>> [200460.210450] [] xs_tcp_send_request+0xc6/0x206 [sunrpc] >>>> [200460.224930] [] xprt_request_transmit.constprop.0+0x88/0x218 [sunrpc] >>>> [200460.240731] [] xprt_transmit+0x9a/0x182 [sunrpc] >>>> [200460.254858] [] call_transmit+0x68/0xb8 [sunrpc] >>>> [200460.268817] [] __rpc_execute+0x84/0x222 [sunrpc] >>>> [200460.282787] [] rpc_execute+0xac/0xb8 [sunrpc] >>>> [200460.296493] [] rpc_run_task+0x122/0x178 [sunrpc] >>>> [200460.314422] [] nfs4_do_call_sync+0x64/0x84 [nfsv4] >>>> [200460.332514] [] _nfs4_proc_getattr+0xc2/0xd4 [nfsv4] >>>> [200460.350813] [] nfs4_proc_getattr+0x48/0x72 [nfsv4] >>>> [200460.363307] [] __nfs_revalidate_inode+0x104/0x2c8 [nfs] >>>> [200460.376204] [] nfs_access_get_cached+0x104/0x212 [nfs] >>>> [200460.389112] [] nfs_do_access+0xfa/0x178 [nfs] >>>> [200460.401176] [] nfs_permission+0x8e/0x184 [nfs] >>>> [200460.406497] [] inode_permission.part.0+0x78/0x118 >>>> [200460.412838] [] link_path_walk.part.0+0x1bc/0x212 >>>> [200460.419086] [] path_lookupat+0x34/0x172 >>>> [200460.424559] [] filename_lookup+0x5c/0xf4 >>>> [200460.430114] [] user_path_at_empty+0x3a/0x5e >>>> [200460.435931] [] vfs_statx+0x62/0xbc >>>> [200460.440966] [] __do_sys_newfstatat+0x24/0x3a >>>> [200460.446870] [] sys_newfstatat+0x10/0x18 >>>> [200460.452339] [] ret_from_syscall+0x0/0x2 >>>> >>>> Andreas. >>>> >>>> -- >>>> Andreas Schwab, SUSE Labs, schwab@suse.de >>>> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 >>>> "And now for something completely different." >>>> >>>> _______________________________________________ >>>> linux-riscv mailing list >>>> linux-riscv@lists.infradead.org >>>> http://lists.infradead.org/mailman/listinfo/linux-riscv >> _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv