From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 942C1C77B73 for ; Wed, 31 May 2023 06:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vPT9nSDhXtOPg7yaXiUiW4mw0Z3zAPUBxxdCxO9453Q=; b=U2gfg5zEKoc0Px k9PpFFGYH4G7DY9J64fOtYTvRIMn4INZUuhF38KspB3es0RFeYeDT6RweA3FNrSZWn94UZImaAc1L 6iJkgtjamdiKrewss60nKTeaeXArF+uqekI54iMTkBdSStVCyUNPC08AmqHiTzDxZ0qeM+Decb2lA ktZNbpxCo0bw8JEX95J4LLMWqSY6tsKA0LbIouMqi5mmEI8b3/d74gFKSJB2r6RGFMyjU5iR7LX64 0kdfwQwMI/ZeNorewol94yz+mkf1Xar4TQTFvN1n36fUSkxjr7/0cFSafdpalF15irY3wlvdxu2xW ft3hRifPDnqKqzFR3AKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4FMN-00GIiL-2n; Wed, 31 May 2023 06:31:03 +0000 Received: from ex01.ufhost.com ([61.152.239.75]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4FMK-00GIeF-0j for linux-riscv@lists.infradead.org; Wed, 31 May 2023 06:31:02 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 8674F24E1FC; Wed, 31 May 2023 14:30:21 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 31 May 2023 14:30:21 +0800 Received: from [192.168.125.124] (113.72.147.198) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 31 May 2023 14:30:20 +0800 Message-ID: Date: Wed, 31 May 2023 14:30:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v5 3/3] riscv: dts: starfive: add the node and pins configuration for tdm To: Hal Feng , Mark Brown , Liam Girdwood , Claudiu Beznea , Jaroslav Kysela , "Takashi Iwai" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Emil Renner Berthing" CC: , , , References: <20230526145402.450-1-walker.chen@starfivetech.com> <20230526145402.450-4-walker.chen@starfivetech.com> Content-Language: en-US From: Walker Chen In-Reply-To: X-Originating-IP: [113.72.147.198] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_233100_561427_BB398CD6 X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2023/5/31 14:23, Hal Feng wrote: > On Fri, 26 May 2023 22:54:02 +0800, Walker Chen wrote: >> Add the tdm controller node and pins configuration of tdm for the >> StarFive JH7110 SoC. >> >> Signed-off-by: Walker Chen >> --- >> .../jh7110-starfive-visionfive-2.dtsi | 40 +++++++++++++++++++ >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 21 ++++++++++ >> 2 files changed, 61 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> index 1155b97b593d..19b5954ee72d 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> @@ -214,6 +214,40 @@ >> slew-rate = <0>; >> }; >> }; >> + >> + tdm0_pins: tdm0-pins { >> + tdm0-pins-tx { > > Use consistent naming, so > > tdm_pins: tdm-0 { > tx-pins { > >> + pinmux = > + GPOEN_ENABLE, >> + GPI_NONE)>; >> + bias-pull-up; >> + drive-strength = <2>; >> + input-disable; >> + input-schmitt-disable; >> + slew-rate = <0>; >> + }; >> + >> + tdm0-pins-rx { > > rx-pins { > >> + pinmux = > + GPOEN_DISABLE, >> + GPI_SYS_TDM_RXD)>; >> + input-enable; >> + }; >> + >> + tdm0-pins-sync { > > sync-pins { > >> + pinmux = > + GPOEN_DISABLE, >> + GPI_SYS_TDM_SYNC)>; >> + input-enable; >> + }; >> + >> + tdm0-pins-pcmclk { > > pcmclk-pins { > >> + pinmux = > + GPOEN_DISABLE, >> + GPI_SYS_TDM_CLK)>; >> + input-enable; >> + }; >> + }; >> }; >> >> &uart0 { >> @@ -221,3 +255,9 @@ >> pinctrl-0 = <&uart0_pins>; >> status = "okay"; >> }; >> + >> +&tdm { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&tdm0_pins>; > > pinctrl-0 = <&tdm_pins>; > > Best regards, > Hal OK, I'll update these node's name in the next submit. Thanks. Best regards, Walker _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv