From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8017AC4332F for ; Thu, 24 Nov 2022 09:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0ZB82hNi1PCOwCvxCiWQksYFxy+8POIAnhqpHlRUPeU=; b=x6/UFij0u0IxBv veAl/BrGH8u1r9+Sxltllr2dnmTAFeoqKYhAi1kjWPPoE+Kx6UILfbJhJNkMGM1cOS+VmCQfVv4yQ panmyOVTTl2lgnlCw2zebD8xChS+DO2OyYd1twYaaOKR3HF6vaTjiPgQhmc/494iSSCR7Y+k4ZLNs jGeK5UZcScE+t32dr6B7p9tQvZlerM4bCPaBF9oyN+aNnmnn380P0YN+e0BDNdaTNC4qG/bn5t/r/ Rgi+5DDPbaR7CxFBE1FHqIjc6GqapYuL5yygns2zqlKKV5+Lr/0cHo/KXZ+xnG0Qr9mEYBt41YDX0 X5ioOyE6eePL0gn2x97Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oy8mq-007Gqj-4W; Thu, 24 Nov 2022 09:44:52 +0000 Received: from fd01.gateway.ufhost.com ([61.152.239.71]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oy8mk-007Gb9-TM for linux-riscv@lists.infradead.org; Thu, 24 Nov 2022 09:44:50 +0000 Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 0F58D24E2E7; Thu, 24 Nov 2022 17:44:15 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 24 Nov 2022 17:44:15 +0800 Received: from [192.168.125.96] (183.27.97.81) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 24 Nov 2022 17:44:14 +0800 Message-ID: Date: Thu, 24 Nov 2022 17:44:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 3/4] soc: starfive: Add StarFive JH71XX pmu driver Content-Language: en-US To: Conor Dooley CC: Emil Renner Berthing , , , , Rob Herring , "Krzysztof Kozlowski" , "Rafael J . Wysocki" , References: <20221118133216.17037-1-walker.chen@starfivetech.com> <20221118133216.17037-4-walker.chen@starfivetech.com> <6303c341-a691-fd52-2861-74e9d3ea09c9@starfivetech.com> From: Walker Chen In-Reply-To: X-Originating-IP: [183.27.97.81] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221124_014447_255573_26BE3219 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2022/11/24 17:28, Conor Dooley wrote: > Hey Walker, > Just jumping in here... > > On Thu, Nov 24, 2022 at 05:08:57PM +0800, Walker Chen wrote: >> On 2022/11/19 2:31, Emil Renner Berthing wrote: >> > On Fri, 18 Nov 2022 at 14:35, Walker Chen wrote: > >> >> diff --git a/include/soc/starfive/pm_domains.h b/include/soc/starfive/pm_domains.h >> >> new file mode 100644 >> >> index 000000000000..a20e28e9baf3 >> >> --- /dev/null >> >> +++ b/include/soc/starfive/pm_domains.h >> >> @@ -0,0 +1,15 @@ >> >> +/* SPDX-License-Identifier: GPL-2.0 */ >> >> +/* >> >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. >> >> + * Author: Walker Chen >> >> + */ >> >> + >> >> +#ifndef __SOC_STARFIVE_PMDOMAINS_H__ >> >> +#define __SOC_STARFIVE_PMDOMAINS_H__ >> >> + >> >> +#include >> >> + >> >> +void starfive_pmu_hw_event_turn_on(u32 mask); >> >> +void starfive_pmu_hw_event_turn_off(u32 mask); >> >> + >> >> +#endif /* __SOC_STARFIVE_PMDOMAINS_H__ */ >> > >> > The header and functions within are named very generic, but >> > implemented by the jh71xx-specific driver. >> > >> > Also who should use this header? These functions are never called by >> > anything in this series. >> >> These two functions will be used by the GPU module. Only the power-off >> of the GPU is not controlled by the software through PMU module. So >> here the functions are needed to export. > > ...the general policy is to avoid adding things without users. I think > they should be kept as static functions for now & when your GPU driver > is being upstreamed you can expose these functions. That way your usage > of them can be reviewed with the appropriate context. > OK, thank you for your advice. I will modify the code according to your suggestion in the next version of patch. Best Regards, Walker Chen _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv