From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A310C636CC for ; Fri, 3 Feb 2023 03:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TjsdGRVvMf6pftGwAJ33bguX0dStc9ZQ0j6N7crZw4c=; b=1eYmN2uk3tHXEA rUjC4aKfkw/uYAqnlDI6BUSpc94t5pw8BnHktHTC+5FPp4qPy5LRRzI7Ipo5EYwkrI7LIWmnRBn8E +5DcdC09k2Mm10I3utPCOJwnF+EzTHQ9u0LkyWIqyDOj5UAGC/K3Sp6jDigN9dotE5YRrhL+0Ei2J NyqLXpfdgvcVVi4sTNXTHdiFEu3ZCRT1krA691IIojLUFJMS/iZx2cZRrrS0E6CPhAxKEaU3V0DTo AdfML6cfDipN7gnAv3HxJYNjnluCZg4JwCeqvgoKD6yFmFqmTbDWhCazxkv0htXHXLBpOJcY5ErY+ cV4PALOGUAzt5br8+2AA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNmXu-0009dx-HN; Fri, 03 Feb 2023 03:15:26 +0000 Received: from fd01.gateway.ufhost.com ([61.152.239.71]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNmXq-0009d3-TN for linux-riscv@lists.infradead.org; Fri, 03 Feb 2023 03:15:25 +0000 Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 281BF24E13F; Fri, 3 Feb 2023 11:14:59 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 3 Feb 2023 11:14:59 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 3 Feb 2023 11:14:57 +0800 Message-ID: Date: Fri, 3 Feb 2023 11:14:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Richard Cochran , Andrew Lunn , Heiner Kallweit , Peter Geis References: <20230118061701.30047-1-yanhong.wang@starfivetech.com> <20230118061701.30047-7-yanhong.wang@starfivetech.com> <55f020de-6058-67d2-ea68-6006186daee3@linaro.org> From: yanhong wang In-Reply-To: <55f020de-6058-67d2-ea68-6006186daee3@linaro.org> X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_191523_263547_B5AE4028 X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 2023/1/18 23:51, Krzysztof Kozlowski wrote: > On 18/01/2023 07:17, Yanhong Wang wrote: >> Add JH7110 ethernet device node to support gmac driver for the JH7110 >> RISC-V SoC. >> >> Signed-off-by: Yanhong Wang >> --- >> arch/riscv/boot/dts/starfive/jh7110.dtsi | 93 ++++++++++++++++++++++++ >> 1 file changed, 93 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> index c22e8f1d2640..c6de6e3b1a25 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> @@ -433,5 +433,98 @@ >> reg-shift = <2>; >> status = "disabled"; >> }; >> + >> + stmmac_axi_setup: stmmac-axi-config { > > Why your bindings example is different? > There are two gmacs on the StarFive VF2 board, and the two gmacs use the same configuration on axi, so the stmmac_axi_setup is independent, which is different from the bindings example. > Were the bindings tested? Ahh, no they were not... Can you send only > tested patches? > > Was this tested? > Yes, the bindings have been tested on the StarFive VF2 board and work normally. >> + snps,lpi_en; >> + snps,wr_osr_lmt = <4>; >> + snps,rd_osr_lmt = <4>; >> + snps,blen = <256 128 64 32 0 0 0>; >> + }; >> + > > Best regards, > Krzysztof > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv